core::dbus::Service constructor ignores return value of dbus_request_name(), hiding failures
Bug #1329211 reported by
James Henstridge
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
dbus-cpp |
Fix Released
|
High
|
Thomas Voß | ||
dbus-cpp (Ubuntu) |
Fix Released
|
Undecided
|
Thomas Voß |
Bug Description
The core::dbus::Service constructor ignores the return value of dbus_bus_
When used with the core::dbus:
http://
The function could return one of:
* DBUS_REQUEST_
* DBUS_REQUEST_
* DBUS_REQUEST_
The "exists" response should probably be treated as an error.
Related branches
lp:~thomas-voss/dbus-cpp/fix-1329211
- Pete Woods (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
- James Henstridge: Pending requested
-
Diff: 101 lines (+69/-5)2 files modifiedsrc/core/dbus/service.cpp (+14/-1)
tests/service_test.cpp (+55/-4)
Changed in dbus-cpp: | |
status: | New → Confirmed |
status: | Confirmed → In Progress |
importance: | Undecided → High |
assignee: | nobody → Thomas Voß (thomas-voss) |
Changed in dbus-cpp (Ubuntu): | |
assignee: | nobody → Thomas Voß (thomas-voss) |
status: | New → In Progress |
Changed in dbus-cpp: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
This bug was fixed in the package dbus-cpp - 4.0.0+14. 10.20140730- 0ubuntu1
--------------- 14.10.20140730- 0ubuntu1) utopic; urgency=low
dbus-cpp (4.0.0+
[ Ubuntu daily release ] libdbus- cpp4.symbols. 32bit: auto-update to released version libdbus- cpp4.symbols. 64bit: auto-update to released version
* debian/
* debian/
[ thomas-voss ] :Service: :Service( ...) interprets return request_ name correctly. (LP: #1329211)
* Make sure that dbus daemon instances fired up for testing are torn
down after a configurable timeout. (LP: #1326200)
* Make sure that core::dbus:
values of dbus_bus_
-- Ubuntu daily release <email address hidden> Wed, 30 Jul 2014 16:12:30 +0000