[MIR] uhttpmock

Bug #1327458 reported by Jackson Doak
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
uhttpmock (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Availability: The package is in universe and builds one all architectures except ppc64el (patch waiting sponsorship)

Rationale: libuhttpmock-dev is a build-depend of the version of libgdata in -proposed and is needed for it's unit tests to work.

Security/QA: No bugs have been found in debian or ubuntu, upstream and debian both are actively maintained, there are no results in either security tracker

Depends: All are in main

Standards-compliance: All good

Maintenance: Simple package, we can keep in sync. I've not yet found an ubuntu team to "own" the package

Background info: uhttpmock is a HTTP web service mocking project for projects which use libsoup.

Revision history for this message
Sebastien Bacher (seb128) wrote :

(subscribing ubuntu-mir, that was missing there)

Revision history for this message
Michael Terry (mterry) wrote :

Blockers:
- As noted, needs a fix for ppc64el
- Needs a team bug subscriber for whomever will look after this in Ubuntu
- ${gir:Depends} is empty, is there a missing "--with" argument to dh?
- The two following build warnings seem like actual problems. Can I get a comment on why they aren't problems or a fix for them? (Should just be setting a couple NULLs)
libuhttpmock/uhm-server.c: In function 'trace_to_soup_message':
libuhttpmock/uhm-server.c:912:17: warning: 'message' may be used uninitialized in this function [-Wmaybe-uninitialized]
  g_object_unref (message);
                 ^
libuhttpmock/uhm-server.c:849:32: warning: 'http_version' may be used uninitialized in this function [-Wmaybe-uninitialized]
  soup_message_set_http_version (message, http_version);
                                ^

Other Comments:
- I am not thrilled with this taking the presumably-desirable three-letter namespace uhm, but that was Debian's call
- The lib package should use "Pre-Depends: ${misc:Pre-Depends}"
- The dev package shouldn't ship the .a file, right?
- Would love to see a symbols file, please consider including one
- Love the tests!

Changed in uhttpmock (Ubuntu):
status: New → Incomplete
Revision history for this message
Jackson Doak (noskcaj) wrote :

- As noted, needs a fix for ppc64el
- Needs a team bug subscriber for whomever will look after this in Ubuntu

These two issues was why i didn't subscribe the mir team yet. I'll look into the other changes in debian

Revision history for this message
Philip Withnall (drbob) wrote :

> - The two following build warnings seem like actual problems. Can I get a comment on why they aren't problems or a fix for them? (Should just be setting a couple NULLs)

Fixed upstream in commit d35158c3b61d18d04c07fb2ab5535b3e05d778fb. I’ll release a 0.4.0 tonight containing the fix.

Revision history for this message
Philip Withnall (drbob) wrote :

Sorry, make that version 0.3.0.

Revision history for this message
Jackson Doak (noskcaj) wrote :

Most of the main issues are fixed in the new release. Is the desktop team willing to maintain this as it's libgdata that needs it?

Changed in uhttpmock (Ubuntu):
status: Incomplete → New
Revision history for this message
Michael Terry (mterry) wrote :

Looks good besides the bug subscriber! Just get a team to commit to look after this, and we're good.

Revision history for this message
Iain Lane (laney) wrote :

Yeah, desktop team will be happy to do this.

I can't subscribe them myself, but will make sure that it's done. Hopefully you can ack and trust me. :)

Revision history for this message
Michael Terry (mterry) wrote :

OK

Changed in uhttpmock (Ubuntu):
status: New → Fix Committed
Revision history for this message
Colin Watson (cjwatson) wrote :

Moved to main.

Changed in uhttpmock (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.