missing nova quota_class test to change default quota values

Bug #1325727 reported by Joe Gordon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tempest
Fix Released
Medium
Matt Riedemann

Bug Description

We mistakenly removed a working part of an API: changing default quota values via quota class.

If we had tempest testing for this feature, we wouldn't have removed it. At the time the patch author (me) wasn't aware of the default quota functionality as it was not the primary feature of this API.

Revision history for this message
Joe Gordon (jogo) wrote :
Revision history for this message
Matt Riedemann (mriedem) wrote :

Oh right the Tempest test bug is reported under bug 1325727.

Revision history for this message
Matt Riedemann (mriedem) wrote :

Bug 1299517 restored the nova api in stable/icehouse and master.

Here are the docs on updating default quota values:

http://docs.openstack.org/trunk/config-reference/content/cli_set_compute_tenant_quotas_procedure.html

Note that os-quota-classes doesn't show up in the API docs at all:

http://developer.openstack.org/api-ref-compute-v2-ext.html
http://docs.openstack.org/api/openstack-compute/2/content/

Changed in tempest:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Matt Riedemann (mriedem)
Revision history for this message
Matt Riedemann (mriedem) wrote :

quota-class-update requires admin context so this is going to have to be a compute admin API test in Tempest.

http://git.openstack.org/cgit/openstack/nova/tree/nova/db/sqlalchemy/api.py#n2930

Revision history for this message
Matt Riedemann (mriedem) wrote :

The new tests will impact default quotas for all tenants so they have to be externally locked from running at the same time as any other tests that deal with quotas.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/100342

Changed in tempest:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tempest (master)

Reviewed: https://review.openstack.org/100342
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=848805f21b30548832302345759b7d648e15d2be
Submitter: Jenkins
Branch: master

commit 848805f21b30548832302345759b7d648e15d2be
Author: Matt Riedemann <email address hidden>
Date: Mon Jun 16 13:23:51 2014 -0700

    Add test for compute API os-quota-class-sets

    This tests showing and updating the 'default' quota class, which is
    really all this API is used for. It was removed in Icehouse in part to
    not knowing it was used even though python-novaclient and Horizon were
    using it. The removal was reverted and this change is to enforce what
    the API is used for.

    The extension only lives in the Nova v2 API, it was removed in the v3
    API in Icehouse.

    This change adds new quota client and test classes for the new API.

    An external lock fixture is used in all compute API quota tests to
    avoid introducing race bugs with the existing tenant-specific
    os-quota-sets tests.

    Closes-Bug: #1325727

    Change-Id: Ib0cde08dfaa0f6a5e180d247864fb59d76eca903

Changed in tempest:
status: In Progress → Fix Released
Matt Riedemann (mriedem)
Changed in tempest:
milestone: none → juno-2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.