OpenStack Compute (nova)

Cells - prominent hypervisor version filter bug

Bug #1325705 reported by Brian Elliott on 2014-06-02

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	Undecided	Brian Elliott	OpenStack Compute (nova) 2014.2 "juno"

Bug Description

Commit 0c22f71fb338b1aa7c4a2b30555449a464ad3874 introduced a filter that allowed the cells scheduler to route instance builds to cells with a matching 'prominent' hypervisor version. (nova.cells.filters.image_properties.ImagePropertiesFilter).

This filter has a bug where the set of cell capabilities is mutated via set pop(). This causes a race where the filter can fail if it runs again before the capabilities list gets repopulated from the child cell.

Brian Elliott (belliott) on 2014-06-02

Changed in nova:
assignee:	nobody → Brian Elliott (belliott)

OpenStack Infra (hudson-openstack) on 2014-06-02

Changed in nova:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-06-08: Fix merged to nova (master)

Reviewed: https://review.openstack.org/97330
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9b45d7e294ef3a872f1c22d5c22753550f91857f
Submitter: Jenkins
Branch: master

commit 9b45d7e294ef3a872f1c22d5c22753550f91857f
Author: Brian Elliott <email address hidden>
Date: Thu May 29 21:04:20 2014 +0000

Fix state mutation in cells image filter

    Stop set pop() operations in the cells ImagePropertiesFilter from
    mutating capability state. This causes a race that can break the
    filter between requests.

Closes-Bug #1325705

Change-Id: I901e39046a38ab60c23ddc8762ef5d19a297935b