Ubuntu
unity-scope-click package

Soundcloud scope installs, but always shows as installable

Bug #1325224 reported by Alan Pope 🍺🐧🐱 🦄
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity-scopes-api
Fix Released
High
Pete Woods
unity-scope-click (Ubuntu)
Fix Released
High
Alejandro J. Cura

Bug Description

Installing the soundcloud scope on #50 mako has no effect.

The scope still shows up as installable under Available Apps

Tags: avengers

Related branches

lp:~alecu/unity-scope-click/uninstall-scopes
Alejandro J. Cura (community): Disapprove
PS Jenkins bot (community): Approve (continuous-integration)
Paweł Stołowski (community): Needs Fixing
Diff: 1327 lines (+446/-175)
16 files modified
libclickscope/click/index.cpp (+3/-3)
libclickscope/click/index.h (+1/-1)
libclickscope/click/interface.cpp (+73/-22)
libclickscope/click/interface.h (+13/-4)
libclickscope/click/package.cpp (+4/-7)
libclickscope/click/package.h (+24/-4)
libclickscope/click/preview.cpp (+43/-32)
libclickscope/click/preview.h (+3/-2)
libclickscope/tests/fake_json.h (+28/-0)
libclickscope/tests/test_index.cpp (+12/-12)
libclickscope/tests/test_interface.cpp (+96/-18)
scope/clickstore/store-query.cpp (+37/-25)
scope/clickstore/store-query.h (+6/-3)
scope/tests/click_interface_tool/click_interface_tool.cpp (+2/-2)
scope/tests/integration/webclient_integration.cpp (+2/-2)
scope/tests/test_query.cpp (+99/-38)
lp:~unity-api-team/unity-scopes-api/non-pre-existing-click-dir
Pete Woods (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 404 lines (+227/-55)
5 files modified
scoperegistry/DirWatcher.cpp (+3/-3)
scoperegistry/ScopesWatcher.cpp (+154/-48)
scoperegistry/ScopesWatcher.h (+8/-3)
test/gtest/scopes/Registry/RegistryTest.ini.in (+1/-1)
test/gtest/scopes/Registry/Registry_test.cpp (+61/-0)
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Unity Team: Pending requested
Diff: 1306 lines (+1032/-153) (has conflicts)
9 files modified
RELEASE_NOTES.md (+7/-0)
debian/changelog (+23/-0)
scoperegistry/DirWatcher.cpp (+280/-0)
scoperegistry/ScopesWatcher.cpp (+283/-0)
scoperegistry/ScopesWatcher.h (+67/-0)
test/gtest/scopes/CMakeLists.txt (+5/-0)
test/gtest/scopes/Registry/RegistryTest.ini.in (+1/-1)
test/gtest/scopes/Registry/Registry_test.cpp (+365/-151)
test/gtest/scopes/internal/zmq_middleware/CMakeLists.txt (+1/-1)
lp:~unity-api-team/unity-scopes-api/click-store-support
PS Jenkins bot (community): Approve (continuous-integration)
Unity Team: Pending requested
Diff: 2465 lines (+1355/-216)
45 files modified
CMakeLists.txt (+1/-1)
debian/changelog (+9/-0)
debian/control (+2/-1)
debian/libunity-scopes1.symbols (+4/-3)
include/unity/scopes/Registry.h (+29/-1)
include/unity/scopes/internal/MWRegistry.h (+11/-0)
include/unity/scopes/internal/MWSubscriber.h (+4/-3)
include/unity/scopes/internal/RegistryImpl.h (+4/-0)
include/unity/scopes/internal/RegistryObject.h (+9/-3)
include/unity/scopes/internal/RegistryObjectBase.h (+1/-0)
include/unity/scopes/internal/smartscopes/SSRegistryObject.h (+1/-0)
include/unity/scopes/internal/zmq_middleware/RegistryI.h (+4/-0)
include/unity/scopes/internal/zmq_middleware/ZmqRegistry.h (+1/-0)
include/unity/scopes/internal/zmq_middleware/ZmqSubscriber.h (+3/-8)
include/unity/scopes/testing/MockRegistry.h (+9/-0)
scoperegistry/CMakeLists.txt (+2/-0)
scoperegistry/DirWatcher.cpp (+272/-0)
scoperegistry/DirWatcher.h (+79/-0)
scoperegistry/FindFiles.cpp (+35/-23)
scoperegistry/FindFiles.h (+17/-9)
scoperegistry/ScopesWatcher.cpp (+184/-0)
scoperegistry/ScopesWatcher.h (+57/-0)
scoperegistry/scoperegistry.cpp (+136/-100)
src/scopes/internal/MWRegistry.cpp (+23/-1)
src/scopes/internal/MWSubscriber.cpp (+5/-0)
src/scopes/internal/RegistryImpl.cpp (+15/-0)
src/scopes/internal/RegistryObject.cpp (+93/-21)
src/scopes/internal/smartscopes/SSRegistryObject.cpp (+5/-0)
src/scopes/internal/zmq_middleware/ObjectAdapter.cpp (+3/-3)
src/scopes/internal/zmq_middleware/RegistryI.cpp (+24/-1)
src/scopes/internal/zmq_middleware/ZmqRegistry.cpp (+34/-0)
src/scopes/internal/zmq_middleware/ZmqSubscriber.cpp (+13/-18)
src/scopes/internal/zmq_middleware/capnproto/Registry.capnp (+14/-0)
test/gtest/scopes/CMakeLists.txt (+3/-3)
test/gtest/scopes/Registry/CMakeLists.txt (+1/-0)
test/gtest/scopes/Registry/Registry_test.cpp (+216/-5)
test/gtest/scopes/Registry/other_scopes/CMakeLists.txt (+2/-0)
test/gtest/scopes/Registry/other_scopes/testscopeC/CMakeLists.txt (+1/-0)
test/gtest/scopes/Registry/other_scopes/testscopeC/testscopeC.ini.in (+8/-0)
test/gtest/scopes/Registry/other_scopes/testscopeD/CMakeLists.txt (+1/-0)
test/gtest/scopes/Registry/other_scopes/testscopeD/testscopeD.ini.in (+8/-0)
test/gtest/scopes/internal/RegistryObject/RegistryObject_test.cpp (+1/-1)
test/gtest/scopes/internal/zmq_middleware/CMakeLists.txt (+1/-1)
test/gtest/scopes/internal/zmq_middleware/PubSub/PubSub_test.cpp (+4/-4)
test/gtest/scopes/internal/zmq_middleware/RegistryI/RegistryI_test.cpp (+6/-6)
lp:~alecu/unity-scope-click/uninstallable-scopes
PS Jenkins bot (community): Approve (continuous-integration)
dobey (community): Approve
Paweł Stołowski (community): Approve
Diff: 851 lines (+419/-85)
10 files modified
libclickscope/click/interface.cpp (+56/-6)
libclickscope/click/interface.h (+9/-0)
libclickscope/click/package.cpp (+5/-4)
libclickscope/click/package.h (+9/-0)
libclickscope/click/preview.cpp (+39/-17)
libclickscope/tests/fake_json.h (+72/-0)
libclickscope/tests/test_interface.cpp (+96/-0)
scope/clickstore/store-query.cpp (+36/-24)
scope/clickstore/store-query.h (+5/-3)
scope/tests/test_query.cpp (+92/-31)
lp:ubuntu/utopic-proposed/unity-scope-click
Thomas Strehl (strehl-t)
Changed in unity-scope-click (Ubuntu):
assignee: nobody → Alejandro J. Cura (alecu)
Revision history for this message
Pete Woods (pete-woods) wrote :

Two things need to happen here:
 - We need the branch that makes the scopes service detect newly installed scopes to land: https://code.launchpad.net/~unity-api-team/unity-scopes-api/click-store-support/+merge/221679
 - We also need the click scope to understand scopes in addition to apps.

Revision history for this message
Pete Woods (pete-woods) wrote :

At the moment, the scope determines if something is "installed and also an app" by checking if it has a desktop file. Everything else is assumed to be uninstalled. I guess we need a new category for "installed and also a scope" in this scope?

Alejandro J. Cura (alecu)
Changed in unity-scope-click (Ubuntu):
importance: Undecided → High
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

Would it be prudent to remove the click from the store so others don't get this issue, until the necessary bits and pieces are done?

Revision history for this message
dobey (dobey) wrote :

 - We also need the click scope to understand scopes in addition to apps.

The store itself does not understand click packages that are not apps, at the moment. It currently treats everything as apps, and only really supports apps. So I've added click-package-index to this bug as well.

James Tait (jamestait)
Changed in click-package-index:
status: New → Triaged
importance: Undecided → High
Pete Woods (pete-woods)
Changed in unity-scopes-api:
assignee: nobody → Pete Woods (pete-woods)
importance: Undecided → High
status: New → In Progress
Alejandro J. Cura (alecu)
Changed in unity-scope-click (Ubuntu):
status: New → In Progress
Pete Woods (pete-woods)
Changed in unity-scopes-api:
status: In Progress → Fix Released
dobey (dobey)
Changed in unity-scope-click (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-scope-click - 0.1+14.10.20140618-0ubuntu1

---------------
unity-scope-click (0.1+14.10.20140618-0ubuntu1) utopic; urgency=medium

  [ Rodney Dawes ]
  * New upstream release.
    - Translation updates.
    - Split scope into two scopes, Apps and Store.
    - Move core functionality into a static library shared by both scopes.
    - Sort installed apps alphabetically, based on current locale.
    - Add build dependency on libboost-locale-dev for locale based sorting.
    - Only build on amd64 armhf and i386, as ubuntu-sdk-libs.
    - Create the log handler ourselves. (LP: #1322501)
    - Convert autopilot tests to python3.
    - Remove the dependency on ubuntu-purchase-service. (LP: #1323334)
    - Remove extra dependencies and test restrictions from autopkgtests.
    - Load keywords from .desktop files and search them. (LP: #1316237)
    - Label installed packages as such in store scope.
    - Allow launching installed scopes from store scope preview.
    - Don't filter out installed packages from store scope. (LP: #1325224)
 -- Ubuntu daily release <email address hidden> Wed, 18 Jun 2014 06:33:38 +0000

Changed in unity-scope-click (Ubuntu):
status: Fix Committed → Fix Released
James Tait (jamestait)
Changed in click-package-index:
status: Triaged → Fix Committed
James Tait (jamestait)
Changed in click-package-index:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.