"Applications Menu" title shows by default, despite unchecked box

[Chris]

When adding a new "Applications Menu" to the panel, it shows a button title by default. However, in the properties dialogue, the "Show button title" checkbox is unchecked.

Simply checking and unchecking the box resolves the issue.

ProblemType: Bug
DistroRelease: Ubuntu 14.04
Package: xfce4-panel 4.11.0-0ubuntu1
ProcVersionSignature: Ubuntu 3.13.0-27.50-generic 3.13.11
Uname: Linux 3.13.0-27-generic x86_64
NonfreeKernelModules: nvidia
ApportVersion: 2.14.1-0ubuntu3.2
Architecture: amd64
CurrentDesktop: XFCE
Date: Sun May 25 11:09:15 2014
SourcePackage: xfce4-panel
UpgradeStatus: No upgrade log present (probably fresh install)

[Thaddaeus Tintenfisch (thad-fisch-deactivatedaccount)]

When adding a new "Applications Menu" to the panel, it shows a button title by default. However, in the properties dialogue, the "Show button title" checkbox is unchecked.

Simply checking and unchecking the box resolves the issue.

xfce4-panel 4.11.0

[Tekk-5 (tekk-5)]

Created attachment 5977
Don't blindly assume that the button label should be on by default

Just generated it with git diff against the current head as of today (February 21st)

[Simon Steinbeiß (ochosi)]

*** Bug 11641 has been marked as a duplicate of this bug. ***

[Adam Purkrt (adam-purkrt-deactivatedaccount)]

Though agreeably a minor bug, it is somehow confusing to the user. I've encountered it numerous times, when switching the label off after installation. Glad to see someone has been working on this.

Tried the patch. The "Properties" dialog indeed correctly reflects the visual outcome.

But I see a problem in the fact that the label becomes "off" by default. This effectively changes the default config (its final visual outcome for the user). Arguably, many (if not most) of the users are used to having the label present, and don't care whether this switch is working correctly or not.

[Tekk-5 (tekk-5)]

(In reply to Adam Purkrt from comment #3)
> Though agreeably a minor bug, it is somehow confusing to the user. I've
> encountered it numerous times, when switching the label off after
> installation. Glad to see someone has been working on this.
>
> Tried the patch. The "Properties" dialog indeed correctly reflects the
> visual outcome.
>
> But I see a problem in the fact that the label becomes "off" by default.
> This effectively changes the default config (its final visual outcome for
> the user). Arguably, many (if not most) of the users are used to having the
> label present, and don't care whether this switch is working correctly or
> not.

Wow, this patch still applies? I figured it was just stuck languishing for forever. It'd be easy enough to swap the defaults around, I just choose to have the ui reflect the behavior that was actually happening rather than the other way around; if there's actually any interest in merging the patch I'd be happy to orient it whichever way the dev wants.

[Adam Purkrt (adam-purkrt-deactivatedaccount)]

(In reply to Daniel Wilkins from comment #4)
> Wow, this patch still applies? I figured it was just stuck languishing for
> forever. It'd be easy enough to swap the defaults around, I just choose to
> have the ui reflect the behavior that was actually happening rather than the
> other way around; if there's actually any interest in merging the patch I'd
> be happy to orient it whichever way the dev wants.

It might be more tricky than it seems. I applied the patch directly (to xfce4-panel-4.12.0), it works. Then I played with it, and it can be reduced to only the following single change

- gtk_widget_show (plugin->label);
+ if (plugin->show_button_title)
+ gtk_widget_show (plugin->label);

The tricky part - for me - is that in the original source, in function "applications_menu_plugin_class_init", the "show-button-title" property is set to TRUE, yet in the end it is FALSE. So the "blind assumption" that the title (label) is on by default is perhaps not so blind. The real bug seems to be in the fact that the plugin->show_button_title is not "TRUE" even if it should be.

[Adam Purkrt (adam-purkrt-deactivatedaccount)]

Created attachment 6493
xfce4-panel-applicationsmenu-show_button_title.patch

In my opinion, the bug is just a forgotten initialization of plugin->show_button_title variable. After adding the initialization in (see the one-line patch), the "Show button title" checkbox is checked upon adding the "Applications Menu" to the panel, and the title is shown as well.

[Theo Linkspfeifer (lastonestanding)]

Fixed in version 4.12.1, and therefore not affecting 18.04 anymore.

https://git.xfce.org/xfce/xfce4-panel/tree/NEWS?h=xfce-4.12