force_config_drive cannot be set to False from nova.conf

[Dmitry Borodaenko]

force_config_drive is not cast to boolean, so the only way to disable this option is not to have it in nova.conf. If it is set to 'false' it is treated as a string and evaluates to true in configdrive.required_by()

[Gary Kotton (garyk)]

I am not sure that this is a bug. The default value is None. If this is set as None then it has the same functionality as False.
An alternative is that we check if this is "False" and then the method required_by will not invoke the config drive

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/94084

[Michael Still (mikal)]

Dims has an updated version of the fix at https://review.openstack.org/#/c/93842/3

[John Garbutt (johngarbutt)]

We use milestones only at the very end of the milestone to track bugs that should block the release of the milestone. Please use tags not milestones to track bugs, try things like: my_bug_topic_milestone_name

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/93842
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=de92d65f2981b826e145e82ab2734c19bf1dffa3
Submitter: Jenkins
Branch: master

commit de92d65f2981b826e145e82ab2734c19bf1dffa3
Author: Davanum Srinivas <email address hidden>
Date: Thu May 15 23:22:05 2014 -0400

    Test force_config_drive as a boolean as last resort

    The force_config_drive help clearly states that only possible option is
    'always' but folks are setting it to 'True'/'False' etc and expecting
    it to work. So let's enable that as well. In the worst case scenario
    mentioned in the bug, it was set to 'False' and since the check for
    force_config_drive took any string as true, we were enabling the flag
    to true. With the change in this review, we force a conversion of the
    string to true. Additional check for the flag to be set as 'always' is
    treated as true as well. The test case checks for all the variations

    Closes-Bug: #1319180
    DocImpact

    Change-Id: Ifa6348fa7dfd9de063eb13d30e3ddf94fa530b57