nautilus crashes in action_open_item_location_callback() call in nautilus-view.c when pressing Ctrl+Alt+O directy on the desktop
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
nautilus (Ubuntu) |
Fix Released
|
Low
|
Unassigned | ||
Trusty |
Fix Released
|
Low
|
Unassigned |
Bug Description
[ Description ]
null pointer dereference in Nautilus selection open callback.
[ QA ]
Open `Files'. Make sure nothing is selected. Hit ctrl+alt+O.
[ Development fix ]
The exact same patch has been uploaded to Utopic.
[ Regression potential ]
The patch is pending review upstream. I think it's unlikely to cause problems, but maybe it is expected that selection can be NULL.
[ Original description ]
This crash can be triggered immediately after logging in without any windows open or with all application windows hidden.
When you press Ctrl+Alt+O, nautilus intercepts this keybinding and crashes.
I've installed the debug packages and managed to identify the brakage in the action_
Full backtrace:
(gdb) backtrace
#0 0x000000000046766e in action_
action=
at nautilus-
#1 0x00007f3da91713b8 in g_closure_invoke (closure=0xc86fb0,
return_
invocation_
at /build/
#2 0x00007f3da9182d3d in signal_
detail=
emission_
instance_
at /build/
#3 0x00007f3da918aa29 in g_signal_
signal_
var_
at /build/
#4 0x00007f3da918ace2 in g_signal_emit (instance=
signal_
at /build/
#5 0x00007f3dab7519d0 in _gtk_action_
at /build/
#6 0x00007f3dab751f69 in closure_
return_
---Type <return> to continue, or q <return> to quit---
param_
marshal_
at /build/
#7 0x00007f3da91713b8 in g_closure_invoke (closure=0xc86e00,
return_
param_
at /build/
#8 0x00007f3da9182d3d in signal_
detail=
emission_
instance_
at /build/
#9 0x00007f3da918a6f9 in g_signal_
signal_
var_
at /build/
#10 0x00007f3da918ace2 in g_signal_emit (instance=
signal_
at /build/
#11 0x00007f3dab783d7d in gtk_accel_
accel_
acceleratab
accel_
---Type <return> to continue, or q <return> to quit---
at /build/
#12 0x00007f3dab7854ed in gtk_accel_
object=
at /build/
#13 0x00007f3dab9c0dc6 in gtk_window_
window=
at /build/
#14 0x00007f3dab9c0e51 in gtk_window_
event=0xe34100) at /build/
#15 0x0000000000479828 in nautilus_
event=0xe34100) at nautilus-
#16 0x00007f3dab877efe in _gtk_marshal_
return_
args=<optimized out>, marshal_
n_params=
at /build/
#17 0x00007f3da91715e7 in _g_closure_
return_
n_params=1, param_types=
at /build/
#18 0x00007f3da918a088 in g_signal_
signal_
var_
---Type <return> to continue, or q <return> to quit---
at /build/
#19 0x00007f3da918ace2 in g_signal_emit (instance=
signal_
at /build/
#20 0x00007f3dab9a0df4 in gtk_widget_
event=0xe34100) at /build/
#21 0x00007f3dab87636f in propagate_event (widget=0xa50320, event=0xe34100,
captured=
at /build/
#22 0x00007f3dab877ada in gtk_main_do_event (event=0xe34100)
at /build/
#23 0x00007f3dab47bc22 in gdk_event_
callback=
at /build/
#24 0x00007f3da8ea1e04 in g_main_dispatch (context=0x8a0c90)
at /build/
#25 g_main_
at /build/
#26 0x00007f3da8ea2048 in g_main_
context=
dispatch=
at /build/
#27 0x00007f3da8ea20ec in g_main_
---Type <return> to continue, or q <return> to quit---
context@
at /build/
#28 0x00007f3da945467c in g_application_run (application=
argc=
at /build/
#29 0x000000000042b561 in main (argc=2, argv=0x7ffff686
at nautilus-main.c:104
ProblemType: Bug
DistroRelease: Ubuntu 14.04
Package: nautilus 1:3.10.1-0ubuntu9
ProcVersionSign
Uname: Linux 3.13.0-24-generic x86_64
ApportVersion: 2.14.1-0ubuntu3
Architecture: amd64
CurrentDesktop: Unity
Date: Mon May 12 15:39:38 2014
EcryptfsInUse: Yes
GsettingsChanges:
InstallationDate: Installed on 2013-11-21 (172 days ago)
InstallationMedia: Ubuntu 13.10 "Saucy Salamander" - Release amd64 (20131016.1)
SourcePackage: nautilus
UpgradeStatus: Upgraded to trusty on 2014-04-20 (21 days ago)
Changed in nautilus (Ubuntu Trusty): | |
importance: | Undecided → Low |
When called on the empty desktop, the nautilus_ view_get_ selection (view) function results in a NULL result. At that point, there is no further need to continue the function execution and it is safe to exit as no resources need to be released.
This patch checks for selection being NULL and returns preventing nautilus from crashing.
Please comment on this and if appropriate merge the patch in the nautilus package.