Hyper-v fails to attach volumes when using v1 volume utilites

[Lucian Petrut]

The following patch https://github.com/openstack/nova/commit/4c2f36bfe006cb0ef89ca7a706223f30488a182e#diff-5c6ee11140977e63b54542e2ff5763d3R22 caused a regression by changing the eventlet.subprocess.Popen with the builtin subprocess.Popen (by using the nova.utils execute method) without changing the way the args were parsed.

In this module, the execution args were parsed separated by whitespaces, which is not allowed by the builtin subprocess.Popen, causing a "not found" error. This error is returned for example when attaching a volume, at the point where iscsicli tool is used to login the iSCSI target or portal.

Trace:
http://paste.openstack.org/show/79418/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/93351

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/92635
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=40a790c32ee4ea7b9d79e259545f07409fd618fa
Submitter: Jenkins
Branch: master

commit 40a790c32ee4ea7b9d79e259545f07409fd618fa
Author: Lucian Petrut <email address hidden>
Date: Wed May 7 19:43:27 2014 +0300

    Fixes arguments parsing when executing command

    A regression was caused by changing the eventlet.subprocess.Popen
    with the builtin subprocess.Popen (by using the nova.utils execute
    method) without changing the way the arguments were parsed.

    In the v1 volume utilities module, the execution args were parsed
    separated by whitespaces, which is not allowed by the builtin
    subprocess.Popen, causing a "not found" error.

    This error is returned for example when attaching a volume, at the
    point where iscsicli tool is used to login the iSCSI target or portal.

    This patch fixes the issue by simply splitting the args.

    Closes-bug: #1317180

    Change-Id: Iee7d5de0dde8b68d8f2bab4214e9b6779ad9f722

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/93351
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f769bf8d843ca6d3530e92e2ab93c66b1a0cc8c1
Submitter: Jenkins
Branch: stable/icehouse

commit f769bf8d843ca6d3530e92e2ab93c66b1a0cc8c1
Author: Lucian Petrut <email address hidden>
Date: Wed May 7 19:43:27 2014 +0300

    Fixes arguments parsing when executing command

    A regression was caused by changing the eventlet.subprocess.Popen
    with the builtin subprocess.Popen (by using the nova.utils execute
    method) without changing the way the arguments were parsed.

    In the v1 volume utilities module, the execution args were parsed
    separated by whitespaces, which is not allowed by the builtin
    subprocess.Popen, causing a "not found" error.

    This error is returned for example when attaching a volume, at the
    point where iscsicli tool is used to login the iSCSI target or portal.

    This patch fixes the issue by simply splitting the args.

    Closes-bug: #1317180

    Change-Id: Iee7d5de0dde8b68d8f2bab4214e9b6779ad9f722
    (cherry picked from commit 40a790c32ee4ea7b9d79e259545f07409fd618fa)