git-doc: example source snippet is empty in technical/api-hashmap.html

[Jonathan Nieder]

Anders Kaseorg reports[1]:

I noticed this warning while building git-doc:

    ASCIIDOC technical/api-hashmap.html
/bin/sh: 1: source-highlight: not found
asciidoc: WARNING: api-hashmap.txt: line 218: filter non-zero exit code: source-highlight -f xhtml -s c: returned 127
asciidoc: WARNING: api-hashmap.txt: line 218: no output from filter: source-highlight -f xhtml -s c

(Actually, I noticed it because it’s fatal on very old Ubuntu releases,
but never mind that.) The effect is that the example source snippet under
‘Usage example’ in /usr/share/doc/git-doc/technical/api-hashmap.html shows
up as empty. That snippet was added in v2.0.0-rc0~166^2~16.

This can be resolved by adding source-highlight as a build dependency.

[1] http://bugs.debian.org/745591

This was fixed in Debian, but Ubuntu trusty reverted the fix:

 git (1:2.0.0~rc0-2ubuntu1) utopic; urgency=medium

   * debian/control: Drop source-highlight build dependency.

Unfortunately that changelog entry doesn't say why the fix was reverted.

[Anders Kaseorg (andersk)]

Owww, I’m guessing it’s because Ubuntu doesn’t want a package in main (git) build-depending on a package in universe (source-highlight).

Options include
• filing a main inclusion report for source-highlight (https://wiki.ubuntu.com/UbuntuMainInclusionRequirements);
• patching the [source] tags out of Documentation/technical/api-hashmap.txt;
• getting upstream to take that patch, which it probably should, given this failure mode;
• or just living with Ubuntu-forked packaging, and watching the Ubuntu version fall farther and farther behind (please please please not again).

Thinking out loud, this is not the first time I wish Debian had Build-Recommends.

[Launchpad Janitor (janitor)]

This bug was fixed in the package git - 1:2.0.0~rc4-1

---------------
git (1:2.0.0~rc4-1) unstable; urgency=low

  * new upstream release candidate.
  * remove source-highlight build dependency since the markup
    requiring it was removed upstream (thx Anders Kaserog;
    LP: #1316810).
  * remove git-bzr package to make room for a package built from
    https://github.com/felipec/git-remote-bzr.
    * debian/control: remove references to git-bzr package.
    * debian/control: remove Build-Depends: bzr, python-bzrlib.
    * debian/rules: remove rules to build, install, and clean
      git-remote-bzr.
    * debian/git-doc.docs: do not install git-remote-bzr.html.
    * debian/git-remote-bzr.txt, debian/git-bzr.postinst,
      debian/git-bzr.prerm, debian/git-bzr.README.Debian: remove.

 -- Jonathan Nieder <email address hidden> Wed, 21 May 2014 11:34:56 -0700