qtcreator-plugin-ubuntu

Do not run click reviewer when its not installed

Bug #1316787 reported by Pat McGowan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qtcreator-plugin-ubuntu
Fix Released
High
Benjamin Zeller
qtcreator-plugin-ubuntu (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

If the click-reviewer-tools package is not installed, the validation are is not displayed on the Publish tab, which is correct. However the create package action still appears to try to run the tool. A popup is displayed for it and the progress never changes.

Ideally we would just change the package from suggest to depends and have it installed if possible. If its an issue with the release version, then make it a depends in the trusty version but not older versions.

Related branches

lp:~zeller-benjamin/qtcreator-plugin-ubuntu/devicepage
Zoltan Balogh: Approve
PS Jenkins bot: Approve (continuous-integration)
Diff: 3275 lines (+2562/-68)
34 files modified
manifest.json (+15/-0)
share/qtcreator/ubuntu/devicespage/DeviceAdvancedTab.qml (+92/-0)
share/qtcreator/ubuntu/devicespage/DeviceBuilderTab.qml (+42/-0)
share/qtcreator/ubuntu/devicespage/DeviceLogTab.qml (+12/-0)
share/qtcreator/ubuntu/devicespage/DevicePage.qml (+105/-0)
share/qtcreator/ubuntu/devicespage/DeviceStatusTab.qml (+108/-0)
share/qtcreator/ubuntu/devicespage/EmulatorPage.qml (+150/-0)
share/qtcreator/ubuntu/devicespage/FeatureStateItem.qml (+46/-0)
share/qtcreator/ubuntu/devicespage/LogPage.qml (+24/-0)
share/qtcreator/ubuntu/devicespage/NewEmulatorDialog.qml (+46/-0)
share/qtcreator/ubuntu/devicespage/devicespage.qmlproject (+20/-0)
share/qtcreator/ubuntu/devicespage/dummydata/devicesModel.qml (+52/-0)
share/qtcreator/ubuntu/devicespage/main.qml (+25/-0)
share/qtcreator/ubuntu/devicespage/test.qml# (+18/-0)
share/qtcreator/ubuntu/scripts/local_start_emulator (+0/-1)
src/ubuntu/resources.qrc (+2/-0)
src/ubuntu/ubuntu.pro (+27/-5)
src/ubuntu/ubuntuconstants.h (+4/-2)
src/ubuntu/ubuntudevice.cpp (+125/-20)
src/ubuntu/ubuntudevice.h (+9/-4)
src/ubuntu/ubuntudevicemode.cpp (+91/-9)
src/ubuntu/ubuntudevicemode.h (+42/-2)
src/ubuntu/ubuntudevicesmodel.cpp (+734/-0)
src/ubuntu/ubuntudevicesmodel.h (+169/-0)
src/ubuntu/ubuntuemulatormodel.cpp (+408/-0)
src/ubuntu/ubuntuemulatormodel.h (+102/-0)
src/ubuntu/ubuntukitmanager.cpp (+50/-1)
src/ubuntu/ubuntukitmanager.h (+3/-0)
src/ubuntu/ubuntumenu.cpp (+9/-4)
src/ubuntu/ubuntuplugin.cpp (+4/-1)
src/ubuntu/ubuntuprocess.cpp (+5/-6)
src/ubuntu/ubuntuprocess.h (+3/-2)
src/ubuntu/ubunturemoterunconfiguration.cpp (+20/-10)
src/ubuntu/ubuntusettingsdeviceconnectivitywidget.cpp (+0/-1)
lp:ubuntu/utopic-proposed/qtcreator-plugin-ubuntu
Zoltan Balogh (bzoltan)
Changed in qtcreator-plugin-ubuntu:
status: New → Confirmed
Zoltan Balogh (bzoltan)
Changed in qtcreator-plugin-ubuntu:
status: Confirmed → Fix Committed
Zoltan Balogh (bzoltan)
Changed in qtcreator-plugin-ubuntu:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtcreator-plugin-ubuntu - 3.0.1+14.10.20140507-0ubuntu1

---------------
qtcreator-plugin-ubuntu (3.0.1+14.10.20140507-0ubuntu1) utopic; urgency=low

  [ Benjamin Zeller ]
  * Implement metacall in menu.json, makes it possible to call
    slots/signals/invokables. Restore the install package menu item for
    cmake projects (LP: #1316783). Check if reviewer tools are installed
    before running them (LP: #1316787) . (LP: #1316787, #1316783)
 -- Ubuntu daily release <email address hidden> Wed, 07 May 2014 11:02:32 +0000

Changed in qtcreator-plugin-ubuntu (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.