upstart works as expected, notify-dbus-address tests fail depending on system-wide session jobs

[Dimitri John Ledkov]

not ok 204 - ensure Session Init connects to D-Bus session bus when notified
 wrong string value, expected 'init (upstart [0-9.][0-9.]*' got 'initctl: Name "com.ubuntu.Upstart" does not exist'
 at tests/test_initctl.c:17285 (test_dbus_connection).
/bin/bash: line 5: 6113 Aborted ${dir}$tst
FAIL: test_initctl

I've seen this failure on amd64, arm64 and powerpc. Retries did eventually pass the test-suite on amd64 & powerpc. However arm64 still fails on the official distro builders.

[Dimitri John Ledkov (xnox)]

After starting upstart i've asserted that no jobs are running, however there there a few of them running, including user session dbus job that did notify upstart of its dbus address. Later in the test when we tried to notify our test upstart with test dbus address, test upstart would not connect to test dbus since it only accept dbus connections once and was already running on the other dbus.

This is racy & dependant on the jobs configured in /usr/share/upstart/session/

I've resolved this using "--no-startup-event" option. But it is inherently racy, as potentially all user-session test upstart spawns are affected. Thus something generic should be implemented in the test_common_utilities, such that when test-upstart in user session mode is spawned global jobs are not executed.

[Launchpad Janitor (janitor)]

This bug was fixed in the package upstart - 1.12.1-0ubuntu6

---------------
upstart (1.12.1-0ubuntu6) utopic; urgency=medium

  * Map force-reload to restart command in init-functions hook.
  * Use variable expansion, instead of basename as that is shipped in
    /usr.
  * Resolve test-failure, when dbus user session job is launched
    accidentally by unit-tests. (LP: #1315767)
 -- Dimitri John Ledkov <email address hidden> Wed, 07 May 2014 20:15:35 +0100