TIME field not restored with the correct value (5.5)

[Frederic Descamps]

When a TIME field is extracted by constraints_parser, the dumped value is not correct.

For example instead of "09:00:00", "01:00:00" is returned and for "09:10:00", "01:16:40" is returned.

This happen when field->time_precision = 0, field->fixed_length = 3 and process_56 = 0

The field definition is:

type: FT_TIME,
fixed_length: 3,

time_precision: 0,
can_be_null: TRUE

[Frederic Descamps (lefred)]

I tried to reproduce this on a very simple table:

+----+----------+
| id | gne |
+----+----------+
| 1 | 10:01:20 |
| 2 | 00:02:29 |
| 3 | 10:09:00 |
| 4 | 10:09:00 |
| 5 | 01:00:00 |
| 6 | 09:00:00 |
+----+----------+

Then after doing the full process, the dump file is:

-- Page id: 3, Format: COMPACT, Records list: Valid, Expected records: (6 6)
000000001B03 83000001350110 fred 1 "03:48:40"
000000001B05 85000001B00110 fred 2 "00:03:49"
000000001B0A 87000001770110 fred 3 "04:01:40"
000000001B0B 88000001E60110 fred 4 "04:01:40"
000000001B0D 8A000001750110 fred 5 "02:46:40"
000000001B0E 8B000001780110 fred 6 "01:00:00"
-- Page id: 3, Found records: 6, Lost records: NO, Leaf page: YES

and dates are incorrect.

After applying the patch and running constraints_parser again, the dump file is correct:

-- Page id: 3, Format: COMPACT, Records list: Valid, Expected records: (6 6)
000000001B03 83000001350110 fred 1 "10:01:20"
000000001B05 85000001B00110 fred 2 "00:02:29"
000000001B0A 87000001770110 fred 3 "10:09:00"
000000001B0B 88000001E60110 fred 4 "10:09:00"
000000001B0D 8A000001750110 fred 5 "01:00:00"
000000001B0E 8B000001780110 fred 6 "09:00:00"
-- Page id: 3, Found records: 6, Lost records: NO, Leaf page: YES

[Ovais Tariq (ovais-tariq)]

Does this only affect the TIME data type in 5.5, or does it affect other temporal data types as well? Does it also affect 5.6?

[Frederic Descamps (lefred)]

I found the issue only with time and only in 5.5. 5.6 parsing is done in a
different part of the function

On Fri, May 9, 2014 at 7:38 PM, Ovais Tariq <email address hidden>wrote:

> Does this only affect the TIME data type in 5.5, or does it affect other
> temporal data types as well? Does it also affect 5.6?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1312446
>
> Title:
> TIME field not restored with the correct value (5.5)
>
> Status in Percona Data Recovery Tool for InnoDB:
> New
>
> Bug description:
> When a TIME field is extracted by constraints_parser, the dumped value
> is not correct.
>
> For example instead of "09:00:00", "01:00:00" is returned and for
> "09:10:00", "01:16:40" is returned.
>
>
> This happen when field->time_precision = 0, field->fixed_length = 3 and
> process_56 = 0
>
> The field definition is:
>
>
> type: FT_TIME,
> fixed_length: 3,
>
> time_precision: 0,
> can_be_null: TRUE
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/percona-data-recovery-tool-for-innodb/+bug/1312446/+subscriptions
>