Should depend on samba or NFS

[Murray Cumming]

I have the new GNOME System Tools "Shared Folders" control panel installed, but
when I use it, it warns me that I don't have Samba or NFS installed. Surely it
shouldn't be possible to install a broken "Shared Folders".

[Sebastien Bacher (seb128)]

the package Suggests samba-common but we could probably use the same change as
for the ntp feature and ask to install the package in the dialog

[Guillaume Desmottes (cassidy)]

Created an attachment (id=1788)
patch to easily install share services

I have made a patch to do it.
It asks which package must be installed (samba and/or nfs) and call synaptic.

The patch must be apply on the debian patched sources.

It modify 03_install_smb.dpatch to be able to install more than one package
with synaptic. (i think this patch is badly named, it has nothing to do with
smb. This should be install_packages or something like that).

It also modify the 04_install_ntp.dpatch to be correct with the previous
modification.

I haven't modify po files with the new strings (from shares.glade.in).

[Sebastien Bacher (seb128)]

thanks for the patch. This kind of change is blocked by the freeze for hoary so
I've not looked on it yet. I'll do that soon.

[Nicolas da Luz Duque (hot-boy)]

(In reply to comment #3)
> thanks for the patch. This kind of change is blocked by the freeze for hoary so
> I've not looked on it yet. I'll do that soon.

Is this patch going to be integrated to Breezy? I think it is a very good idea:
I had installed nfs-common, but I didn't know I had to install nfs-user-server,
too. This patch would have spared me the delay of searching the web to find that.

It would be a lot more user-friendly if this feature was included in ubuntu main.

[Sebastien Bacher (seb128)]

*** Bug 18644 has been marked as a duplicate of this bug. ***

[Guillaume Desmottes (cassidy)]

Any news about the integration of my patch?

[Sebastien Bacher (seb128)]

same issue as #3991

This bug has been marked as a duplicate of bug 10553.

[Sebastien Bacher (seb128)]

wrong bug

[Sebastien Bacher (seb128)]

I've used the patch for the current upload. Why have you changed the function to
not use a description of the package? Maybe the patch could be updated for this.

 gnome-system-tools (1.3.0.1-0ubuntu1) breezy; urgency=low
 .
   * New upstream version:
     General
     - Fixed some typos.
     - Center password dialog on main dialog.
     Services
     - Brand new UI, with lots of goodies.
     Network
     - Fix behavior of ESC key in combination of cellrenderer
       editing + dialog cancelling.
     - Improved IP filtering.
     - Added option for using the peer DNS in dialup connection.
     - Removed duplicated accelerators.
     - Added option for WEP key type.
     - Allow IPv6 DNS.
     - Improved some strings.
     Time
     - Improved focus chain.
     - Improved some strings and typos.
     Boot
     - Improved some strings and typos.
     Disks
     - Improved some strings.
     Shares
     - Improved some strings.
     - Really check that all necessary fields are filled before adding a share.
     Users
     - Plugged some leaks.
     - Remove unnecessary commas when showing users' data.
     - Improved some strings and typos.
   * debian/control.in:
     - updated the Build-Depends.
   * 03_install_smb.dpatch:
     - renamed to 03_install_packages, updated to install different packages,
       thanks to Guillaume Desmottes <email address hidden> for the patch.
   * debian/patches/04_install_ntp.dpatch:
     - updated.
   * debian/patches/05_translations.dpatch:
     - updated.
   * debian/patches/06_install_smbnfs.dpatch:
     - dialog to install smb or nfs when using shares-admin,
     - patch from Guillaume Desmottes <email address hidden> (Ubuntu: #6743).
   * debian/patches/10_relibtoolize.dpatch:
     - updated.
   * debian/patches/19_fix_initial_ppp.dpatch:
     - fixed with the new version.
   * debian/patches/20_add_peerdns.dpatch:
     - fixed with the new version.
   * debian/watch:
     - updated.

[Guillaume Desmottes (cassidy)]

(In reply to comment #9)
> I've used the patch for the current upload. Why have you changed the function to
> not use a description of the package? Maybe the patch could be updated for this.
>

Because description doesn't seem useful to me and complicate the patch.

Strings from shares.glade.in must be added to po files to be translated but i
don't know the proper way to do that.

[Sebastien Bacher (seb128)]

Thanks for the comment, the strings are already listed to translate. The .pot
file is updated during the build and given to rosetta
(https://launchpad.ubuntu.com/rosetta) which is used to translate the distribution

[Sebastien Bacher (seb128)]

*** Bug 21124 has been marked as a duplicate of this bug. ***