Wrong icon path in desktop file

[Marius Gedminas]

[Impact]

 * The icon of gtimelog is replaced with the default ("unknown") one (in the dash & launcher).

[Test Case]

 * Launch gtimelog.

 * Look at the launcher icon.

[Regression Potential]

 * This is a backport of change already present in Debian & Xenial.

[Other Info]

 * Original bug description

gtimelog 0.9.1 in trusty ships a /usr/share/applications/gtimelog.desktop that says

    Icon=/usr/share/pyshared/gtimelog/gtimelog.png

however /usr/share/pyshared/gtimelog/gtimelog.png does not exist!

dpkg -L gtimelog shows that there are two copies of gtimelog.png elsewhere:

    /usr/share/pixmaps/gtimelog.png
    /usr/lib/python3/dist-packages/gtimelog/gtimelog.png

[Marius Gedminas (mgedmin)]

I uploaded a fix to the PPA, now waiting for it to build.

[Marius Gedminas (mgedmin)]

This ought to be fixed in gtimelog - 0.9.1-2ppa0 in https://launchpad.net/~gtimelog-dev/+archive/ppa/+packages.

[Eugene Morozov (emorozov)]

I've just installed Ubuntu 14.10 and there's still wrong path in the desktop file.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Nobuto Murata (nobuto)]

On my vivid desktop, "Icon=gtimelog" without full path just works for me. debian/patches/fix-icon-path can be dropped, IMHO.

[Louis Bouchard (louis)]

Just opened a debian bug with a proposed fix : https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=807047

This should sync back to Xenial

[Barry Warsaw (barry)]

I just uploaded 0.10.0-1 to Debian with the fix. Should sync to Ubuntu and close this bug soon.

[Dariusz Gadomski (dgadomski)]

SRU proposal for Trusty

[Dariusz Gadomski (dgadomski)]

SRU proposal for Wily

[Louis Bouchard (louis)]

dgadomski: there's a few problems with your debdiff :
1) you need to run update-maintainer since you're turning a debian package into an ubuntu-specific one
2) you removed a patch that quilt already applied so the source is still modified. You need to run quilt pop -a before you remove the patch & run debuild -S otherwise the source file appears as already modified

[Brian Murray (brian-murray)]

Hello Marius, or anyone else affected,

Accepted gtimelog into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gtimelog/0.9.1-2ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Chris Hermansen (c-hermansen)]

Brian, will this also make it to Wily?

Regards, Chris Hermansen
On Feb 18, 2016 15:41, "Brian Murray" <email address hidden> wrote:

> Hello Marius, or anyone else affected,
>
> Accepted gtimelog into trusty-proposed. The package will build now and
> be available at
> https://launchpad.net/ubuntu/+source/gtimelog/0.9.1-2ubuntu1 in a few
> hours, and then in the -proposed repository.
>
> Please help us by testing this new package. See
> https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
> enable and use -proposed. Your feedback will aid us getting this update
> out to other Ubuntu users.
>
> If this package fixes the bug for you, please add a comment to this bug,
> mentioning the version of the package you tested, and change the tag
> from verification-needed to verification-done. If it does not fix the
> bug for you, please add a comment stating that, and change the tag to
> verification-failed. In either case, details of your testing will help
> us make a better decision.
>
> Further information regarding the verification process can be found at
> https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in
> advance!
>
> ** Changed in: gtimelog (Ubuntu Trusty)
> Status: New => Fix Committed
>
> ** Tags added: verification-needed
>
> --
> You received this bug notification because you are subscribed to a
> duplicate bug report (1514254).
> https://bugs.launchpad.net/bugs/1309428
>
> Title:
> Wrong icon path in desktop file
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu/+source/gtimelog/+bug/1309428/+subscriptions
>

[Louis Bouchard (louis)]

Chris,
Yes I will upload the Wily bits shortly. I thought that I had to wait for the Trusty SRU to go through to upload the Wily one.

[Brian Murray (brian-murray)]

Hello Marius, or anyone else affected,

Accepted gtimelog into wily-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gtimelog/0.9.2-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Ubuntu Foundations Team Bug Bot (crichton)]

The fix for this bug has been awaiting testing feedback in the -proposed repository for wily for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

[Steve Langasek (vorlon)]

The version of gtimelog in the proposed pocket of Trusty that was purported to fix this bug report has been removed because the bugs that were to be fixed by the upload were not verified in a timely (105 days) fashion.

[Steve Langasek (vorlon)]

The version of gtimelog in the proposed pocket of Wily that was purported to fix this bug report has been removed because the bugs that were to be fixed by the upload were not verified in a timely (105 days) fashion.