Smart scope requests should support session id
Bug #1308585 reported by
Paweł Stołowski
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| unity-scopes-shell |
Fix Released
|
High
|
Paweł Stołowski | ||
| unity-scopes-api (Ubuntu) |
Fix Released
|
High
|
Paweł Stołowski | ||
| Utopic |
Won't Fix
|
Undecided
|
Unassigned | ||
| unity-scopes-shell (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Smart scopes bridge should support real session id for SSS requests. Currently search requests send by smart scopes client use a dummy hardcoded "session_
Related branches
lp:~stolowski/unity-scopes-api/session-id
- PS Jenkins bot (community): Approve (continuous-integration)
- Marcus Tomlinson (community): Approve
-
Diff: 461 lines (+185/-67)11 files modifieddebian/libunity-scopes3.symbols (+6/-1)
include/unity/scopes/ActionMetadata.h (+45/-0)
include/unity/scopes/internal/QueryMetadataImpl.h (+7/-0)
include/unity/scopes/internal/SearchMetadataImpl.h (+0/-7)
include/unity/scopes/internal/smartscopes/SmartScopesClient.h (+1/-1)
src/scopes/ActionMetadata.cpp (+27/-0)
src/scopes/internal/QueryMetadataImpl.cpp (+53/-0)
src/scopes/internal/SearchMetadataImpl.cpp (+0/-51)
src/scopes/internal/smartscopes/SmartScope.cpp (+37/-4)
src/scopes/internal/smartscopes/SmartScopesClient.cpp (+3/-3)
test/gtest/scopes/QueryMetadata/QueryMetadata_test.cpp (+6/-0)
lp:~stolowski/unity-scopes-shell/session-id
- Marcus Tomlinson (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 422 lines (+223/-4)9 files modifiedsrc/Unity/previewstack.cpp (+6/-1)
src/Unity/previewstack.h (+3/-1)
src/Unity/scope.cpp (+30/-1)
src/Unity/scope.h (+6/-0)
src/Unity/utils.cpp (+10/-0)
src/Unity/utils.h (+2/-0)
tests/data/mock-scope/mock-scope.cpp (+4/-1)
tests/previewtest.cpp (+1/-0)
tests/resultstest.cpp (+161/-0)
| tags: | added: s-s-scopes |
Revision history for this message
| Facundo Batista (facundo) wrote | #1 |
| tags: | added: rtm14 |
| Changed in unity-scopes-shell: | |
| status: | New → Confirmed |
| Changed in unity-scopes-api: | |
| assignee: | nobody → Pawel Stolowski (stolowski) |
| Changed in unity-scopes-shell: | |
| assignee: | nobody → Pawel Stolowski (stolowski) |
| Changed in unity-scopes-api: | |
| importance: | Undecided → High |
| Changed in unity-scopes-shell: | |
| importance: | Undecided → High |
| tags: | added: touch-2014-09-11 |
| Changed in unity-scopes-api: | |
| status: | Confirmed → In Progress |
| Changed in unity-scopes-shell: | |
| status: | Confirmed → In Progress |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #2 |
| Changed in unity-scopes-api: | |
| status: | In Progress → Fix Committed |
| affects: | unity-scopes-api → unity-scopes-api (Ubuntu) |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in unity-scopes-api (Ubuntu): | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #4 |
| Changed in unity-scopes-shell (Ubuntu): | |
| status: | New → Fix Released |
| Changed in unity-scopes-shell: | |
| status: | In Progress → Fix Committed |
| Changed in unity-scopes-shell: | |
| status: | Fix Committed → Fix Released |
| Changed in unity-scopes-api (Ubuntu Utopic): | |
| status: | New → Won't Fix |
To post a comment you must log in.
The session id should be an unique id (an UUID or something) that is the same for all operations that the user does in the same session (several searches, a preview, etc).