Problems saving view layout - no option selected by default
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Robert Lyon | ||
1.9 |
Fix Released
|
High
|
Robert Lyon |
Bug Description
When I make a new page and click on the layout tab and then click save the system throws errors. This is due to no layout option being selected by default.
If I selected 'advanced' or 'basic' sections then the 3 column layout get selected - but this is done in a less than optimal way as the value for the layout is hardcoded in the js so it is expecting that the layout option for the 3 column layout will have the id = 5, but this might not always be the case. We really need to find the default layout with php and pass the id to the js.
Also in th js code there are js variables like $selected, which are written like they want to get the value from php.
It would be better for the variables:
- set by js to be written as 'var myvar ='
- set by jquery/mochikit to be written as '$()' or '$j()' (where appropriate)
- and have the php only be used on the right hand side of the sentance eg have 'var myvar = $phpvar'
Changed in mahara: | |
assignee: | nobody → Robert Lyon (robertl-9) |
status: | Confirmed → In Progress |
Changed in mahara: | |
milestone: | 1.9.1 → 1.10.0 |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Patch for "master" branch: https:/ /reviews. mahara. org/3263