ADLSearch can no longer show different files with the same name

[Crise / MW]

If user has more than one file with the same name, in different directories so virtual names do not come into play, (but different TTH) shared ADLSearch can no longer show matches for both files.

See the attached test case, where ADL search for .txt only displays File1.txt and FileC.txt when it should display all three files.

[poy (poy)]

has this changed (relatively) recently or was it always like that?

[Crise / MW (markuwil)]

To my knowledge it was changed to behave like this with the recent share changes (ie. when virtual names became a thing, or the changes following that to filelist handling).

[Fredrik Ullner (ullner)]

This patch will solve the issue with at least files. I couldn't get a similar mechanism to work for directories (basically also changing the compare function) so that is still broken. Perhaps someone else can take a look at it?

I didn't notice any performance difference compared to before but people are welcome to try on large lists...

By the way, the alternative to fixing the comparer is to do as the ShareManager does; adding numbers to the file, but I'm not sure if that's something people might want. (I.e. "myfile (1).txt", "myfile (2).txt" etc.)

[maksis (maksis)]

See https://github.com/airdcpp/airgit/blob/master/windows/DirectoryListingFrm.cpp#L1792