Rename master/headphone volume to gain.

[Daniel Schürmann]

Since [Master],volume is a multiplier to the samples, it behaves like a bit crusher.

The name implies, that is is a volume control of the master output. Instead it is an output gain.

If people using it for lets say play background music during a dinner, it is actually a bitcrusher.

Related post:
http://music.columbia.edu/pipermail/portaudio/2011-January/011366.html

[Daniel Schürmann (daschuer)]

Bug #1280771 issues the input mixer

[RJ Skerry-Ryan (rryan)]

So should we deprecate the volume control, rename it to "gain" and alias "volume" to it for backwards compatibility?

Your bug title suggests we should remove master gain -- sure people should ideally not reduce the fidelity of their music before it gets converted to analog (unless it's clipping) but the live broadcasting and recording crowd at least need a handy gain knob. And many DJs will want it for the convenience even though it is less ideal than doing it with the club mixer.

[Daniel Schürmann (daschuer)]

Rename it to [Master]gain would be technically correct and a good idea.

Anny Idea about the effort to control the sound cards volume?

[RJ Skerry-Ryan (rryan)]

Renaming to "gain" and aliasing to "volume" sounds good -- I think we should leave soundcard settings alone though.

[RJ Skerry-Ryan (rryan)]

https://github.com/mixxxdj/mixxx/commit/23823f529f728164e17fa977c23f3b8d24fce9dc

Updated skins, tooltips, control picker.

[Be (be.ing)]

I noticed that the control objects [Master],volume and [Master],headVolume have not been renamed. Should they be renamed and the old names deprecated and aliased to new names?

[Daniel Schürmann (daschuer)]

Thats already done, in Mixxx:
https://github.com/mixxxdj/mixxx/blob/da0f31cd220c3ad878367a5abe14044812afeb44/src/engine/enginemaster.cpp#L108

Where did you find it? Maybe we should mark them as deprecated there.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7413