Canned queries need to be supported via "scope://" uri schema
Bug #1305147 reported by
Paweł Stołowski
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| unity-scopes-api |
Fix Released
|
High
|
Paweł Stołowski | ||
| unity-scopes-shell |
Fix Released
|
Medium
|
Michal Hruby | ||
| unity-scopes-shell (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
We need to handle parsing of canned queries in the form of "scope:
CannedQuery class in the scopes API needs to support conversion to/from such uri, and Shell needs to understand them as well and use CannedQuery class to deserialize and call search for correct scope.
Related branches
lp:~stolowski/unity-scopes-api/canned-queries-to-uri
- Michi Henning (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Facundo Batista (community): Approve
-
Diff: 589 lines (+340/-27)14 files modifiedCMakeLists.txt (+1/-1)
RELEASE_NOTES.txt (+5/-0)
debian/changelog (+6/-0)
debian/libunity-scopes1.symbols (+2/-2)
demo/client.cpp (+1/-1)
demo/scopes/scope-C/scope-C.cpp (+1/-1)
include/unity/scopes/CannedQuery.h (+2/-2)
include/unity/scopes/internal/CannedQueryImpl.h (+5/-2)
include/unity/scopes/internal/Utils.h (+2/-0)
src/scopes/CannedQuery.cpp (+4/-4)
src/scopes/internal/CannedQueryImpl.cpp (+94/-8)
src/scopes/internal/OptionSelectorFilterImpl.cpp (+3/-0)
src/scopes/internal/Utils.cpp (+61/-0)
test/gtest/scopes/CannedQuery/CannedQuery_test.cpp (+153/-6)
lp:~mhr3/unity-scopes-shell/fix-1305147
- Pete Woods (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 193 lines (+68/-36)5 files modifiedsrc/Unity/scope.cpp (+40/-33)
src/Unity/scope.h (+1/-1)
tests/data/mock-scope/mock-scope.cpp (+9/-0)
tests/resultstest-ng.cpp (+17/-1)
tests/utilstest-ng.cpp (+1/-1)
| summary: |
- Canned queries need to be support via "scope://" uri schema + Canned queries need to be supported via "scope://" uri schema |
| Changed in unity-scopes-api: | |
| assignee: | nobody → Pawel Stolowski (stolowski) |
| importance: | Undecided → High |
| status: | New → In Progress |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #2 |
| Changed in unity-scopes-api: | |
| status: | In Progress → Fix Committed |
| Changed in unity-scopes-shell: | |
| status: | New → In Progress |
| importance: | Undecided → Medium |
| assignee: | nobody → Michal Hruby (mhr3) |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in unity-scopes-shell (Ubuntu): | |
| status: | New → Fix Released |
| Changed in unity-scopes-shell: | |
| status: | In Progress → Fix Released |
| Changed in unity-scopes-api: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This way, the server could return an 'action' widget with an URI like "scope:
Thanks!