aolserver4-nspostgres FTBFS on trusty-proposed

[Sebastian Carneiro]

FTBFS on trusty-proposed with tcl8.5. Log snippet:

CFLAGS="-Wall -g -Wl,--no-as-needed -O2" /usr/bin/make -f debian/Makefile.debian POSTGRES=PG_CONFIG PG_CONFIG=/usr/bin/pg_config ACS=1
make[1]: Entering directory `/build/buildd/aolserver4-nspostgres-4.5+20110709'
i686-linux-gnu-gcc -Wall -g -Wl,--no-as-needed -O2 -DBIND_EMULATION -I/usr/include/postgresql -DFOR_ACS_USE -O2 -Wall -fPIC -g -O2 -fno-unit-at-a-time -pipe -D_FORTIFY_SOURCE=2 -I/usr/include/aolserver4 -I/usr/include/tcl8.5 -DNO_CONST -DPACKAGE_NAME=\"tcl\" -DPACKAGE_TARNAME=\"tcl\" -DPACKAGE_VERSION=\"8.5\" -DPACKAGE_STRING=\"tcl\ 8.5\" -DPACKAGE_BUGREPORT=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_LIMITS_H=1 -DHAVE_SYS_PARAM_H=1 -DUSE_THREAD_ALLOC=1 -D_REENTRANT=1 -D_THREAD_SAFE=1 -DHAVE_PTHREAD_ATTR_SETSTACKSIZE=1 -DHAVE_PTHREAD_GETATTR_NP=1 -DGETATTRNP_NOT_DECLARED=1 -DTCL_THREADS=1 -DTCL_CFGVAL_ENCODING=\"iso8859-1\" -DMODULE_SCOPE=extern\ __attribute__\(\(__visibility__\(\"hidden\"\)\)\) -DTCL_SHLIB_EXT=\".so\" -DTCL_CFG_OPTIMIZED=1 -DTCL_CFG_DEBUG=1 -DTCL_TOMMATH=1 -DMP_PREC=4 -D_LARGEFILE64_SOURCE=1 -DTCL_WIDE_INT_TYPE=long\ long -DHAVE_STRUCT_STAT64=1 -DHAVE_OPEN64=1 -DHAVE_LSEEK64=1 -DHAVE_TYPE_OFF64_T=1 -DHAVE_GETCWD=1 -DHAVE_OPENDIR=1 -DHAVE_STRTOL=1 -DHAVE_WAITPID=1 -DHAVE_GETADDRINFO=1 -DHAVE_GETPWUID_R_5=1 -DHAVE_GETPWUID_R=1 -DHAVE_GETPWNAM_R_5=1 -DHAVE_GETPWNAM_R=1 -DHAVE_GETGRGID_R_5=1 -DHAVE_GETGRGID_R=1 -DHAVE_GETGRNAM_R_5=1 -DHAVE_GETGRNAM_R=1 -DHAVE_GETHOSTBYNAME_R_6=1 -DHAVE_GETHOSTBYNAME_R=1 -DHAVE_GETHOSTBYADDR_R_8=1 -DHAVE_GETHOSTBYADDR_R=1 -DUSE_TERMIOS=1 -DHAVE_SYS_TIME_H=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_GMTIME_R=1 -DHAVE_LOCALTIME_R=1 -DHAVE_MKTIME=1 -DHAVE_TM_GMTOFF=1 -DHAVE_TIMEZONE_VAR=1 -DHAVE_STRUCT_STAT_ST_BLOCKS=1 -DHAVE_STRUCT_STAT_ST_BLKSIZE=1 -DHAVE_BLKCNT_T=1 -DHAVE_INTPTR_T=1 -DHAVE_UINTPTR_T=1 -DHAVE_SIGNED_CHAR=1 -DHAVE_LANGINFO=1 -DHAVE_SYS_IOCTL_H=1 -DTCL_UNLOAD_DLLS=1 -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DTCL_CFG_OPTIMIZED=1 -DTCL_CFG_DEBUG=1 -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_TIMEGM=1 -DHAVE_DRAND48=1 -DHAVE_RANDOM=1 -DHAVE_POLL=1 -DHAVE_GETADDRINFO=1 -DHAVE_GETNAMEINFO=1 -c -o nspostgres.o nspostgres.c
<command-line>:0:0: warning: "PACKAGE_NAME" redefined [enabled by default]
<command-line>:0:0: note: this is the location of the previous definition
<command-line>:0:0: warning: "PACKAGE_TARNAME" redefined [enabled by default]
<command-line>:0:0: note: this is the location of the previous definition
<command-line>:0:0: warning: "PACKAGE_VERSION" redefined [enabled by default]
<command-line>:0:0: note: this is the location of the previous definition
<command-line>:0:0: warning: "PACKAGE_STRING" redefined [enabled by default]
<command-line>:0:0: note: this is the location of the previous definition
In file included from /usr/include/aolserver4/ns.h:62:0,
                 from nspostgres.h:34,
                 from nspostgres.c:32:
/usr/include/aolserver4/nsthread.h:129:17: fatal error: tcl.h: No such file or directory
 #include "tcl.h"
                 ^
compilation terminated.
make[1]: *** [nspostgres.o] Error 1
make[1]: Leaving directory `/build/buildd/aolserver4-nspostgres-4.5+20110709'
make: *** [build-stamp] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2

Full buildlog: https://launchpad.net/ubuntu/+source/aolserver4-nspostgres/4.5+20110709-1/+build/5436926/+files/buildlog_ubuntu-trusty-i386.aolserver4-nspostgres_4.5%2B20110709-1_FAILEDTOBUILD.txt.gz

[Launchpad Janitor (janitor)]

This bug was fixed in the package aolserver4-nspostgres - 4.5+20110709-1ubuntu1

---------------
aolserver4-nspostgres (4.5+20110709-1ubuntu1) trusty; urgency=low

  * Fixed FTBFS from using deprecated structure access of
    Tcl_interp (LP: #1303405)
    - nspostgres.c: replaces direct access of result field in
      Tlc_interp structure with API functions Tcl_GetStringResult
      and Tcl_SetString.
 -- Sebastian Carneiro <email address hidden> Sat, 05 Apr 2014 00:13:22 -0300