config-get returns scientific notation for large ints

[Matt Bruzek]

I was writing a new charm and I found an interesting problem.

When I put a large int value in config.yaml (30000000) and read this value in config-changed with config-get it returned the scientific notation of that number 3e+07.

This result was unexpected and very hard to deal with the number in a bash script. I was trying to do some math with "bc" which does not recognize this format of scientific notation.

I have included a skeleton charm that shows this. Deploy the charm and watch the unit logs it will echo the value from the config-changed hook.

Please let me know if you need any more information.

[Curtis Hovey (sinzui)]

This might be an issue with goyaml.

[Dave Cheney (dave-cheney)]

Hmm, interesting.

unit-test-0: 2014-04-04 03:05:33 DEBUG juju.worker.logger logger.go:45
reconfiguring logging from "<root>=DEBUG" to
"<root>=WARNING;unit=DEBUG"
unit-test-0: 2014-04-04 03:05:34 INFO config-changed 3e+07

Yet when I add a test case to the output_test.go tests in cmd/ it passes ... hmm

On Fri, Apr 4, 2014 at 6:03 AM, Curtis Hovey <email address hidden> wrote:
> This might be an issue with goyaml.
>
> ** Changed in: juju-core
> Status: New => Triaged
>
> ** Changed in: juju-core
> Importance: Undecided => High
>
> ** Tags added: config
>
> --
> You received this bug notification because you are subscribed to juju-
> core.
> Matching subscriptions: MOAR JUJU SPAM!
> https://bugs.launchpad.net/bugs/1302118
>
> Title:
> config-get returns scientific notation for large ints
>
> Status in juju-core:
> Triaged
>
> Bug description:
> I was writing a new charm and I found an interesting problem.
>
> When I put a large int value in config.yaml (30000000) and read this
> value in config-changed with config-get it returned the scientific
> notation of that number 3e+07.
>
> This result was unexpected and very hard to deal with the number in a
> bash script. I was trying to do some math with "bc" which does not
> recognize this format of scientific notation.
>
> I have included a skeleton charm that shows this. Deploy the charm
> and watch the unit logs it will echo the value from the config-changed
> hook.
>
> Please let me know if you need any more information.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juju-core/+bug/1302118/+subscriptions

[Dave Cheney (dave-cheney)]

Hmm, even more interesting

lucky(~/src/launchpad.net/juju-core) % juju run --unit test/0
'config-get --format=yaml -a'
int-option: 3e+07
lucky(~/src/launchpad.net/juju-core) % juju run --unit test/0
'config-get --format=smart -a'
int-option: 3e+07
lucky(~/src/launchpad.net/juju-core) % juju run --unit test/0
'config-get --format=json -a'
{"int-option":3e+07}

On Fri, Apr 4, 2014 at 2:06 PM, David Cheney <email address hidden> wrote:
> Hmm, interesting.
>
> unit-test-0: 2014-04-04 03:05:33 DEBUG juju.worker.logger logger.go:45
> reconfiguring logging from "<root>=DEBUG" to
> "<root>=WARNING;unit=DEBUG"
> unit-test-0: 2014-04-04 03:05:34 INFO config-changed 3e+07
>
> Yet when I add a test case to the output_test.go tests in cmd/ it passes ... hmm
>
> On Fri, Apr 4, 2014 at 6:03 AM, Curtis Hovey <email address hidden> wrote:
>> This might be an issue with goyaml.
>>
>> ** Changed in: juju-core
>> Status: New => Triaged
>>
>> ** Changed in: juju-core
>> Importance: Undecided => High
>>
>> ** Tags added: config
>>
>> --
>> You received this bug notification because you are subscribed to juju-
>> core.
>> Matching subscriptions: MOAR JUJU SPAM!
>> https://bugs.launchpad.net/bugs/1302118
>>
>> Title:
>> config-get returns scientific notation for large ints
>>
>> Status in juju-core:
>> Triaged
>>
>> Bug description:
>> I was writing a new charm and I found an interesting problem.
>>
>> When I put a large int value in config.yaml (30000000) and read this
>> value in config-changed with config-get it returned the scientific
>> notation of that number 3e+07.
>>
>> This result was unexpected and very hard to deal with the number in a
>> bash script. I was trying to do some math with "bc" which does not
>> recognize this format of scientific notation.
>>
>> I have included a skeleton charm that shows this. Deploy the charm
>> and watch the unit logs it will echo the value from the config-changed
>> hook.
>>
>> Please let me know if you need any more information.
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/juju-core/+bug/1302118/+subscriptions

[Curtis Hovey (sinzui)]

Actions also experience this problem. This looks like an under lying library that doesn't like number above 1,000,000.

[Nate Finch (natefinch)]

note, a quick test with goyaml shows it does the right thing. Must be somewhere else turning it into a float.

[Dave Cheney (dave-cheney)]

The default output format for config-get is json, that number is being
eaten by JSON's terrible handling of integers.

On Fri, Jun 12, 2015 at 6:59 AM, Nate Finch <email address hidden> wrote:
> note, a quick test with goyaml shows it does the right thing. Must be
> somewhere else turning it into a float.
>
> --
> You received this bug notification because you are subscribed to juju-
> core.
> Matching subscriptions: MOAR JUJU SPAM!
> https://bugs.launchpad.net/bugs/1302118
>
> Title:
> config-get returns scientific notation for large ints
>
> Status in goyaml:
> New
> Status in juju-core:
> Triaged
>
> Bug description:
> I was writing a new charm and I found an interesting problem.
>
> When I put a large int value in config.yaml (30000000) and read this
> value in config-changed with config-get it returned the scientific
> notation of that number 3e+07.
>
> This result was unexpected and very hard to deal with the number in a
> bash script. I was trying to do some math with "bc" which does not
> recognize this format of scientific notation.
>
> I have included a skeleton charm that shows this. Deploy the charm
> and watch the unit logs it will echo the value from the config-changed
> hook.
>
> Please let me know if you need any more information.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/goyaml/+bug/1302118/+subscriptions

[Adam Israel (aisrael)]

This also affects values passed in the CLI, i.e.:

$ juju action do mysql-benchmark/0 oltp table-size=1000000 num-threads=5

[Wayne Witzel III (wwitzel3)]

Not sure if this is the "right" fix, but have a patch for juju/cmd that I believe resolves this issue.

    https://github.com/wwitzel3/cmd/commit/50da537d06272412b73abc6f169daa61a4e40c7f

Adam, if you want to build a juju from source using this juju/cmd package and try your tests, that would be greatly appreciated.