[greeter/LockScreen] need a way to specify the minimum and maximum lengths of the code to ask
Bug #1302050 reported by
Antti Kaijanmäki
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Network Menu |
Fix Released
|
Undecided
|
Antti Kaijanmäki | ||
| unity8 (Ubuntu) |
Fix Released
|
High
|
Michael Zanetti | ||
Bug Description
LockScreen component is used to implement the pinlock snap decision. We need a way to specify a minimum and maximum values for a code we are requesting from the user. As example the PIN code has a minimum of 4 characters and a maximum of 8 characters. The PUK code on the other hand has to be exactly 8 characters long. In the future we might need to support other types of SIM lock codes as well with different lengths.
Related branches
lp:~mzanetti/unity8/lockscreen-enhancements
- PS Jenkins bot (community): Approve (continuous-integration)
- Antti Kaijanmäki (community): Approve
-
Diff: 749 lines (+342/-56)6 files modifiedqml/Components/PinPadButton.qml (+2/-1)
qml/Greeter/Lockscreen.qml (+91/-7)
qml/Greeter/PassphraseLockscreen.qml (+6/-2)
qml/Greeter/PinLockscreen.qml (+29/-11)
qml/Shell.qml (+2/-1)
tests/qmltests/Greeter/tst_Lockscreen.qml (+212/-34)
lp:~unity-api-team/indicator-network/dual_sim_pin_unlock
- Olga Kemmet (community): Approve (design)
- Michael Zanetti (community): Abstain
- PS Jenkins bot (community): Approve (continuous-integration)
- Charles Kerr (community): Approve
-
Diff: 899 lines (+329/-183)9 files modifiedpo/indicator-network.pot (+116/-76)
src/indicator/modem-manager.cpp (+3/-4)
src/indicator/modem.cpp (+2/-2)
src/indicator/sim-unlock-dialog.cpp (+139/-71)
src/indicator/sim-unlock-dialog.h (+1/-0)
src/menumodel-cpp/gio-helpers/variant.h (+28/-0)
src/notify-cpp/snapdecision/sim-unlock.cpp (+38/-28)
src/notify-cpp/snapdecision/sim-unlock.h (+1/-1)
tests/autopilot/indicator_network/data/pin-unlock.xml (+1/-1)
| Changed in unity8: | |
| importance: | Undecided → High |
| assignee: | nobody → Michael Zanetti (mzanetti) |
| Changed in unity8: | |
| assignee: | Michael Zanetti (mzanetti) → Antti Kaijanmäki (kaijanmaki) |
| Changed in indicator-network: | |
| assignee: | nobody → Antti Kaijanmäki (kaijanmaki) |
| Changed in unity8: | |
| assignee: | Antti Kaijanmäki (kaijanmaki) → Michael Zanetti (mzanetti) |
| Changed in unity8: | |
| status: | New → In Progress |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in unity8 (Ubuntu): | |
| status: | New → Fix Released |
| Changed in unity8: | |
| status: | In Progress → Fix Released |
| Changed in indicator-network: | |
| status: | New → In Progress |
| Changed in indicator-network: | |
| status: | In Progress → Fix Released |
| Changed in unity8 (Ubuntu): | |
| assignee: | nobody → Michael Zanetti (mzanetti) |
| importance: | Undecided → High |
| no longer affects: | unity8 |
To post a comment you must log in.
This bug was fixed in the package unity8 - 7.86+14.
---------------
unity8 (7.86+14.
[ Andrea Cimitan ]
* Passes to make tryCommand -qmljsdebugger=
debug/profiling test apps
* Fixes carousel shadow
[ Michał Sawicz ]
* Use dpkg-architecture, not gcc, to determine the machine triplet.
[ Ying-Chun Liu ]
* Fix ZoomableImage test failure. (LP: #1317254)
[ Albert Astals ]
* We don't need iconutils in this mock
* Don't reserve space for mascot if no mascot is specified (LP:
#1319343)
* CardHeader is no more, remove stale line in CMakeLists.txt
* GenericScopeVie
getting up the wrong delegate (maybe one that will be garbage
collected?) (LP: #1322279)
* Fix crash in organicgridtest
[ Daniel d'Andrada ]
* Remove Shell's underlay background image as it cannot be seen
anymore Now that the Dash has its own, opaque, background, the
underlay's background image can no longer be seen. So it's just a
waste of resources to have it.
[ Michael Terry ]
* Use the same animation when dismissing a greeter slide from the
launcher as from a normal greeter drag. (LP: #1316513)
[ Michael Zanetti ]
* enhance lockscreen add a retry indication label (e.g. 3 attempts
left). add an additional label (e.g. phone number for multi sim).
add a infoPopup (e.g. to display a warning for last retry). add min
and max limit values. add tests for the above (LP: #1302050)
-- Ubuntu daily release <email address hidden> Tue, 27 May 2014 07:47:11 +0000