VMware: exceptions when SOAP reply message has no body

[Gary Kotton]

Minesweeper logs have the following:

2014-03-26 11:37:09.753 CRITICAL nova.virt.vmwareapi.driver [req-3a274ea6-e731-4bbc-a7fc-e2877a57a7cb MultipleCreateTestJSON-692822675 MultipleCreateTestJSON-47510170] In vmwareapi: _call_method (session=52eb4a1e-04de-de0d-5c6a-746a430570a2)
2014-03-26 11:37:09.753 13830 TRACE nova.virt.vmwareapi.driver Traceback (most recent call last):
2014-03-26 11:37:09.753 13830 TRACE nova.virt.vmwareapi.driver File "/opt/stack/nova/nova/virt/vmwareapi/driver.py", line 856, in _call_method
2014-03-26 11:37:09.753 13830 TRACE nova.virt.vmwareapi.driver return temp_module(*args, **kwargs)
2014-03-26 11:37:09.753 13830 TRACE nova.virt.vmwareapi.driver File "/opt/stack/nova/nova/virt/vmwareapi/vim.py", line 196, in vim_request_handler
2014-03-26 11:37:09.753 13830 TRACE nova.virt.vmwareapi.driver raise error_util.VimFaultException(fault_list, excep)
2014-03-26 11:37:09.753 13830 TRACE nova.virt.vmwareapi.driver VimFaultException: Server raised fault: '
2014-03-26 11:37:09.753 13830 TRACE nova.virt.vmwareapi.driver SOAP body not found
2014-03-26 11:37:09.753 13830 TRACE nova.virt.vmwareapi.driver
2014-03-26 11:37:09.753 13830 TRACE nova.virt.vmwareapi.driver while parsing SOAP envelope
2014-03-26 11:37:09.753 13830 TRACE nova.virt.vmwareapi.driver at line 1, column 38
2014-03-26 11:37:09.753 13830 TRACE nova.virt.vmwareapi.driver
2014-03-26 11:37:09.753 13830 TRACE nova.virt.vmwareapi.driver while parsing HTTP request before method was determined
2014-03-26 11:37:09.753 13830 TRACE nova.virt.vmwareapi.driver at line 1, column 0'
2014-03-26 11:37:09.753 13830 TRACE nova.virt.vmwareapi.driver
2014-03-26 11:37:09.754 WARNING nova.virt.vmwareapi.vmops [req-3a274ea6-e731-4bbc-a7fc-e2877a57a7cb MultipleCreateTestJSON-692822675 MultipleCreateTestJSON-47510170] In vmwareapi:vmops:_destroy_instance, got this exception while un-registering the VM: Server raised fault: '
SOAP body not found

while parsing SOAP envelope
at line 1, column 38

while parsing HTTP request before method was determined
at line 1, column 0'

There are cases when the suds returns a message with no body.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/84431

[Davanum Srinivas (DIMS) (dims-v)]

looks like this is already fixed in oslo.vmware
https://github.com/openstack/oslo.vmware/blob/master/oslo/vmware/vim.py#L168

[John Garbutt (johngarbutt)]

We use milestones only at the very end of the milestone to track bugs that should block the release of the milestone. Please use tags not milestones to track bugs, try things like: my_bug_topic_milestone_name

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/84431
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=98fb5e56ef96c0c6a8754276e5f8c9c0b7e50fed
Submitter: Jenkins
Branch: master

commit 98fb5e56ef96c0c6a8754276e5f8c9c0b7e50fed
Author: Gary Kotton <email address hidden>
Date: Tue Apr 1 06:24:24 2014 -0700

    VMware: validate that VM exists on backend prior to deletion

    Attempting to delete an instance that does not exist on the backend
    throws an exception (for example UnregisterVM may return this when
    running the CI).

    Change-Id: I1b95caec2dad6580db576aa6f80f47913b7c066e
    Closes-bug: #1300788

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/124307

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/124310

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jeremy Stanley (<email address hidden>) on branch: stable/havana
Review: https://review.openstack.org/124307
Reason: The stable/havana branch has reached end of life and will no longer be supported now that 2013.2.4 is released. As such, all remaining open changes for this branch on official OpenStack projects are being abandoned.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/124310
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3e8043349f02ae69f4b721d1f965e574b66e0d3b
Submitter: Jenkins
Branch: stable/icehouse

commit 3e8043349f02ae69f4b721d1f965e574b66e0d3b
Author: Michal Jura <email address hidden>
Date: Fri Sep 26 09:01:50 2014 +0200

    VMware: validate that VM exists on backend prior to deletion

    Attempting to delete an instance that does not exist on the backend
    throws an exception (for example UnregisterVM may return this when
    running the CI).

    Fixes: bug #1300788

    (cherry picked from commit 98fb5e56ef96c0c6a8754276e5f8c9c0b7e50fed)

    Change-Id: I1b95caec2dad6580db576aa6f80f47913b7c066e