input events not being flushed in browser until pressing hardware keys
Bug #1300382 reported by
Bill Filler
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Oxide |
Fix Released
|
Critical
|
Olivier Tilloy | ||
The Webapps-core project |
Invalid
|
High
|
Unassigned | ||
ubuntu-keyboard |
Fix Released
|
High
|
Olivier Tilloy | ||
oxide-qt (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
ubuntu-keyboard (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
using webbrowser-app from Silo 9 and oxide in universe
Log in to Facebook on the phone
Click "comment" in someone's post
Start typing
Expected results:
The comment button should become enabled so you can submit comment
Actual results:
The comment button always stays disabled.
Tested this on webbrowser-app on desktop with oxide (explicilty loading m.facebook.com) and becomes enabled as it should after typing. Seems specific to device. Guessing it's a UA String issue.
Is there a way to see the JS console to see if a JS error is occuring?
Related branches
lp:~osomon/oxide/im-fake-key-events
- Chris Coulson: Pending requested
-
Diff: 50 lines (+21/-0)1 file modifiedqt/core/browser/oxide_qt_render_widget_host_view.cc (+21/-0)
lp:~osomon/ubuntu-keyboard/key-press-release
- Bill Filler (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 99 lines (+23/-14)3 files modifiedsrc/view/abstracttexteditor.cpp (+10/-4)
src/view/abstracttexteditor.h (+3/-0)
tests/unittests/ut_repeat-backspace/ut_repeat-backspace.cpp (+10/-10)
Changed in webbrowser-app: | |
importance: | Undecided → High |
Changed in webapps-core: | |
importance: | Undecided → High |
Changed in webbrowser-app: | |
assignee: | nobody → Olivier Tilloy (osomon) |
Changed in ubuntu-keyboard: | |
status: | New → In Progress |
assignee: | nobody → Olivier Tilloy (osomon) |
importance: | Undecided → High |
Changed in oxide: | |
status: | In Progress → Fix Committed |
Changed in ubuntu-keyboard: | |
status: | In Progress → Fix Released |
Changed in oxide: | |
status: | Fix Committed → Fix Released |
Changed in webapps-core: | |
status: | New → Invalid |
To post a comment you must log in.
Looking at the specifc Facebook code in the page. It's basically a <textarea id="composerInput"> and a <button> in a <form> as follows:
<form method="post" class=" composer_ form" data-store= "{ "expand_ composer& quot;:true& #125;" id="comment_ form_1068640102 _10202428868777 549" action= "/a/comment. php?actionsourc e=2& ft_ent_ identifier= 102024288687775 49& gfid=AQB- 5WrCooTqARii& amp;__av= 726399492& amp;refid= 52" onsubmit="return window. MAjaxify& amp;& MAjaxify. form(event, this," async_composer& quot;,& quot;cache& quot;,null, false); "> €,´,€,´ ,水,Д,Є" /> comboInput" ><tr><td class=" inputCell" ><div class="mentions" id="u_0_6">
<input type="hidden" name="fb_dtsg" value="AQAEgIey" autocomplete="off" />
<input type="hidden" name="charset_test" value="
<table cellspacing="0" cellpadding="0" class="
<textarea class=" composerInput mentions-input" id="composerInput" name="comment_text" rows="1" placeholder="Write a comment..." cols="15" data-sigil= "textarea" ></textarea> </div>< /td> btnCell" ><button type="submit" value="Comment" class="touchable _56bs _5of- _56bt" disabled="1" name="post" data-sigil= "touchable composer-submit"> _55sr"> Comment< /span>< /button>
<td class="
<span class="
</td>
</tr>
</table>
</form>
There must be some code that listens for changes to the textarea and enables the button appropriately and this is not working.
Can we verify that our input is correctly getting propagated to the underlying textarea on the device? Seems as if it's not somehow, even though it is correctly displayed. Perhaps the QtInputMethod is not getting commited correctly on multi-line text areas?