When Unity.Session is available, use its API for logging out
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Session Menu |
Fix Released
|
Critical
|
Charles Kerr | ||
Unity |
Fix Released
|
Undecided
|
Marco Trevisan (Treviño) | ||
indicator-session (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Trusty |
Fix Released
|
Medium
|
Unassigned | ||
unity (Ubuntu) |
Fix Released
|
Undecided
|
Marco Trevisan (Treviño) | ||
unity8-desktop-session (Ubuntu) |
Fix Released
|
Medium
|
Charles Kerr |
Bug Description
[Impact]
The session indicator always uses gnome-session to end the session (log out), but gnome-session is not guaranteed to be available under, for example, a Unity8 desktop preview session. It should use Upstart where available.
[Test Case]
Install unity8-
[Regression Potential]
In the worst case this change could affect log out operations from regular Unity 7 sessions and potentially other sessions that use the session indicator. In such a case, the log out operation would fail necessitating a reboot or manual session kill.
[Other Info]
This change has been in production use on later releases of Ubuntu (14.10 and later) without problems.
Later version of the Unity 8 desktop session do not exit to the LightDM login screen but instead restart Unity 8 and present the Unity 8 login screen. This is a bug in Unity 8 and not related to indicator-session.
Related branches
- PS Jenkins bot (community): Approve (continuous-integration)
- Ted Gould: Pending requested
- Diff: 0 lines
- Ted Gould (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 479 lines (+219/-80)5 files modifiedsrc/backend-dbus/actions.c (+117/-35)
tests/backend-dbus/gtest-mock-dbus-fixture.h (+0/-6)
tests/backend-dbus/mock-unity-session.cc (+14/-2)
tests/backend-dbus/mock-unity-session.h (+4/-0)
tests/backend-dbus/test-actions.cc (+84/-37)
- Ted Gould (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 479 lines (+219/-80)5 files modifiedsrc/backend-dbus/actions.c (+117/-35)
tests/backend-dbus/gtest-mock-dbus-fixture.h (+0/-6)
tests/backend-dbus/mock-unity-session.cc (+14/-2)
tests/backend-dbus/mock-unity-session.h (+4/-0)
tests/backend-dbus/test-actions.cc (+84/-37)
Changed in unity8-desktop-session (Ubuntu): | |
status: | New → In Progress |
importance: | Undecided → Medium |
Changed in unity8-desktop-session (Ubuntu): | |
assignee: | nobody → Charles Kerr (charlesk) |
summary: |
- Use upstart to log out when available + When Unity.Session is available, use its API for logging out |
Changed in indicator-session: | |
status: | In Progress → Fix Committed |
Changed in indicator-session: | |
status: | Fix Committed → Fix Released |
Changed in unity (Ubuntu): | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
Changed in indicator-session (Ubuntu Trusty): | |
status: | New → In Progress |
importance: | Undecided → Medium |
description: | updated |
Changed in unity (Ubuntu): | |
status: | New → Fix Released |
Changed in unity: | |
status: | New → Fix Released |
no longer affects: | unity |
Changed in unity: | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
status: | New → Fix Released |
See the partial (hacked) implementation at lp:~unity8-desktop-session-team/indicator-session/indicator-session-using-upstart and the binary packages at https:/ /launchpad. net/~unity8- desktop- session- team/+archive/ custom/ +packages for an example.