VMWare: Resize action does not change disk

[Feng Xi Yan]

In "nova/virt/vmwareapi/vmops.py"

def finish_migration(self, context, migration, instance, disk_info,
                         network_info, image_meta, resize_instance=False,
                         block_device_info=None, power_on=True):
        """Completes a resize, turning on the migrated instance."""
        if resize_instance:
            client_factory = self._session._get_vim().client.factory
            vm_ref = vm_util.get_vm_ref(self._session, instance)
            vm_resize_spec = vm_util.get_vm_resize_spec(client_factory,
                                                        instance)
            reconfig_task = self._session._call_method(
                                            self._session._get_vim(),
                                            "ReconfigVM_Task", vm_ref,
                                            spec=vm_resize_spec)
.....................

finish_migration uses vm_util.get_vm_resize_spec() to get resize parameters.

But in "nova/virt/vmwareapi/vm_util.py"

def get_vm_resize_spec(client_factory, instance):
    """Provides updates for a VM spec."""
    resize_spec = client_factory.create('ns0:VirtualMachineConfigSpec')
    resize_spec.numCPUs = int(instance['vcpus'])
    resize_spec.memoryMB = int(instance['memory_mb'])
    return resize_spec

the get_vm_resize_spec action does not set up disk size to resize.

[John Garbutt (johngarbutt)]

Is this a regression, there was a blueprint raised, by never implemented around this area?

[Tracy Jones (tjones-i)]

Just from reading it - it sounds like a simple bug that has always existed - but Eric is looking into it

[Russell Bryant (russellb)]

Since there's not a patch here yet and it's not a regression, I don't think we should block on it for RC1 at this point. I'm going to move this to the rc1-potential list.

[Eric Brown (ericwb)]

This bug has a dependency on https://bugs.launchpad.net/nova/+bug/1295381

[Eric Brown (ericwb)]

Looks like this problem existed in Havana also. So its not a regression.

vm_util.py:
def get_vm_resize_spec(client_factory, instance):
    """Provides updates for a VM spec."""
    resize_spec = client_factory.create('ns0:VirtualMachineConfigSpec')
    resize_spec.numCPUs = int(instance['vcpus'])
    resize_spec.memoryMB = int(instance['memory_mb'])
    return resize_spec

vmops.py:
    def finish_migration(self, context, migration, instance, disk_info,
                         network_info, image_meta, resize_instance=False,
                         block_device_info=None, power_on=True):
        """Completes a resize, turning on the migrated instance."""
        if resize_instance:
            client_factory = self._session._get_vim().client.factory
            vm_ref = vm_util.get_vm_ref(self._session, instance)
            vm_resize_spec = vm_util.get_vm_resize_spec(client_factory,
                                                        instance)
            reconfig_task = self._session._call_method(
                                            self._session._get_vim(),
                                            "ReconfigVM_Task", vm_ref,
                                            spec=vm_resize_spec)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/82227

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/85804

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/85804
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7ae506a4b1829fbd8cbecc0a6b267f76230face7
Submitter: Jenkins
Branch: master

commit 7ae506a4b1829fbd8cbecc0a6b267f76230face7
Author: Eric Brown <email address hidden>
Date: Mon Apr 7 13:27:47 2014 -0700

    VMware: Resize operation fails to change disk size

    The finish_migration step will resize the cpu and memory to match
    the new flavor chosen, but not the disk size. Additional code was
    added to extend the disk size using ExtendVirtualDisk_Task.

    DocImpact

    Change-Id: Iff10443f603d329d01a74a620079f80518b75a50
    Closes-bug: #1291741

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/127925

[OpenStack Infra (hudson-openstack)]

Change abandoned by Cedric Brandily (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/127925