VMware: resize operates on orig VM and not clone

[Eric Brown]

The resize operation when using the VCenter driver ends up resizing the original VM and not the newly cloned VM.

To recreate:
1) create a new VM from horizon using default debian image. I use a flavor of nano.
2) wait for it to complete and go active
3) click on resize and choose a flavor larger than what you used originally. i then usually choose a flavor of small.
4) wait for horizon to prompt you to confirm or revert the migration.
5) Switch over to vSphere Web Client. Notice two VMs for your newly created instance. One with a UUID name and the other with a UUID-orig name. "-orig" indicating the original.
6) Notice the original has be resized (cpu and mem are increased, disk is not, but that's a separate bug) and not the new clone. This is problem #1.
7) Now hit confirm in horizon. It works, but the logs contain a warning: "The attempted operation cannot be performed in the current state (Powered on).". I suspect its attempting to destroy the orig VM, but the orig was the VM resized and powered on, so it fails. This is problem #2.
Results in a leaked VM.

[Tracy Jones (tjones-i)]

this looks like a regression to me

[Sabari Murugesan (smurugesan)]

This affects migration as well, in a sense, because the orig VM is powered-on. so confirm_migration is not able to delete the orig-vm.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/82264

[Russell Bryant (russellb)]

This is currently blocking icehouse-rc1. Since we don't have word for when to expect vmware CI to be back up, we're going to move forward with RC1 and potentially pick this back up if we have to do an RC2 later.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/82264
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=91ddf85abb8a516cfa2da346b393aa7234660f6c
Submitter: Jenkins
Branch: master

commit 91ddf85abb8a516cfa2da346b393aa7234660f6c
Author: Sidharth Surana <email address hidden>
Date: Fri Mar 21 17:03:40 2014 -0700

    VMware: Fixes the instance resize problem

    The fix includes separating out methods for
    associating/disassociating a vsphere vm from the
    openstack instance. Modifying the resize workflow
    to use the above mentioned methods.

    Closes-Bug: #1295381

    Change-Id: I92acdd5cd00f739d504738413d3b63a2e17f2866

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/85740

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/85740
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b6e14a58b37811312f344402e3003d439c0ccc71
Submitter: Jenkins
Branch: milestone-proposed

commit b6e14a58b37811312f344402e3003d439c0ccc71
Author: Sidharth Surana <email address hidden>
Date: Fri Mar 21 17:03:40 2014 -0700

    VMware: Fixes the instance resize problem

    The fix includes separating out methods for
    associating/disassociating a vsphere vm from the
    openstack instance. Modifying the resize workflow
    to use the above mentioned methods.

    Closes-Bug: #1295381

    Change-Id: I92acdd5cd00f739d504738413d3b63a2e17f2866
    (cherry picked from commit 91ddf85abb8a516cfa2da346b393aa7234660f6c)