unwanted lbaas related error logs in q-svc screen
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
neutron |
Fix Released
|
Medium
|
Oleg Bondarev | ||
oslo-incubator |
Fix Released
|
Medium
|
Unassigned |
Bug Description
2014-03-03 09:25:31.621 5910 ERROR root [-] Original exception being dropped: ['Traceback (most recent call last):\n', ' File "/opt/stack/
2014-03-03 09:25:31.622 5910 WARNING neutron.
There is no need for error log about original exception being dropped as warning log is enough.
This happens due to using save_and_
def _get_resource(self, context, model, id):
try:
r = self._get_
except exc.NoResultFound:
with excutils.
if issubclass(model, Vip):
return r
where the whole purpose of exception handler is to reraise proper type of exception.
I think save_and_
In this particular case I don't see the reason for using save_and_
As an option I think a parameter can be added to save_and_
Changed in oslo: | |
status: | Triaged → Fix Committed |
Changed in neutron: | |
importance: | Undecided → Medium |
milestone: | none → icehouse-rc1 |
Changed in neutron: | |
status: | Fix Committed → Fix Released |
Changed in oslo: | |
milestone: | none → icehouse-rc1 |
status: | Fix Committed → Fix Released |
Changed in oslo: | |
milestone: | icehouse-rc1 → 2014.1 |
Changed in neutron: | |
milestone: | icehouse-rc1 → 2014.1 |
I'm wondering if the correct thing to do here is to make the logging code respect the reraise parameter and then use that to say that the exception handler doesn't want to reraise the original exception. That seems like the behavior we want with reraise anyway.
https:/ /github. com/openstack/ oslo-incubator/ blob/master/ openstack/ common/ excutils. py#L67