Cannot delete volume-type by name

[Peter Hamilton]

Files: cinderclient.v1.shell, ditto v2
Method: do_type_delete
Bug: can only delete volume-type by ID

The type-delete command only accepts the type ID when deleting a volume type. Virtually every other delete command in cinderclient accepts both the entity ID and the entity name. Furthermore, the underlying volume-type manager expects to get a volume type, rather than the ID, because it calls base.getid on the provided input. If it expected the ID, it would just pass the ID directly to the REST API call.

Fix: modify the do_type_delete methods to accept the type ID or type name, look up the corresponding volume type, and pass this to the underlying volume-type manager for processing.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/77264

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/77264
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=3ec28c3309d28d99a10ab1e1b55fd360fd2a97b5
Submitter: Jenkins
Branch: master

commit 3ec28c3309d28d99a10ab1e1b55fd360fd2a97b5
Author: Peter Hamilton <email address hidden>
Date: Fri Feb 28 15:30:54 2014 -0500

    Fix type-delete to allow deletion by name and ID

    This change addresses bug #1286314, fixing type deletion to allow
    deletion by either volume type name or ID. The former implementation
    only accepted the volume type ID. Help documentation is also updated
    to reflect this change.

    Change-Id: I0fc66b54a7bcfa4e00a4d136ac513fa40e628dd2
    Closes-Bug: #1286314
    DocImpact