Data-role="tab" doesnt work for HTML5 apps

Bug #1285986 reported by Artur Frącek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Developer Portal
Invalid
Undecided
Unassigned
Ubuntu HTML5 UI SDK
Fix Released
Undecided
Unassigned
ubuntu-html5-theme (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

data-role="tab" doesn't actually work for creating pages for flat (tab style) navigation. You have to use data-role="page". I tested this both on desktop and Nexus4.

Here's a list of pages that I know contain examples that don't work:
http://developer.ubuntu.com/apps/html-5/guides/html5-guide/
http://developer.ubuntu.com/api/html5/sdk-14.04/UbuntuUI.Tabs/
http://developer.ubuntu.com/api/html5/sdk-14.04/UbuntuUI.Header/

Related branches

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Thanks for the bug.

This simple app branch confirms that data-role='page' currently works (it should not work) and that data-role='tab' does not work (It should).

lp:~knitzsche/+junk/dataroletabbug/

tags: added: html5-blocker
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

There was some discussion in irc about a possible fix to this:

* Use attribute "data-tab='...' in header with data-role="tab" for tab style nav
* Use attribute "data-page='...' in header with data-role="page" for page style nav

This approach makes sense in theory, but it is a change in html5 declarations.

Any change in html5 declations right now requires a range of changes to published docs and supporting branches, including:
* API docs
* HTML5 guide
* HTML5 'Meanings' App tutorial (guide and branch)
* Cordova Camera Tutorial (guide and branch)

So if this change IS made, please add Ubuntu App Developer Side back as an affected project.

Changed in ubuntudeveloperportal:
status: New → Invalid
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

"Ubuntu App Developer Site", not 'Side'

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-html5-theme - 0.1.2+14.04.20140303-0ubuntu1

---------------
ubuntu-html5-theme (0.1.2+14.04.20140303-0ubuntu1) trusty; urgency=low

  [ CI bot ]
  * Various fixes to the HTML5 UI SDK docs (LP: #1284729)

  [ Alexandre Abreu ]
  * Merge lp:~ya-bo-ng/ubuntu-html5-theme/sass-setup
  * This branch concatenates several CSS updates that need to be
    manually merged right now to avoid a conflict in the appTemplate.css
    file that is re-generated by SASS. The branches where:
    https://code.launchpad.net/~ya-bo-ng/ubuntu-html5-theme/update-
    progress-bar/+merge/206386 https://code.launchpad.net/~ya-bo-
    ng/ubuntu-html5-theme/adding-svg-images/+merge/207689
    https://code.launchpad.net/~abreu-alexandre/ubuntu-html5-
    theme/fix.toggle-zindex/+merge/207979
    https://code.launchpad.net/~ya-bo-ng/ubuntu-html5-theme/button-
    update/+merge/208029 https://code.launchpad.net/~daker/ubuntu-html5-
    theme/untabiffy-pagejs/+merge/208022
    https://code.launchpad.net/~abreu-alexandre/ubuntu-html5-theme/fix-
    docs-html5-new-structure/+merge/208227
  * Fix the page-tab issue. page-tab now works as the way to define
    target tabs. (LP: #1285986)
  * add testability support (LP: #1286175)
 -- Ubuntu daily release <email address hidden> Mon, 03 Mar 2014 16:55:01 +0000

Changed in ubuntu-html5-theme (Ubuntu):
status: New → Fix Released
Changed in ubuntu-html5-theme:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.