Data-role="tab" doesnt work for HTML5 apps
Bug #1285986 reported by
Artur Frącek
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Developer Portal |
Invalid
|
Undecided
|
Unassigned | ||
Ubuntu HTML5 UI SDK |
Fix Released
|
Undecided
|
Unassigned | ||
ubuntu-html5-theme (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
data-role="tab" doesn't actually work for creating pages for flat (tab style) navigation. You have to use data-role="page". I tested this both on desktop and Nexus4.
Here's a list of pages that I know contain examples that don't work:
http://
http://
http://
Related branches
lp:~abreu-alexandre/ubuntu-html5-theme/fix-page-tab-issue
- PS Jenkins bot: Approve (continuous-integration)
- Kyle Nitzsche: Approve
- Ubuntu HTML5 Theme Developers: Pending requested
-
Diff: 473 lines (+245/-22)8 files modified0.1/ambiance/js/buttons.js (+1/-0)
0.1/ambiance/js/core.js (+51/-9)
0.1/ambiance/js/dialogs.js (+1/-0)
0.1/ambiance/js/header.js (+2/-1)
0.1/ambiance/js/list.js (+1/-0)
0.1/ambiance/js/page.js (+1/-1)
0.1/ambiance/js/tab.js (+163/-0)
0.1/ambiance/js/tabs.js (+25/-11)
tags: | added: html5-blocker |
Changed in ubuntu-html5-theme: | |
status: | New → Fix Released |
To post a comment you must log in.
Thanks for the bug.
This simple app branch confirms that data-role='page' currently works (it should not work) and that data-role='tab' does not work (It should).
lp:~knitzsche/+junk/dataroletabbug/