regression: Pitch slider no longer updates during drag

[Owen Williams]

The pitch slider should change pitch as it is being adjusted with the mouse. Currently in trunk the slider doesn't update until the mouse button is released.

[Owen Williams (ywwg)]

I mean, the pitch doesn't update until the mouse button is released.

[Daniel Schürmann (daschuer)]

This is due to the new silent mode for the rate slider:

<Connection>
<ConfigKey>[Sampler1],rate</ConfigKey>
<EmitOnDownPress>false</EmitOnDownPress> <- this means, it emits inly on release only.
</Connection>

You can fix it by removing it.

It was requested here https://github.com/mixxxdj/mixxx/pull/179#issuecomment-35308856
and a result of the discussion in https://github.com/mixxxdj/mixxx/pull/179#discussion_r9884240

Maybe it was wrong.
Possible solutions:
1.) Fix all skins
2.) Remove the press release filter consideration from the (legacy) slider and inherit a new on which has the filters in place
3.) Introduce a new option <EmitOnMove>false</EmitOnMove>

What do you like most?

[Owen Williams (ywwg)]

To prevent breakage of existing skins, I prefer the <EmitOnMove>false</EmitOnMove> solution. I don't really understand RJ's use-case of adjusting something and then activating on release, but that seems like a much more unusual choice. Every hardware mixer in the world and every turntable/controller updates the pitch while the slider is being moved, and we shouldn't break old skins that assume that functionality.

[RJ Skerry-Ryan (rryan)]

I agree that we shouldn't break existing skins. I didn't mean it should be
the default -- I simply meant it should be possible for the skinner. My
mistake for missing this in code review, sorry!

On Monday, February 24, 2014 9:20:48 PM, Owen Williams <email address hidden>
wrote:

> To prevent breakage of existing skins, I prefer the
> <EmitOnMove>false</EmitOnMove> solution. I don't really understand RJ's
> use-case of adjusting something and then activating on release, but that
> seems like a much more unusual choice. Every hardware mixer in the
> world and every turntable/controller updates the pitch while the slider
> is being moved, and we shouldn't break old skins that assume that
> functionality.
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1283844
>
> Title:
> regression: Pitch slider no longer updates during drag
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1283844/+subscriptions
>

[Owen Williams (ywwg)]

I agree with the suggestion to add <EmitOnMove>false</EmitOnMove> to preserve existing behavior.

[Owen Williams (ywwg)]

er, I mean to offer the possibility of new behavior while preserving existing skins.

[Daniel Schürmann (daschuer)]

I have just introduced a new EMIT_ON_MOVE option.
https://github.com/daschuer/mixxx/pull/3
But while coding this, i have just noticed that this is not a solution for this issue.
1.11 skins are setting <EmitOnDownPress>false</EmitOnDownPress> = EMIT_ON_RELEASE for a unknown reason.
Since we omit the Widget default once an emit option is manually set this means EMIT_ON_RELEASE only.
Overwriting these settings will a solution for our current problem, but this will somehow disable the config options for advanced skinners as well.
So for now, I will bypass all Emit options in WSliderComposed and fix the undocumented
<EventWhileDrag>no</EventWhileDrag> instead. If required, we may later introduce a new WSliderComposedEx widget which respects the emit options.

[Daniel Schürmann (daschuer)]

it seams that <EventWhileDrag>no</EventWhileDrag> does more than we can assume from the name. I think we need a discussion where to move with the slider. Maybe we can combine all features in one slider without a need for a new one and without braking old skins.
Since this bus is solved I will file a new one Bug #1284858

[Daniel Schürmann (daschuer)]

Fix committed to https://github.com/mixxxdj/mixxx/commit/2df4961e8ddad732fc2fe3075940e921d11b0b0b

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7325