Muon Discover does not show most apps

Bug #1283004 reported by Jonathan Riddell
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Muon
Fix Released
Medium
muon (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Categories are mostly but not entirely empty

Tags: kubuntu
Revision history for this message
In , Jonathan Riddell (jr) wrote :

Most apps are not listed in Muon Discover categories. If I got to Games -> All only 2 games are shown (Magicor and Search & Rescue). But if I search in the search bar for say kolf the game is correctly shown.

This is using Muon 2.1.70 package from Kubuntu 14.04 pre-release with libqapt 2.1.70.

Reproducible: Always

Changed in muon (Ubuntu):
milestone: none → ubuntu-14.04
tags: added: kubuntu
Changed in muon:
importance: Unknown → Medium
status: Unknown → New
Revision history for this message
In , Harald Sitter (apachelogger) wrote :

Same in muon-installer, so this likely is a problem with the models.

Changed in muon:
status: New → Unknown
Revision history for this message
In , Aleix Pol (aleixpol-kde) wrote :

This can't be reproduced in 13.10.
I'll need some more information... :/

Revision history for this message
In , Harald Sitter (apachelogger) wrote :

Perhaps kdelibs broke?

offending commit is f9931c3d841ccb215a3bad14e0adc9dddb84091c

it introduces the following change:
- QString categories = getField("Categories");
+ QStringList categories = QString(getField("Categories")).split(',', QString::SkipEmptyParts);

which in turn leads to the proxy model refusing to apply category filters:
muon-discover(12215) shouldFilter: "KPatience"
muon-discover(12215) shouldFilter: "Qt;KDE;Game;CardGame;"
muon-discover(12215) shouldFilter: CategoryFilter false

So, either that change was wrong to begin with, or kdelibs changed behavior. Categories as per the spec is a ; seperated list, however I seem to recall that the previous thing we used in KDE had , as seperator (might be utterly unrelated :P).

The question is, does it actually return "Foo,Bar" on kdelibs 4.11, if so then I guess kdelibs should get fixed.

Revision history for this message
In , Harald Sitter (apachelogger) wrote :

ah, fwiw, the commit is in muon, I did not look for any related changes in kdelibs.

Revision history for this message
In , Aleix Pol (aleixpol-kde) wrote :

Ah yes, that did change. I'll have to try it again then, maybe I looked the wrong way...?

PS: I should add tests for that!

Changed in muon:
status: Unknown → In Progress
Revision history for this message
In , Aleix Pol (aleixpol-kde) wrote :

Git commit 635479c77dc76be3c3cfcd71aa405ef7fc128bc6 by Aleix Pol.
Committed on 01/03/2014 at 20:12.
Pushed by apol into branch '2.2'.

Split categories

This API changed over this summer, it wasn't properly
ported.

M +2 -2 libmuon/backends/ApplicationBackend/Application.cpp

http://commits.kde.org/muon/635479c77dc76be3c3cfcd71aa405ef7fc128bc6

Revision history for this message
Harald Sitter (apachelogger) wrote :

Fix upstream, pending release.

Changed in muon (Ubuntu):
status: New → Fix Committed
Changed in muon:
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package muon - 2.1.70-0ubuntu3

---------------
muon (2.1.70-0ubuntu3) trusty; urgency=medium

  * Import upstream commits since release, improving l10n and resolving a
    couple of bugs.
    + All in sub directory upstream_git/ (git format-patch export)
    LP: #1283004
 -- Harald Sitter <email address hidden> Mon, 10 Mar 2014 14:40:28 +0100

Changed in muon (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
In , Jonathan Riddell (jr) wrote :

Git commit 3a9d2769b6ce8b8ec1b25d5db2782dd004fe7d7d by Jonathan Riddell.
Committed on 04/03/2015 at 16:19.
Pushed by jriddell into branch 'Plasma/5.2'.

Add back patch for bug 331374
App categories do not work
Related: bug 344831

M +2 -2 libmuon/backends/ApplicationBackend/Application.cpp

http://commits.kde.org/muon/3a9d2769b6ce8b8ec1b25d5db2782dd004fe7d7d

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.