KPAC Holds Not Pulling in Notification Information

[Terran McCanna]

Since the KPAC interface doesn't display a patron's email/phone notification preferences, we had initially assumed it was pulling in the patron's default notification info, but we've found that it does not.

Emails are not sent to patrons who have their notification preferences set to email, and hold slips print out without phone numbers or email addresses. This causes extra work for Circ staff in processing incoming holds as they need to look up each account number to get the patron's contact information.

Evergreen 2.5.1
OpenSRF 2.2.1
PostgreSQL 9.1.11
Ubuntu 12.04 LTS

[Ben Shum (bshum)]

This was extra perplexing and detrimental when using hold shelf expiration where the patron doesn't get automatically notified in any way and their hold expires without a word. And the staff don't pay close enough attention for some reason.

Marking confirmed, something to work on...

[Terran McCanna (tmccanna)]

PINES is funding a fix (work to be done by Equinox) to have it pull in the patron's default hold contact preferences so that the patron's automated hold notification email will be triggered and the contact info will be printed out on the hold slip.

[Tim Spindler (tspindler-cwmars)]

Dan Pearl has code that he worked on for this already. I will see if he can get it posted.

[Bill Erickson (berick)]

Tim, that would great. Here's a brief summary of what I was planning to do: http://yeti.esilibrary.com/dev/pub/techspecs/kpac-hold-prefs-default.html

I'll keep an eye out for Dan's code and will be happy to review, test, etc.

[Dan Pearl (dpearl)]

Thanks for reviewing, folks!

(Note to testers: You'll need to restart apache)

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dpearl/kpac

[Terran McCanna (tmccanna)]

I tested Dan's patch as part of Bug Squashing Day on the sandbox that MassLNC set up for it, but I wasn't able to get it to pull in the notification preferences we use.

I'm working on a patch that takes a slightly different approach to the same problem that I'll post tomorrow.

[Terran McCanna (tmccanna)]

This patch pulls in the patron's email & phone notification preferences and related values in hidden fields and allows the patron to choose their pickup library at time of hold placement (defaults to their preferred pickup location):

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=6a46c33de977a6c2bb8f990d0f306da6bd622731

Will greatly appreciate someone testing!

[Ben Shum (bshum)]

Hi Terran, I tested your patch and it works as advertised. Pushing your fix forward to master for now. Have to evaluate if there's any further work required here.