Needs to backport trusty's fix to handle duplicity's lockfile

[Louis Bouchard]

SRU justification :

Duplicity implements a new lockfile that impacts deja-dup functionality. A fix to remove the lockfile is already commited upstream and in Trusty. The SRU is to make the fix available before duplicity's SRU is completed

Impact :

Without this SRU, duplicity's SRU for LP: #1266763 will cause errors when backing up after having previously cancelled a backup.

Fix :

Remove the lockfile since concurrency is handled in DBUS in deja-dup

Test Case :
1) Start a backup
2) Cancel it once it begins backing up
3) Start the backup again

If you get an error right at the beginning of (3) about lockfiles, this bug isn't fixed. If the backup proceeds, it's fixed!

Regression :

None expected as it remove a file that is only present with newer versions of duplicity

Description of the problem :

See justification

[Louis Bouchard (louis)]

The patch for the development release has already been uploaded by mterry and is awaiting in -proposed. Marking the dev task "Commited"

[Louis Bouchard (louis)]

debdiff for precise

[Louis Bouchard (louis)]

I forgot to mention one important thing for sponsors :

I was not able to build deja-dup from the source pkg with or _WITHOUT_ the patches using sbuild. pbuilder worked fine, as well as building as a PPA. Here is the resulting PPA for reference :

https://launchpad.net/~louis-bouchard/+archive/testdup

[Michael Terry (mterry)]

Uploaded to precise with one change:
+ Posix.system("/bin/rm -f " + Shell.quote(cache_dir) + "/*/lockfile.lock");
Became
+ Posix.system("/bin/rm -f " + Shell.quote(cache_dir) + "/" + Config.PACKAGE + "/*/lockfile.lock");

Because in trusty's deja-dup, cache_dir already contained PACKAGE, but in precise's, it didn't.

Tested and worked for me combined with the duplicity SRU.

[Michael Terry (mterry)]

Uploaded to saucy without change. Thanks!

[Sebastien Bacher (seb128)]

(seems like Michael did the sponsoring, unsubscribing ubuntu-sponsors)

[Chris Halse Rogers (raof)]

Hello Louis, or anyone else affected,

Accepted deja-dup into saucy-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/deja-dup/27.3.1-0ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Brian Murray (brian-murray)]

Hello Louis, or anyone else affected,

Accepted deja-dup into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/deja-dup/22.0-0ubuntu5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Chris Halse Rogers (raof)]

SRU-team ping! The associated duplicity bugs have been confirmed-fixed in saucy, but we can't release them until this package has been confirmed-fixed.

[Louis Bouchard (louis)]

Verified for both Saucy & Precise

[Launchpad Janitor (janitor)]

This bug was fixed in the package deja-dup - 22.0-0ubuntu5

---------------
deja-dup (22.0-0ubuntu5) precise; urgency=low

  * debian/patches/kill-lockfile.patch
    - Backport patch from trunk that removes the lockfile placed by
      duplicity to avoid concurrency. Deja-dup avoid concurrency using
      its own method using Dbus (LP: #1281066)
 -- Louis Bouchard <email address hidden> Mon, 17 Feb 2014 17:09:35 +0100

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for deja-dup has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package deja-dup - 27.3.1-0ubuntu2

---------------
deja-dup (27.3.1-0ubuntu2) saucy; urgency=low

  * debian/patches/kill-lockfile.patch
    - Backport patch from trunk that removes the lockfile placed by
      duplicity to avoid concurrency. Deja-dup avoid concurrency using
      its own method using Dbus (LP: #1281066)
 -- Louis Bouchard <email address hidden> Mon, 17 Feb 2014 17:19:41 +0100