There is a bug in V2 API AlarmThreahholdRule validate function

[Ildiko Vancsa]

The list of internal_keys is not defined correctly in the validate function of AlarmThresholdRule: timestamp_keys = ['timestamp', 'start', 'start_timestamp' 'end', 'end_timestamp']. The missing comma between the 'start_timestamp' and 'end' results in the following list: timestamp_keys = ['timestamp', 'start', 'start_timestampend', 'end_timestamp'].

The code snippet can be found here: https://github.com/openstack/ceilometer/blob/master/ceilometer/api/controllers/v2.py#L1308

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/74795

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/73805
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=b1834e55fce08f1536c7d9392ae035b9583be8ed
Submitter: Jenkins
Branch: master

commit b1834e55fce08f1536c7d9392ae035b9583be8ed
Author: Ildiko Vancsa <email address hidden>
Date: Sat Feb 15 11:18:19 2014 +0100

    Refactor timestamp existence validation in V2 API

    There was a bug in AlarmThresholdRule in v2.py, the timestamp_keys
    were defined with a missing comma:
    ['timestamp', 'start', 'start_timestamp' 'end', 'end_timestamp'].

    The validation, if the timestamp field is used or not, was unclear
    in the current implementation. A new parameter, 'timestamp_is_valid',
    was added to the validation functions to show, if the timestamp is
    allowed to use or not in the validated query.

    Fixes bug 1280975

    Change-Id: I2aaef54354926f9afe3bb1d4fae8f8aa0ae600ab

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/75058

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/75058
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=2c6a84f17dff2e0eb3970e0f89d8ea3e1d21cde5
Submitter: Jenkins
Branch: stable/havana

commit 2c6a84f17dff2e0eb3970e0f89d8ea3e1d21cde5
Author: Ildiko Vancsa <email address hidden>
Date: Sat Feb 15 11:18:19 2014 +0100

    Refactor timestamp existence validation in V2 API

    There was a bug in AlarmThresholdRule in v2.py, the timestamp_keys
    were defined with a missing comma:
    ['timestamp', 'start', 'start_timestamp' 'end', 'end_timestamp'].

    The validation, if the timestamp field is used or not, was unclear
    in the current implementation. A new parameter, 'timestamp_is_valid',
    was added to the validation functions to show, if the timestamp is
    allowed to use or not in the validated query.

    Fixes bug 1280975

    (cherry picked from commit b1834e55fce08f1536c7d9392ae035b9583be8ed)

    Change-Id: I2aaef54354926f9afe3bb1d4fae8f8aa0ae600ab