xen: agent tests take longer than 15 secs

[Gary Kotton]

gkotton@ubuntu:~/nova$ tox nova.tests.virt.xenapi.test_xenapi
py26 create: /home/gkotton/nova/.tox/py26
ERROR: InterpreterNotFound: python2.6
py27 develop-inst-nodeps: /home/gkotton/nova
py27 runtests: commands[0] | python -m nova.openstack.common.lockutils python setup.py test --slowest --testr-args=nova.tests.virt.xenapi.test_xenapi
[pbr] Excluding argparse: Python 2.6 only dependency
running test
running=OS_STDOUT_CAPTURE=${OS_STDOUT_CAPTURE:-1} \
OS_STDERR_CAPTURE=${OS_STDERR_CAPTURE:-1} \
OS_TEST_TIMEOUT=${OS_TEST_TIMEOUT:-160} \
${PYTHON:-python} -m subunit.run discover -t ./ ./nova/tests --list
running=OS_STDOUT_CAPTURE=${OS_STDOUT_CAPTURE:-1} \
OS_STDERR_CAPTURE=${OS_STDERR_CAPTURE:-1} \
OS_TEST_TIMEOUT=${OS_TEST_TIMEOUT:-160} \
${PYTHON:-python} -m subunit.run discover -t ./ ./nova/tests --load-list /tmp/tmp349WwU
running=OS_STDOUT_CAPTURE=${OS_STDOUT_CAPTURE:-1} \
OS_STDERR_CAPTURE=${OS_STDERR_CAPTURE:-1} \
OS_TEST_TIMEOUT=${OS_TEST_TIMEOUT:-160} \
${PYTHON:-python} -m subunit.run discover -t ./ ./nova/tests --load-list /tmp/tmpccaidD
running=OS_STDOUT_CAPTURE=${OS_STDOUT_CAPTURE:-1} \
OS_STDERR_CAPTURE=${OS_STDERR_CAPTURE:-1} \
OS_TEST_TIMEOUT=${OS_TEST_TIMEOUT:-160} \
${PYTHON:-python} -m subunit.run discover -t ./ ./nova/tests --load-list /tmp/tmpMvMcYb
running=OS_STDOUT_CAPTURE=${OS_STDOUT_CAPTURE:-1} \
OS_STDERR_CAPTURE=${OS_STDERR_CAPTURE:-1} \
OS_TEST_TIMEOUT=${OS_TEST_TIMEOUT:-160} \
${PYTHON:-python} -m subunit.run discover -t ./ ./nova/tests --load-list /tmp/tmpzJ2QHG
Ran 201 (+199) tests in 16.446s (+0.396s)
PASSED (id=350)
Slowest Tests
Test id Runtime (s)
----------------------------------------------------------------------------------------------------------------------- -----------
nova.tests.virt.xenapi.test_xenapi.XenAPIVMTestCase.test_spawn_agent_upgrade_fails_silently 16.223
nova.tests.virt.xenapi.test_xenapi.XenAPIVMTestCase.test_spawn_fails_agent_not_implemented 16.222
nova.tests.virt.xenapi.test_xenapi.XenAPIVMTestCase.test_spawn_fails_with_agent_bad_return 16.034
nova.tests.virt.xenapi.test_xenapi.XenAPIAggregateTestCase.test_add_aggregate_host_raise_err 1.116
nova.tests.virt.xenapi.test_xenapi.XenAPIVMTestCase.test_maintenance_mode 0.297
nova.tests.virt.xenapi.test_xenapi.XenAPIMigrateInstance.test_migrate_disk_and_power_off 0.277
nova.tests.virt.xenapi.test_xenapi.XenAPIVMTestCase.test_spawn_vlanmanager 0.195
nova.tests.virt.xenapi.test_xenapi.XenAPIAggregateTestCase.test_remote_master_non_empty_pool 0.179
nova.tests.virt.xenapi.test_xenapi.XenAPIMigrateInstance.test_migrate_disk_and_power_off_with_zero_gb_old_and_new_works 0.179
nova.tests.virt.xenapi.test_xenapi.XenAPIDom0IptablesFirewallTestCase.test_static_filters 0.171
py33 create: /home/gkotton/nova/.tox/py33
ERROR: InterpreterNotFound: python3.3

[Joe Gordon (jogo)]

Seen in gate too http://logs.openstack.org/70/71270/3/check/gate-nova-python27/a93143f/console.html

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/80247

[Johannes Erdfelt (johannes.erdfelt)]

This particular problem was fixed yesterday:

https://review.openstack.org/#/c/79743/

Sorry, I didn't see this bug open or I would have grabbed it.

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/80247
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6def27b434a53aa8c1aca62640a6c072cc21209e
Submitter: Jenkins
Branch: master

commit 6def27b434a53aa8c1aca62640a6c072cc21209e
Author: John Garbutt <email address hidden>
Date: Thu Mar 13 10:58:58 2014 +0000

    xenapi: fixup agent tests

    The root cause of the slow agent tests was not mocking this method:
    compute_utils.add_instance_fault_from_exc

    This cleans up the tests to share a bit more code, and ensures they
    actually check that the appropriate exception is raised.

    This change adds a log message to report errors that could occur in
    running systems that also helped identify this issue in the unit tests.

    test_spawn_fails_agent_not_implemented was a duplicate test and has been
    removed.

    Change-Id: I6fd31520fffd5e888ce0c2b58af2715f0d929ce1
    Closes-Bug: #1279317