Empty, focusable <a> tags when no staff or admins shown in institution list

Bug #1278668 reported by Jono M
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Jono M

Bug Description

In the list of institutions (Admin -> Institutions), "No Institution" does not display a number of staff or administrators, so those cells appear blank. However, they contain an empty <a> element which can be focused using the keyboard and gives an error if pressed.
The page needs to be changed so that the column is genuinely blank if the number of staff/admin users in an institution is not set.

Affects latest master

Revision history for this message
Jono M (jonom) wrote :

(Noticed first by Evonne)

tags: added: accessibility
Jono M (jonom)
Changed in mahara:
importance: Undecided → Low
Jono M (jonom)
Changed in mahara:
assignee: nobody → Jono Mingard (mingard)
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3046

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3046
Committed: http://gitorious.org/mahara/mahara/commit/7216ff49629dccd49a9d3b4e9d16a51cfa1213cd
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 7216ff49629dccd49a9d3b4e9d16a51cfa1213cd
Author: Jono Mingard <email address hidden>
Date: Wed Feb 26 13:00:56 2014 +1300

Remove empty links in institutions list (Bug #1278668)

Also removed link to institution page for "No institution" (ie. the institution
title is no longer a link) since it can never have institution staff
or admins.

Also fixed up the max users count to not display count = 0

Change-Id: I667ef41431f59b5036ed82d277b683a161bc6045
Signed-off-by: Jono Mingard <email address hidden>

Son Nguyen (ngson2000)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.