Cannot alias console packages on RHEL

[Emilien Macchi]

When declaring both nova::consoleauth & nova::spicehtml5proxy together on the same node with Red Hat:

Puppet::Parser::AST::Resource failed with error ArgumentError: Cannot alias Package[nova-spicehtml5proxy] to ["openstack-nova-console"] at /home/emilien/Git/eNovance/puppet-cloud/spec/fixtures/modules/nova/manifests/generic_service.pp:44; resource ["Package", "openstack-nova-console"] already declared at /home/emilien/Git/eNovance/puppet-cloud/spec/fixtures/modules/nova/manifests/generic_service.pp:44 at /home/emilien/Git/eNovance/puppet-cloud/spec/fixtures/modules/nova/manifests/generic_service.pp:44 on node xps.enovance.com

The problem is in params.pp for Red Hat:
      $consoleauth_package_name = 'openstack-nova-console'
      $spicehtml5proxy_package_name = 'openstack-nova-console'

It's impossible to make an alias twice for openstack-nova-console.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/72449

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/87338

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/87357

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/72449
Committed: https://git.openstack.org/cgit/stackforge/puppet-nova/commit/?id=31a282a883ca8d2450195829d4e995ece699a6a7
Submitter: Jenkins
Branch: master

commit 31a282a883ca8d2450195829d4e995ece699a6a7
Author: Sebastien Badia <email address hidden>
Date: Mon Feb 10 19:47:37 2014 +0100

    Fix consoleauth/spice duplicates on RH (#1278452)

    On RedHat, consoleauth and spicehtml5proxy packages has the same name
    (« openstack-nova-console »), so we have a duplicate resource (see: #1278452).
    In this context we can't use ensure_package of stdlib because we loose
    notify/names attributes.)

    Closes-bug: #1278452

    Change-Id: I0141ca0233aead072a06796759d211cf1b6dc657

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/87357
Committed: https://git.openstack.org/cgit/stackforge/puppet-nova/commit/?id=b7811392062b649572f470f5f3ddca1882997210
Submitter: Jenkins
Branch: stable/havana

commit b7811392062b649572f470f5f3ddca1882997210
Author: Sebastien Badia <email address hidden>
Date: Mon Feb 10 19:47:37 2014 +0100

    Fix consoleauth/spice duplicates on RH (#1278452)

    On RedHat, consoleauth and spicehtml5proxy packages has the same name
    (« openstack-nova-console »), so we have a duplicate resource (see: #1278452).
    In this context we can't use ensure_package of stdlib because we loose
    notify/names attributes.)

    Closes-bug: #1278452

    Change-Id: I0141ca0233aead072a06796759d211cf1b6dc657
    (cherry picked from commit 31a282a883ca8d2450195829d4e995ece699a6a7)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/87338
Committed: https://git.openstack.org/cgit/stackforge/puppet-nova/commit/?id=20b2d79570d60e4ab24ba3a583741048fa47775e
Submitter: Jenkins
Branch: master

commit 20b2d79570d60e4ab24ba3a583741048fa47775e
Author: Mathieu Gagné <email address hidden>
Date: Mon Apr 14 13:35:27 2014 -0400

    Test bug #1278452 with real node definitions

    This test makes sure the bug #1278452 is fixed by reproducing
    the actual use case where both nova::consoleauth and
    nova::spicehtml5proxy are defined on the same node.

    Change-Id: Idcd3d3722cd834bdafea1cf39e1deaf4213fb9a9
    Related-bug: #1278452