segfault if image file is missed
Bug #1274516 reported by
Sergey Alyoshin
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
gEDA |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
If image file added in schematic with Add / Picture is missed, then gschem
produce segfault then loading such schematic.
gschem version gEDA 1.9.0 (gc095834)
Changed in geda: | |
status: | New → Confirmed |
Changed in geda: | |
status: | Confirmed → Fix Committed |
Changed in geda: | |
milestone: | none → 1.9.1 |
Changed in geda: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hi Vladimir,
Why did you decide to fix the crash in this way? Neither the commit message nor the patch itself is very illuminating.
I actually disagree with your justification in the patch that "Decision of what to do with any files is not in the competence of
edarenderer." Working out what to do if an image can't be loaded and/or displayed isn't really in the competence of libgeda *or* libgedacairo - ideally, it should be decided by the application that's using the renderer (for example, it might want to supply a different fallback image depending on the current icon theme it's using).
I suppose I'd better file another bug about this.
Thanks,
Peter