Paginator on /admin/users/search.php doesn't respect institution setting

[Kristina Hoeppner]

Mahara 1.8

When you are on /admin/users/search.php and have at least one institution set up besides "No institution" and have more than 10 users in the institution, the paginator does not respect the chosen institution when you click on the next page / any other page.

It reverts back to showing all results no matter whether they are institution members or not.

This might be a regression because I think it worked in an earlier version of Mahara. It usually only affects site admins or institution admins who are admins in more than one institution.

Test scenario:

1. Set up 1 institution besides "No institution".
2. Add 30 users to that institution.
3. Add 20 users to "No institution".
4. Limit the user search on /admin/users/search.php to the institution that you created. If you have lots of users with the same name (at least 11), you can limit further by that name.
5. Click on a number in the paginator. Expected: You still only see results from your institution. Actual: You see all users from the institution.

[Kristina Hoeppner (kris-hoeppner)]

This might be a duplicate of https://bugs.launchpad.net/mahara/+bug/1271935 Haven't marked it as duplicate yet, just in case it turns out to be different during testing.

[Tobias Zeuch (tobias-zeuch-8)]

It's not a duplicate of the above bug but it's related. I'll submit a patch. Not sure though if that did ever work

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/2965

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/2965
Committed: http://gitorious.org/mahara/mahara/commit/c519e1c7d46b5206004c76864fb77bbf70625213
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c519e1c7d46b5206004c76864fb77bbf70625213
Author: Tobias Zeuch <email address hidden>
Date: Mon Jan 27 13:47:45 2014 +0100

Paginator on /admin/users/search.php doesn't respect institution setting

Bug 1272121: adding institution to list of wantedparams so that this
parameter is carried to the pagination

Change-Id: Ib3058ca3fdaf6893b48600758cc50bf591d29e70
Signed-off-by: Tobias Zeuch <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "1.7_STABLE" branch: https://reviews.mahara.org/3273

[Mahara Bot (dev-mahara)]

Patch for "1.8_STABLE" branch: https://reviews.mahara.org/3274

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/3273
Committed: http://gitorious.org/mahara/mahara/commit/ab8c4639ca8f91125a6d2853525068bf2e2a19b5
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.7_STABLE

commit ab8c4639ca8f91125a6d2853525068bf2e2a19b5
Author: Tobias Zeuch <email address hidden>
Date: Mon Jan 27 13:47:45 2014 +0100

Paginator on /admin/users/search.php doesn't respect institution setting

Bug 1272121: adding institution to list of wantedparams so that this
parameter is carried to the pagination

Change-Id: Ib3058ca3fdaf6893b48600758cc50bf591d29e70
Signed-off-by: Tobias Zeuch <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/3274
Committed: http://gitorious.org/mahara/mahara/commit/8173b9a177fb8d29691e69fe792b86c6871b9085
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.8_STABLE

commit 8173b9a177fb8d29691e69fe792b86c6871b9085
Author: Tobias Zeuch <email address hidden>
Date: Mon Jan 27 13:47:45 2014 +0100

Paginator on /admin/users/search.php doesn't respect institution setting

Bug 1272121: adding institution to list of wantedparams so that this
parameter is carried to the pagination

Change-Id: Ib3058ca3fdaf6893b48600758cc50bf591d29e70
Signed-off-by: Tobias Zeuch <email address hidden>