focus on help box close button in chromium has gap

Bug #1271392 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Robert Lyon

Bug Description

There is a gap at bottom of close button and the focus outline in chromium - see the attached image

The problem is the <a> tag 'sits' lower than the <img> tag and so gives the gap.

It needs to have vertical-align: top set on the <a> tag so both the <a> and <img> are aligned at top

Revision history for this message
Robert Lyon (robertl-9) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/2949

Robert Lyon (robertl-9)
Changed in mahara:
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2949
Committed: http://gitorious.org/mahara/mahara/commit/3255f24d3321106c58fae7af0b7aa760a38231bf
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3255f24d3321106c58fae7af0b7aa760a38231bf
Author: Robert Lyon <email address hidden>
Date: Wed Jan 22 15:12:09 2014 +1300

Closing gap on focused help close button in chromium (bug #1271392)

Change-Id: I9ef5acca0160db32899640c7d55d26f6920b802e
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.