[webapp-container] Grey bar that would hold a title visible on any click webapp

Bug #1270848 reported by Dave Morley
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu UI Toolkit
Invalid
Undecided
Unassigned
webbrowser-app
Fix Released
Critical
Olivier Tilloy
webbrowser-app (Ubuntu)
Fix Released
Undecided
Olivier Tilloy

Bug Description

The core webapps use the browser with a strict config to make them work so they seem fine. However webapps in the click store all show the issue.

Issue:
If you open a web app you get the following
http://popey.com/~alan/phablet/device-2014-01-20-143139.png

Note the big grey box at the top of the app.

Tags: maguro mako r138

Related branches

Dave Morley (davmor2)
Changed in webbrowser-app:
assignee: nobody → Olivier Tilloy (osomon)
tags: added: maguro mako
Oliver Grawert (ogra)
Changed in webbrowser-app:
status: New → Confirmed
Revision history for this message
Olivier Tilloy (osomon) wrote :

I’m seeing the problem on the amazon webapp too, which is a core webapp, so I don’t think the problem is exclusive to click webapps.

Revision history for this message
Olivier Tilloy (osomon) wrote :

The grey box at the top seems to be exactly the size of the MainView’s header component if it was displayed.
According to the documentation, the header is shown only if the Page inside the MainView has a title. The webapp container has a Page inside the MainView, but no title set on it.

Revision history for this message
Dave Morley (davmor2) wrote :

Yeah I was looking at facebook/twitter and google plus which all have the modded config. I forgot that amazon was using webapps correctly

Revision history for this message
Olivier Tilloy (osomon) wrote :

Setting the importance to Critical as that’s blocking image promotion.

Changed in webbrowser-app:
importance: Undecided → Critical
status: Confirmed → In Progress
Revision history for this message
Olivier Tilloy (osomon) wrote :

From a discussion with Tim from the UITK team on IRC:

 <timp> oSoMoN: is that using a MainView/Page? there were some changes there recently.
      oSoMoN: so see if it works well with the latest trunk version of UITK
      oSoMoN: otherwise it might be a bug in the Page trying to keep space free for the header
 <oSoMoN> timp, yes, that’s using MainView and page
 <timp> oSoMoN: if title is set to "", in uitk trunk, header should hide. if not, its a bug in uitk. If you want to report that as a UITK bug try to reproduce it in a simple app

I haven’t isolated the bug in a simple app yet, but it looks very much like a bug in the UITK to me, reserving space for a header component where it’s not needed.

Revision history for this message
Olivier Tilloy (osomon) wrote :

Interestingly, it looks like the problem is with the MainView/Page combination. If I replace the Page element with a simple Item (the webapps container doesn’t use any particular feature of the Page) then the problem seems to go away.

Olivier Tilloy (osomon)
summary: - [webapp-container] Grey bar that would hold a title vissible on any
- click webapp
+ [webapp-container] Grey bar that would hold a title visible on any click
+ webapp
Revision history for this message
Olivier Tilloy (osomon) wrote :

I’m attaching a simple QML example that shows the problem. By having a Flickable inside a Page inside a MainView, and ensuring that the contentHeight of the Flickable is greater than the MainView’s height, the Page always reserves empty space for a header component.

Revision history for this message
Olivier Tilloy (osomon) wrote :

And btw, this is also observable on desktop, no need to run this example on a device.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:webbrowser-app at revision 439, scheduled for release in webbrowser-app, milestone ubuntu-13.04-month-5

Changed in webbrowser-app:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+14.04.20140120-0ubuntu1

---------------
webbrowser-app (0.23+14.04.20140120-0ubuntu1) trusty; urgency=low

  [ Olivier Tilloy ]
  * Work around a bug (regression?) in the UITK by replacing the use of
    Page by a simple Item. (LP: #1270848)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 439
 -- Ubuntu daily release <email address hidden> Mon, 20 Jan 2014 16:38:10 +0000

Changed in webbrowser-app (Ubuntu):
status: New → Fix Released
Olivier Tilloy (osomon)
Changed in webbrowser-app:
status: Fix Committed → Fix Released
Changed in webbrowser-app (Ubuntu):
assignee: nobody → Olivier Tilloy (osomon)
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.