Right-clicks in column view open items
Bug #1270566 reported by
José M. Benítez
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Files |
Fix Released
|
Medium
|
Jeremy Wootten | ||
Bug Description
Right-clicks in column view behave as expected, but they also open elements. I don't know if that's desired behaviour and I guess it doesn't matter too much when right-clicking on directories, but I don't think it's right with regular files. Maybe the user just wants to check the size or change some property: that doesn't mean the file needs to be open.
Related branches
lp:~jeremywootten/pantheon-files/all-views-vala
- PerfectCarl (community): Approve
- Danielle Foré: Approve (ux)
- Jeremy Wootten: Pending requested
- Cody Garver: Pending requested
-
Diff: 49548 lines (+17157/-29587)96 files modified.bzrignore (+1/-1)
AUTHORS (+2/-0)
CMakeLists.txt (+1/-1)
data/schemas/org.pantheon.files.gschema.xml (+2/-2)
libcore/AbstractSlot.vala (+76/-0)
libcore/CMakeLists.txt (+3/-2)
libcore/Plugin.vala (+1/-1)
libcore/PluginManager.vala (+1/-1)
libcore/eel-stock-dialogs.c (+0/-3)
libcore/fm-list-model.c (+60/-139)
libcore/fm-list-model.h (+3/-9)
libcore/gof-abstract-slot.c (+0/-47)
libcore/gof-abstract-slot.h (+0/-56)
libcore/gof-directory-async.vala (+45/-23)
libcore/gof-file.c (+46/-26)
libcore/gof-file.h (+4/-3)
libcore/marlin-file-changes-queue.c (+0/-3)
libcore/marlin-file-operations.c (+6/-10)
libcore/marlin-icon-info.c (+9/-5)
libcore/pantheon-files-core-C.vapi (+86/-16)
libwidgets/Animations.vala (+12/-3)
libwidgets/BreadcrumbsElements.vala (+1/-1)
libwidgets/LocationBar.vala (+15/-13)
plugins/network-places/plugin.vala (+12/-7)
plugins/pantheon-files-ctags/plugin.vala (+183/-55)
plugins/pantheon-files-trash/plugin.vala (+19/-15)
src/AbstractEditableLabel.vala (+96/-0)
src/Application.vala (+47/-76)
src/BookmarkList.vala (+5/-0)
src/CMakeLists.txt (+26/-20)
src/DndHandler.vala (+272/-0)
src/MimeActions.vala (+19/-11)
src/MultiLineEditableLabel.vala (+196/-0)
src/SingleLineEditableLabel.vala (+104/-0)
src/TextRenderer.vala (+307/-0)
src/View/AbstractDirectoryView.vala (+2778/-0)
src/View/AbstractTreeView.vala (+280/-0)
src/View/Browser.vala (+3/-18)
src/View/Chrome/ColorWidget.vala (+0/-183)
src/View/Chrome/TopMenu.vala (+81/-35)
src/View/Chrome/ViewSwicher.vala (+36/-27)
src/View/ColumnView.vala (+140/-0)
src/View/DbusTags.vala (+0/-100)
src/View/DirectoryNotFound.vala (+1/-1)
src/View/IconView.vala (+318/-0)
src/View/ListView.vala (+235/-0)
src/View/LocationBar.vala (+27/-44)
src/View/Miller.vala (+396/-0)
src/View/OverlayBar.vala (+58/-53)
src/View/PropertiesWindow.vala (+5/-4)
src/View/Resources.vala (+4/-1)
src/View/Sidebar.vala (+44/-40)
src/View/Slot.vala (+276/-0)
src/View/ViewContainer.vala (+246/-296)
src/View/ViewMode.vala (+0/-17)
src/View/Window.vala (+614/-604)
src/View/directory_view_popup.ui (+138/-0)
src/eel-editable-label.c (+0/-4417)
src/eel-editable-label.h (+0/-146)
src/exo-icon-view.c (+0/-11753)
src/exo-icon-view.h (+0/-347)
src/exo-tree-view.c (+0/-674)
src/exo-tree-view.h (+0/-91)
src/fm-abstract-icon-view.c (+0/-870)
src/fm-abstract-icon-view.h (+0/-60)
src/fm-columns-view.c (+0/-858)
src/fm-columns-view.h (+0/-60)
src/fm-directory-view-ui.xml (+0/-194)
src/fm-directory-view.c (+0/-4059)
src/fm-directory-view.h (+0/-446)
src/fm-icon-view-ui.xml (+0/-37)
src/fm-icon-view.c (+0/-147)
src/fm-icon-view.h (+0/-51)
src/fm-list-view.c (+0/-999)
src/fm-list-view.h (+0/-60)
src/gof-window-slot.c (+0/-315)
src/gof-window-slot.h (+0/-88)
src/gtk+-3.0.deps (+7/-0)
src/gtk+-3.0.vapi (+9698/-0)
src/main.vala (+1/-0)
src/marlin-cell-renderer-text-ellipsized.c (+0/-73)
src/marlin-cell-renderer-text-ellipsized.h (+0/-58)
src/marlin-clipboard-manager.c (+10/-0)
src/marlin-clipboard-manager.h (+3/-0)
src/marlin-dnd.c (+0/-230)
src/marlin-dnd.h (+0/-43)
src/marlin-enum-types.h (+2/-4)
src/marlin-global-preferences.h (+1/-0)
src/marlin-icon-renderer.c (+13/-4)
src/marlin-text-renderer.c (+0/-869)
src/marlin-text-renderer.h (+0/-76)
src/marlin-view-window.h (+25/-13)
src/marlin-window-columns.c (+0/-310)
src/marlin-window-columns.h (+0/-84)
src/marlin.vapi (+57/-104)
src/pantheon-files-ui.xml (+0/-75)
Revision history for this message
| José M. Benítez (jmiguelbenitez) wrote | #1 |
| Changed in pantheon-files: | |
| assignee: | nobody → Jeremy Wootten (jeremywootten) |
| Changed in pantheon-files: | |
| milestone: | none → isis-beta1 |
| importance: | Undecided → Medium |
Revision history for this message
| Sergey "Shnatsel" Davidoff (shnatsel) wrote | #2 |
Revision history for this message
| Jeremy Wootten (jeremywootten) wrote Re: [Bug 1270566] Re: Right-clicks in column view open items | #3 |
| Changed in pantheon-files: | |
| milestone: | isis-beta1 → isis-beta2 |
| Changed in pantheon-files: | |
| status: | New → In Progress |
| Changed in pantheon-files: | |
| milestone: | freya-beta2 → none |
Revision history for this message
| Jeremy Wootten (jeremywootten) wrote | #4 |
Revision history for this message
| PerfectCarl (name-is-carl) wrote | #5 |
| Changed in pantheon-files: | |
| status: | In Progress → Fix Committed |
| milestone: | none → freya-beta2 |
| Changed in pantheon-files: | |
| status: | Fix Committed → Fix Released |
| Changed in pantheon-files: | |
| milestone: | freya-beta2 → 0.2 |
To post a comment you must log in.
Well, the file thing is not there yet, but it'll happen when bug #1082680 is solved :P