Passthrough overlay image for waveform summary and overview

[RJ Skerry-Ryan]

Maybe once Bug #1180872 is solved the overview and summary will support a "disabled" pixmap so we could draw something on the waveform that says "PASSTHROUGH ENABLED" or something like that.

We could also do this with skin XML to hide the waveform, spinny, and overview and replace it with label widgets or something else (a BIG vu meter?).

[jus (jus)]

I`m not sure anymore if disabling summary and overview is really the best way to do it. You would have to eject a playing track eventually and whatnot.

E.g. in another soft they just display an text overlay on the affected deck and mute the internal playback. This is pretty nice if you running short on decks (think 2-deck setup) because you can always see whats going on the deck, switch back to internal playback at exact position, and even load tracks to a deck with passthrough enabled.

[Daniel Schürmann (daschuer)]

Nice Idea! +1

[RJ Skerry-Ryan (rryan)]

Ah, I like that too. Currently the EngineBuffer doesn't get processed if passthrough is enabled but if we did that then the deck would still work. So we should add a passthrough overlay pixmap to the summary and overview that is drawn on top when passthrough is enabled.

[jus (jus)]

Drawing the overlays blocks clicking on the waveform widgets, right?
Any way around this?

[RJ Skerry-Ryan (rryan)]

The implementation I'm imagining would not block mouse input to the widget -- it would just draw the overlay on top (not like the BPM tap button blocking mouse input to the WLabel below it).

[Daniel Schürmann (daschuer)]

We currently have non blocking "Overlay" text: "Loading track .."
https://github.com/mixxxdj/mixxx/blob/master/src/widget/woverview.cpp#L330

We can do is similar for "Passthough enabled"

[Jan Holthuis (holthuis-jan)]

Actually, it would be even cooler to have a live waveform overview for the audio that is passed through (like the waveform you get when recording audio in Audacity: https://youtu.be/vs92BVVL6V4?t=59).
In that case, the waveform of the loaded track would not be displayed at all, so that #1567645 would be fixed by this as well.

[ronso0 (ronso0)]

https://github.com/mixxxdj/mixxx/pull/2575
Show "passthrough" on Waveform Overviews if enabled

[ronso0 (ronso0)]

building on top of #2575 I'll change the 'Passthrough' overlay to a QLabel that can be styled independently from other overview texts (Loading, Analyzing ...).
Hope it's easy to make that translucent, stack it on top of the overview and allow mouse events on the overview. This would suffice the 'short on decks' usecase, wouldn't it?

When someone manages to implement a live overview other features like live recording and then manipulating the recording are obvious, like lp:1407222, and we can add a Deck / Live switch that swaps Deck / Live overview & controls.

[ronso0 (ronso0)]

fixed.

Live waveform covered by lp:1882812

[ronso0 (ronso0)]

overlay for waveform:
https://github.com/mixxxdj/mixxx/pull/4794

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7264