[emulator/rilmodem] Crash reading EFmsisdn file
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ofono (Ubuntu) |
Fix Released
|
Critical
|
Tony Espy |
Bug Description
While working on the testing ofono using the touch emulator, I ran into an ofono crash while trying to read the EFmsisdn file.
The crash occurs using a package build from the following branch:
https:/
Note, you need to manually power on the modem for the crash to occur using the ofono-script 'online-modem'.
The actual crash is in the core ofono function sim_adn_parse() in smsutil.c. The crash is caused because RIL returns the following a response with a NULL third parameter, and the grilreply code doesn't handle this explicitly, so the reply member hex_respponse isn't set, and thus is returned as garbage to the core code:
[0024]> RIL_REQUEST_SIM_IO (cmd=0xC0,
[0024]< RIL_REQUEST_SIM_IO (sw1=0x67,
Related branches
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ricardo Salveti: Pending requested
-
Diff: 280 lines (+150/-19)7 files modifieddebian/changelog (+15/-1)
drivers/rilmodem/sim.c (+6/-1)
drivers/rilmodem/voicecall.c (+22/-7)
gril/grilreply.c (+12/-9)
plugins/ril.c (+5/-0)
src/smsutil.c (+1/-1)
unit/test-grilreply.c (+89/-0)
Changed in ofono (Ubuntu): | |
status: | New → In Progress |
assignee: | nobody → Tony Espy (awe) |
importance: | Undecided → Critical |
Pull requested created:
https:/ /github. com/rilmodem/ ofono/pull/ 44