recursive_keypairs doesn't throw 'separator' param to next iteration

[Nadya Privalova]

recursive_keypairs doesn't throw 'separator' param to next iteration. So that's why representation of dictionaries are not get user-expected.

[gordon chung (chungg)]

i think they should be fixed. for the most part, recursive_keypairs() was used only to change how data was displayed (except for Sample post)...question is how many people use Sample post.... also, if we flatten metadata incorrectly as such, how is mongodb storing this? is it broken ie. the context of depth is gone?

i know previously i was asked why the metadata showed as a.b:c:d:.. it just doesn't look nice.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/67704

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/67704
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=fb32c3b19c283d9d4cf78af35d33bd12f16452cf
Submitter: Jenkins
Branch: master

commit fb32c3b19c283d9d4cf78af35d33bd12f16452cf
Author: Nadya Privalova <email address hidden>
Date: Sun Jan 19 12:45:56 2014 +0400

    Fix recursive_keypairs output

    recursive_keypairs has 'separator' argument. This method is recursive
    and a problem is that 'separator' argument is applied only in first
    iteration of the method.

    Besides, this method is used in flatten_metadata in API implementation.
    That's why it is needed not to change output from recursive_keypairs in flatten_metadata.

    So the path has a goal to fix incorrect recursive_keypairs impementation but
    not to change output of flatten_matadata in API

    Fixes bug 1268628

    Change-Id: Ic9829342c47325c1df7b81dc4148c08a13e0d067