Cinder

remove unused variables

Bug #1268062 reported by Wu Wenxiang on 2014-01-11

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Cinder	Fix Released	Wishlist	Mike Mason	Cinder 2015.1.0 "kilo"

Bug Description

************* Module cinder.api.contrib.volume_actions
W:278,12: Unused variable '_val' (unused-variable)
--
************* Module cinder.api.extensions
W:152,12: Unused variable '_alias' (unused-variable)
--
************* Module cinder.api.middleware.auth
W:144,17: Unused variable '_sep' (unused-variable)
--
************* Module cinder.api.openstack.wsgi
W:601,12: Unused variable '_mtype' (unused-variable)
--
************* Module cinder.backup.drivers.ceph
W:441, 8: Unused variable 'stdout' (unused-variable)
--
************* Module cinder.backup.drivers.swift
W:222, 9: Unused variable 'resp' (unused-variable)
W:372,17: Unused variable 'resp' (unused-variable)
--
************* Module cinder.backup.drivers.tsm
W:205,33: Unused variable 'e' (unused-variable)
--
************* Module cinder.brick.exception
W: 52,16: Unused variable 'exc_info' (unused-variable)
--
************* Module cinder.brick.initiator.connector
W:135, 8: Unused variable 'out' (unused-variable)
W:301,19: Unused variable '_err' (unused-variable)
--
************* Module cinder.brick.initiator.linuxfc
W: 42,17: Unused variable 'err' (unused-variable)
--
************* Module cinder.brick.initiator.linuxscsi
W: 62,14: Unused variable 'err' (unused-variable)
W:120,18: Unused variable 'err' (unused-variable)
--
************* Module cinder.brick.iscsi.iscsi
W:104,14: Unused variable 'err' (unused-variable)
W:119,14: Unused variable 'err' (unused-variable)
W:457,14: Unused variable 'err' (unused-variable)
W:540, 9: Unused variable 'auth_method' (unused-variable)
--
************* Module cinder.brick.local_dev.lvm
W:104,14: Unused variable 'err' (unused-variable)
W:120,14: Unused variable 'err' (unused-variable)
W:174,14: Unused variable 'err' (unused-variable)
W:230,14: Unused variable 'err' (unused-variable)
W:260,14: Unused variable 'err' (unused-variable)
W:312,14: Unused variable 'err' (unused-variable)
W:357,14: Unused variable 'err' (unused-variable)
W:604,13: Unused variable 'err' (unused-variable)
--
************* Module cinder.brick.remotefs.remotefs
W: 70,14: Unused variable 'err' (unused-variable)
--
************* Module cinder.common.config
W: 51,15: Unused variable 'port' (unused-variable)
--
************* Module cinder.common.sqlalchemyutils
W: 76,34: Unused variable '_sort_key' (unused-variable)
--
************* Module cinder.db.sqlalchemy.api
W:201,14: Unused variable 'gigs' (unused-variable)
W:211,16: Unused variable 'gigs' (unused-variable)
W:221, 5: Unused variable '_junk' (unused-variable)
W:1635,57: Unused variable 'e' (unused-variable)
W:1930,61: Unused variable 'e' (unused-variable)
W:2204,52: Unused variable 'e' (unused-variable)
W:2657,12: Unused variable 'volume_status' (unused-variable)
--
************* Module cinder.db.sqlalchemy.migrate_repo.versions.003_glance_metadata
W: 30, 4: Unused variable 'volumes' (unused-variable)
W: 35, 4: Unused variable 'snapshots' (unused-variable)
--
************* Module cinder.db.sqlalchemy.migrate_repo.versions.009_add_snapshot_metadata_table
W: 25, 4: Unused variable 'snapshots' (unused-variable)
--
************* Module cinder.db.sqlalchemy.migrate_repo.versions.010_add_transfers_table
W: 25, 4: Unused variable 'volumes' (unused-variable)
--
************* Module cinder.db.sqlalchemy.migrate_repo.versions.020_add_volume_admin_metadata_table
W: 25, 4: Unused variable '_volumes' (unused-variable)
--
************* Module cinder.image.glance
W:440, 4: Unused variable 'exc_type' (unused-variable)
W:447, 4: Unused variable 'exc_type' (unused-variable)
--
************* Module cinder.image.image_utils
W: 58, 9: Unused variable 'err' (unused-variable)
W:298, 9: Unused variable 'err' (unused-variable)
--
************* Module cinder.openstack.common.db.sqlalchemy.utils
W: 82,34: Unused variable '_sort_key' (unused-variable)
--
************* Module cinder.openstack.common.importutils
W: 28,13: Unused variable '_sep' (unused-variable)
--
************* Module logging
W:512,13: Unused variable '_sep' (unused-variable)
--
************* Module cinder.openstack.common.rootwrap.filters
W:107, 8: Unused variable 'command' (unused-variable)
--
************* Module cinder.openstack.common.rpc.matchmaker
W:160,32: Unused variable 'bit' (unused-variable)
--
************* Module cinder.openstack.common.timeutils
W:135,12: Unused variable 'dt' (unused-variable)
--
************* Module cinder.scheduler.simple
W: 48, 8: Unused variable 'image_id' (unused-variable)
W: 47, 8: Unused variable 'snapshot_id' (unused-variable)
W: 46, 8: Unused variable 'volume_id' (unused-variable)
W: 56,18: Unused variable '_x' (unused-variable)
--
************* Module cinder.tests.api.contrib.test_admin_actions
W:691, 8: Unused variable 'volume' (unused-variable)
W:707, 8: Unused variable 'volume' (unused-variable)
--
************* Module cinder.tests.api.contrib.test_extended_snapshot_attributes
W: 95,12: Unused variable 'i' (unused-variable)
--
************* Module cinder.tests.api.contrib.test_used_limits
W: 51,12: Unused variable 'display_name' (unused-variable)
--
************* Module cinder.tests.api.contrib.test_volume_actions
W:322,12: Unused variable 'name' (unused-variable)
--
************* Module cinder.tests.api.fakes
W: 87, 4: Unused variable 'fake_rate_init' (unused-variable)
W:103, 4: Unused variable 'one_key_pair' (unused-variable)
W:100, 4: Unused variable 'key_pair' (unused-variable)
W:109, 4: Unused variable 'no_key_pair' (unused-variable)
--
************* Module cinder.tests.api.middleware.test_sizelimit
W: 54,12: Unused variable 'bytes_read' (unused-variable)
W: 63,12: Unused variable 'bytes_read' (unused-variable)
--
************* Module cinder.tests.api.openstack.test_wsgi
W:277,16: Unused variable 'extensions' (unused-variable)
W:300,16: Unused variable 'extensions' (unused-variable)
W:313,16: Unused variable 'extensions' (unused-variable)
W:348,16: Unused variable 'extensions' (unused-variable)
W:644,12: Unused variable 'resp_obj' (unused-variable)
W:649,12: Unused variable 'resp_obj' (unused-variable)
W:749,12: Unused variable 'resp_obj' (unused-variable)
W:753,12: Unused variable 'resp_obj' (unused-variable)
W:778,12: Unused variable 'resp_obj' (unused-variable)
W:782,12: Unused variable 'resp_obj' (unused-variable)
W:852,12: Unused variable '_mtype' (unused-variable)
W:861,12: Unused variable '_mtype' (unused-variable)
W:907, 8: Unused variable 'resource' (unused-variable)
W:911, 8: Unused variable 'resource' (unused-variable)
W:915, 8: Unused variable 'resource' (unused-variable)
W:920, 8: Unused variable 'resource' (unused-variable)
--
************* Module cinder.tests.api.v1.test_limits
W:405,12: Unused variable 'x' (unused-variable)
W:600, 8: Unused variable 'requests' (unused-variable)
--
************* Module cinder.tests.api.v1.test_volumes
W:121, 8: Unused variable 'volume_id' (unused-variable)
--
************* Module cinder.tests.api.v2.test_limits
W:410,12: Unused variable 'x' (unused-variable)
--
************* Module cinder.tests.brick.test_brick_connector
W:518, 8: Unused variable 'aoe_device' (unused-variable)
W:525,12: Unused variable 'i' (unused-variable)
--
************* Module cinder.tests.brick.test_brick_linuxscsi
W:104, 8: Unused variable 'fake_execute2' (unused-variable)
--
************* Module cinder.tests.compute.test_nova
W: 45, 8: Unused variable 'volume_id' (unused-variable)
--
************* Module cinder.tests.image.fake
W:232, 4: Unused variable 'fake_get_remote_image_service' (unused-variable)
--
************* Module cinder.tests.image.test_glance
W:526, 9: Unused variable 'service' (unused-variable)
--
************* Module cinder.tests.scheduler.test_scheduler_options
W: 74, 8: Unused variable 'data' (unused-variable)
--
************* Module cinder.tests.test_backup
W:368, 8: Unused variable 'b1' (unused-variable)
--
************* Module cinder.tests.test_backup_ceph
W:111,12: Unused variable 'i' (unused-variable)
W:242,16: Unused variable 'c' (unused-variable)
W:310,16: Unused variable 'c' (unused-variable)
W:443,16: Unused variable 'c' (unused-variable)
W:572, 8: Unused variable 'del_base_image' (unused-variable)
W:583, 8: Unused variable 'del_base_image' (unused-variable)
--
************* Module cinder.tests.test_backup_swift
W: 74,12: Unused variable 'i' (unused-variable)
--
************* Module cinder.tests.test_backup_tsm
W:112,21: Unused variable 'backup' (unused-variable)
--
************* Module cinder.tests.test_conf
W: 50, 8: Unused variable 'cinder' (unused-variable)
--
************* Module cinder.tests.test_db_api
W: 40, 4: Unused variable 'get_sync' (unused-variable)
W:153, 8: Unused variable 'service2' (unused-variable)
W:163, 8: Unused variable 'service2' (unused-variable)
W:301,16: Unused variable 'j' (unused-variable)
W:378,32: Unused variable 'j' (unused-variable)
W:392,32: Unused variable 'j' (unused-variable)
W:406,46: Unused variable 'j' (unused-variable)
W:414, 8: Unused variable 'target' (unused-variable)
W:477, 8: Unused variable 'snapshot' (unused-variable)
W:725, 8: Unused variable 'reservations' (unused-variable)
W:771, 8: Unused variable 'sample1' (unused-variable)
W:772, 8: Unused variable 'sample2' (unused-variable)
W:784, 8: Unused variable 'sample1' (unused-variable)
W:785, 8: Unused variable 'sample2' (unused-variable)
W:878, 8: Unused variable 'reservations' (unused-variable)
W:886, 8: Unused variable 'reservations' (unused-variable)
--
************* Module cinder.tests.test_emc
W:689, 8: Unused variable 'connection_info' (unused-variable)
--
************* Module cinder.tests.test_glusterfs
W:727, 8: Unused variable 'snap_filename' (unused-variable)
W:742, 8: Unused variable 'qemu_img_info_output' (unused-variable)
W:790, 8: Unused variable 'snap_path' (unused-variable)
W:826, 8: Unused variable 'snap_path_2_chain' (unused-variable)
W:830, 8: Unused variable 'snap_path_chain' (unused-variable)
W:885, 8: Unused variable 'qemu_img_info_output_snap_2' (unused-variable)
W:901, 8: Unused variable 'qemu_img_info_output' (unused-variable)
W:1302, 8: Unused variable 'snap_path_2' (unused-variable)
--
************* Module cinder.tests.test_gpfs
W: 52,12: Unused variable 'b' (unused-variable)
--
************* Module cinder.tests.test_hds
W:149,48: Unused variable 'target_index' (unused-variable)
W:149,31: Unused variable 'init_index' (unused-variable)
--
************* Module cinder.tests.test_hp3par
W:462, 8: Unused variable 'old_size' (unused-variable)
--
************* Module cinder.tests.test_migrations
W:238,12: Unused variable 'key' (unused-variable)
W:474,13: Unused variable 'key' (unused-variable)
W:490,13: Unused variable 'key' (unused-variable)
W:541,13: Unused variable 'key' (unused-variable)
W:603,13: Unused variable 'key' (unused-variable)
W:645,13: Unused variable 'key' (unused-variable)
W:688,13: Unused variable 'key' (unused-variable)
W:732,13: Unused variable 'key' (unused-variable)
W:758,13: Unused variable 'key' (unused-variable)
W:784,13: Unused variable 'key' (unused-variable)
W:810,13: Unused variable 'key' (unused-variable)
W:826,13: Unused variable 'key' (unused-variable)
W:854,13: Unused variable 'key' (unused-variable)
W:907,13: Unused variable 'key' (unused-variable)
W:945,13: Unused variable 'key' (unused-variable)
W:971,13: Unused variable 'key' (unused-variable)
W:1011,13: Unused variable 'key' (unused-variable)
W:1042,13: Unused variable 'key' (unused-variable)
--
************* Module cinder.tests.test_netapp
W:650,12: Unused variable 'driver' (unused-variable)
W:660,12: Unused variable 'driver' (unused-variable)
W:672,12: Unused variable 'driver' (unused-variable)
--
************* Module cinder.tests.test_qos_specs
W:379, 8: Unused variable 'id' (unused-variable)
--
************* Module cinder.tests.test_quota
W: 96,12: Unused variable 'i' (unused-variable)
--
************* Module cinder.tests.test_solidfire
W:224, 8: Unused variable 'model_update' (unused-variable)
--
************* Module cinder.tests.test_storwize_svc
W:175,12: Unused variable 'k' (unused-variable)
W:487,20: Unused variable 'mk' (unused-variable)
W:485,12: Unused variable 'hk' (unused-variable)
W:599,16: Unused variable 'k' (unused-variable)
W:634,12: Unused variable 'k' (unused-variable)
W:651,12: Unused variable 'k' (unused-variable)
W:763,12: Unused variable 'k' (unused-variable)
W:836,12: Unused variable 'k' (unused-variable)
W:850,16: Unused variable 'k' (unused-variable)
W:901,12: Unused variable 'k' (unused-variable)
W:937,12: Unused variable 'k' (unused-variable)
W:961,12: Unused variable 'k' (unused-variable)
W:979, 8: Unused variable 'index' (unused-variable)
W:981, 8: Unused variable 'delimeter' (unused-variable)
W:980, 8: Unused variable 'no_hdr' (unused-variable)
W:991,12: Unused variable 'k' (unused-variable)
W:1012,12: Unused variable 'k' (unused-variable)
W:1136,12: Unused variable 'k' (unused-variable)
W:1278,12: Unused variable 'k' (unused-variable)
W:1340,15: Unused variable 'v' (unused-variable)
W:2209, 8: Unused variable 'stats' (unused-variable)
--
************* Module cinder.tests.test_vmware_vmdk
W:349, 8: Unused variable 'task' (unused-variable)
W:584, 8: Unused variable 'dc' (unused-variable)
W:1448, 8: Unused variable 'size_kb' (unused-variable)
W:1646, 8: Unused variable 'dc' (unused-variable)
--
************* Module cinder.tests.test_volume
W:592, 8: Unused variable 'admin_ctxt' (unused-variable)
W:642, 8: Unused variable 'admin_ctxt' (unused-variable)
W:1199, 8: Unused variable '_check' (unused-variable)
W:1209,12: Unused variable '_index' (unused-variable)
W:2318, 8: Unused variable 'vol' (unused-variable)
--
************* Module cinder.tests.test_volume_glance_metadata
W: 44, 8: Unused variable 'vol_metadata' (unused-variable)
W:113, 8: Unused variable 'vol_metadata' (unused-variable)
W:123, 8: Unused variable 'vol_meta' (unused-variable)
W:139, 8: Unused variable 'vol_meta' (unused-variable)
--
************* Module cinder.tests.test_volume_types
W: 87, 8: Unused variable 'type_ref' (unused-variable)
W: 98, 8: Unused variable 'session' (unused-variable)
--
************* Module cinder.tests.test_wsgi
W:256, 8: Unused variable 'msg' (unused-variable)
--
************* Module cinder.tests.test_xenapi_sm
W:124, 8: Unused variable 'result' (unused-variable)
--
************* Module cinder.tests.test_zadara
W:246,13: Unused variable 'vol_name' (unused-variable)
W:261,13: Unused variable 'vol_name' (unused-variable)
W:434,13: Unused variable 'vol_name' (unused-variable)
W:574, 8: Unused variable 'props1' (unused-variable)
W:575, 8: Unused variable 'props2' (unused-variable)
W:576, 8: Unused variable 'props3' (unused-variable)
W:590, 8: Unused variable 'connector3' (unused-variable)
W:589, 8: Unused variable 'connector2' (unused-variable)
W:587, 8: Unused variable 'volume3' (unused-variable)
W:586, 8: Unused variable 'volume2' (unused-variable)
W:608, 8: Unused variable 'props1' (unused-variable)
W:609, 8: Unused variable 'props2' (unused-variable)
W:669, 8: Unused variable 'props1' (unused-variable)
W:670, 8: Unused variable 'props2' (unused-variable)
W:671, 8: Unused variable 'props3' (unused-variable)
--
************* Module cinder.utils
W:389,43: Unused variable '_i' (unused-variable)
W:530,36: Unused variable 'se' (unused-variable)
W:726,13: Unused variable '_err' (unused-variable)
--
************* Module cinder.volume.driver
W:537,18: Unused variable '_err' (unused-variable)
--
************* Module cinder.volume.drivers.block_device
W:363,13: Unused variable 'err' (unused-variable)
--
************* Module cinder.volume.drivers.emc.emc_smis_common
W:654,16: Unused variable 'controller' (unused-variable)
W:699,12: Unused variable 'controller' (unused-variable)
W:860,14: Unused variable 'storagesystem' (unused-variable)
--
************* Module cinder.volume.drivers.emc.emc_smis_iscsi
W:115,14: Unused variable '_err' (unused-variable)
--
************* Module cinder.volume.drivers.gpfs
W:300,14: Unused variable 'err' (unused-variable)
W:346,14: Unused variable 'err' (unused-variable)
--
************* Module cinder.volume.drivers.hds.hds
W:100,31: Unused variable 'e' (unused-variable)
W:213,28: Unused variable '_ign' (unused-variable)
W:316,20: Unused variable '_ctl' (unused-variable)
W:316, 9: Unused variable '_ip' (unused-variable)
W:316,14: Unused variable '_ipp' (unused-variable)
W:316,26: Unused variable '_port' (unused-variable)
W:339,20: Unused variable '_ctl' (unused-variable)
W:339,26: Unused variable '_port' (unused-variable)
W:339, 9: Unused variable '_ip' (unused-variable)
W:339,14: Unused variable '_ipp' (unused-variable)
W:364, 8: Unused variable 'out' (unused-variable)
W:385,27: Unused variable 'loc' (unused-variable)
W:385,13: Unused variable '_portal' (unused-variable)
W:386,12: Unused variable '_out' (unused-variable)
W:414,29: Unused variable '_hdp' (unused-variable)
W:449, 9: Unused variable '_portal' (unused-variable)
W:451, 8: Unused variable '_out' (unused-variable)
W:468,20: Unused variable '_ctl' (unused-variable)
W:468, 9: Unused variable '_ip' (unused-variable)
W:468,14: Unused variable '_ipp' (unused-variable)
W:468,26: Unused variable '_port' (unused-variable)
W:515, 8: Unused variable '_out' (unused-variable)
--
************* Module cinder.volume.drivers.huawei.huawei_utils
W: 74, 4: Unused variable 'value' (unused-variable)
--
************* Module cinder.volume.drivers.huawei.ssh_common
W:412, 8: Unused variable 'maxpool_id' (unused-variable)
W:413, 8: Unused variable 'maxpool_size' (unused-variable)
--
************* Module cinder.volume.driver
W:561,18: Unused variable 'err' (unused-variable)
--
************* Module cinder.volume.drivers.netapp.iscsi
W:378,19: Unused variable 'splitter' (unused-variable)
W:378,13: Unused variable 'rest' (unused-variable)
W:416,13: Unused variable 'igroup' (unused-variable)
W:424,22: Unused variable 'lun_id' (unused-variable)
W:1319,17: Unused variable 'splitter' (unused-variable)
--
************* Module cinder.volume.drivers.netapp.nfs
W: 96,36: Unused variable 'e' (unused-variable)
W:289,43: Unused variable 'total_alc' (unused-variable)
W:324,13: Unused variable '__' (unused-variable)
W:438,13: Unused variable '__' (unused-variable)
W:438,17: Unused variable '___' (unused-variable)
W:773,27: Unused variable 'alloc' (unused-variable)
W:775,27: Unused variable 'b' (unused-variable)
W:1101, 9: Unused variable 'host_ip' (unused-variable)
W:1189,32: Unused variable 'e' (unused-variable)
--
************* Module cinder.volume.drivers.netapp.ssc_utils
W:303,26: Unused variable '__' (unused-variable)
W:303,21: Unused variable '___' (unused-variable)
--
************* Module cinder.volume.drivers.nfs
W:340,28: Unused variable 'used' (unused-variable)
W:479,12: Unused variable 'total_size' (unused-variable)
W:479,24: Unused variable 'total_available' (unused-variable)
--
************* Module cinder.volume.drivers.rbd
W:366,26: Unused variable 'snap' (unused-variable)
W:366,12: Unused variable 'pool' (unused-variable)
W:420,20: Unused variable 'pool' (unused-variable)
W:564,12: Unused variable '_pool' (unused-variable)
W:618,16: Unused variable 'pool' (unused-variable)
W:756, 8: Unused variable 'prefix' (unused-variable)
--
************* Module cinder.volume.drivers.san.hp.hp_3par_common
W:203,44: Unused variable 'ex' (unused-variable)
W:202,12: Unused variable 'cpg' (unused-variable)
W:298,17: Unused variable 'stderr' (unused-variable)
--
************* Module cinder.volume.drivers.san.hp.hp_3par_fc
W:263,44: Unused variable 'ex' (unused-variable)
--
************* Module cinder.volume.drivers.san.hp_lefthand
W: 91,14: Unused variable '_err' (unused-variable)
W:302,12: Unused variable 'volume_info' (unused-variable)
W:314,12: Unused variable 'volume_info' (unused-variable)
--
************* Module cinder.volume.drivers.san.san
W:121,12: Unused variable 'total_attempts' (unused-variable)
--
************* Module cinder.volume.drivers.san.solaris
W: 71,14: Unused variable '_err' (unused-variable)
W: 84,14: Unused variable '_err' (unused-variable)
W: 93,14: Unused variable '_err' (unused-variable)
W:104,14: Unused variable '_err' (unused-variable)
W:150,14: Unused variable '_err' (unused-variable)
--
************* Module cinder.volume.drivers.sheepdog
W: 57,18: Unused variable 'err' (unused-variable)
W:171,20: Unused variable '_err' (unused-variable)
--
************* Module cinder.volume.drivers.solidfire
W:535,15: Unused variable 'sfaccount' (unused-variable)
W:535, 9: Unused variable 'data' (unused-variable)
W:606, 9: Unused variable 'data' (unused-variable)
W:606,26: Unused variable 'model' (unused-variable)
W:606,15: Unused variable 'sfaccount' (unused-variable)
W:613,15: Unused variable 'sfaccount' (unused-variable)
W:613, 9: Unused variable 'data' (unused-variable)
--
************* Module cinder.volume.drivers.storwize_svc
W:228,22: Unused variable 'foo' (unused-variable)
W:532,27: Unused variable 'foo' (unused-variable)
W:632,13: Unused variable 'err' (unused-variable)
W:648,13: Unused variable 'err' (unused-variable)
W:742,31: Unused variable 'e' (unused-variable)
W:822,16: Unused variable 'k' (unused-variable)
W:974,13: Unused variable 'err' (unused-variable)
W:1035, 8: Unused variable 'model_update' (unused-variable)
W:1114,17: Unused variable 'err' (unused-variable)
W:1114,12: Unused variable 'out' (unused-variable)
W:1132,12: Unused variable 'try_number' (unused-variable)
W:1172,17: Unused variable 'err' (unused-variable)
W:1172,12: Unused variable 'out' (unused-variable)
W:1317,25: Unused variable 'err' (unused-variable)
W:1317,20: Unused variable 'out' (unused-variable)
W:1749,25: Unused variable 'foo' (unused-variable)
W:1851,20: Unused variable 'stderr' (unused-variable)
--
************* Module cinder.volume.drivers.vmware.read_write_util
W:149,45: Unused variable 'fragment' (unused-variable)
W:149,30: Unused variable 'params' (unused-variable)
W:211,45: Unused variable 'fragment' (unused-variable)
W:211,30: Unused variable 'params' (unused-variable)
--
************* Module cinder.volume.drivers.vmware.vmdk
W:744,13: Unused variable 'host' (unused-variable)
W:955,25: Unused variable 'resource_pool' (unused-variable)
--
************* Module cinder.volume.drivers.xenapi.lib
W:516,12: Unused variable 'result' (unused-variable)
--
************* Module cinder.volume.drivers.xenapi.sm
W:133, 8: Unused variable 'volume_id' (unused-variable)
--
************* Module cinder.volume.drivers.zadara
W:331,19: Unused variable 'size' (unused-variable)
--
************* Module ext.cinder_todo
W: 40,12: Unused variable 'filename' (unused-variable)
W: 45,12: Unused variable 'line_info' (unused-variable)
--
************* Module extract_opts
W:111,15: Unused variable 'port' (unused-variable)

Tags:

Wu Wenxiang (wu-wenxiang) on 2014-01-11

Changed in cinder:
assignee:	nobody → Wu Wenxiang (wu-wenxiang)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-01-11: Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/66109

Revision history for this message

Duncan Thomas (duncan-thomas) wrote on 2014-01-16:

I'm not convinced unused variables in the tests are a bug, if they are indicative of the normal use of the interface... I'd rather see pylint warnings in the test directory than lose this type of implicit documentation...

Revision history for this message

Wu Wenxiang (wu-wenxiang) wrote on 2014-01-16:

hello, Duncan Thomas

Sure, unused variables in tests will be handled carefully.

For example:
    aVar = aDict["aKey"] #aVar is unused
    Change to:
    assertTrue(aDict.haskey("aKey"))

Mike Perez (thingee) on 2014-10-04

Changed in cinder:
status:	In Progress → Triaged
assignee:	Wu Wenxiang (wu-wenxiang) → nobody
importance:	Undecided → Wishlist
tags:	added: low-hanging-fruit

Mike Mason (mikemason010) on 2014-10-10

Changed in cinder:
assignee:	nobody → Mike Mason (mikemason010)

Revision history for this message

Eric Harney (eharney) wrote on 2014-10-10:

Please be careful with this and don't try to just remove them all. Sometimes these variables serve a useful purpose as documentation / help in understanding flow. The goal here needs to be readable code.

(I also thought that we didn't lint on unused variables that begin with underscore, which can be used to "ignore" certain method returns, etc.)

Revision history for this message

Mike Mason (mikemason010) wrote on 2014-10-10: Re: [Bug 1268062] Re: remove unused variables

Download full text (25.1 KiB)

I am going to break them down into sections and not remove all the
variables all in one go. I took this bug to get me used to the process, I
am bit going to rush it don't worry

Mike
On Oct 10, 2014 4:51 PM, "Eric Harney" <email address hidden> wrote:

I am going to break them down into sections and not remove all the
variables all in one go. I took this bug to get me used to the process, I
am bit going to rush it don't worry

Mike
On Oct 10, 2014 4:51 PM, "Eric Harney" <1268062@bugs.launchpad.net> wrote:

> Please be careful with this and don't try to just remove them all.
> Sometimes these variables serve a useful purpose as documentation / help
> in understanding flow.  The goal here needs to be readable code.
>
> (I also thought that we didn't lint on unused variables that begin with
> underscore, which can be used to "ignore" certain method returns, etc.)
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1268062
>
> Title:
>   remove unused variables
>
> Status in Cinder:
>   Triaged
>
> Bug description:
>   ************* Module cinder.api.contrib.volume_actions
>   W:278,12: Unused variable '_val' (unused-variable)
>   --
>   ************* Module cinder.api.extensions
>   W:152,12: Unused variable '_alias' (unused-variable)
>   --
>   ************* Module cinder.api.middleware.auth
>   W:144,17: Unused variable '_sep' (unused-variable)
>   --
>   ************* Module cinder.api.openstack.wsgi
>   W:601,12: Unused variable '_mtype' (unused-variable)
>   --
>   ************* Module cinder.backup.drivers.ceph
>   W:441, 8: Unused variable 'stdout' (unused-variable)
>   --
>   ************* Module cinder.backup.drivers.swift
>   W:222, 9: Unused variable 'resp' (unused-variable)
>   W:372,17: Unused variable 'resp' (unused-variable)
>   --
>   ************* Module cinder.backup.drivers.tsm
>   W:205,33: Unused variable 'e' (unused-variable)
>   --
>   ************* Module cinder.brick.exception
>   W: 52,16: Unused variable 'exc_info' (unused-variable)
>   --
>   ************* Module cinder.brick.initiator.connector
>   W:135, 8: Unused variable 'out' (unused-variable)
>   W:301,19: Unused variable '_err' (unused-variable)
>   --
>   ************* Module cinder.brick.initiator.linuxfc
>   W: 42,17: Unused variable 'err' (unused-variable)
>   --
>   ************* Module cinder.brick.initiator.linuxscsi
>   W: 62,14: Unused variable 'err' (unused-variable)
>   W:120,18: Unused variable 'err' (unused-variable)
>   --
>   ************* Module cinder.brick.iscsi.iscsi
>   W:104,14: Unused variable 'err' (unused-variable)
>   W:119,14: Unused variable 'err' (unused-variable)
>   W:457,14: Unused variable 'err' (unused-variable)
>   W:540, 9: Unused variable 'auth_method' (unused-variable)
>   --
>   ************* Module cinder.brick.local_dev.lvm
>   W:104,14: Unused variable 'err' (unused-variable)
>   W:120,14: Unused variable 'err' (unused-variable)
>   W:174,14: Unused variable 'err' (unused-variable)
>   W:230,14: Unused variable 'err' (unused-variable)
>   W:260,14: Unused variable 'err' (unused-variable)
>   W:312,14: Unused variable 'err' (unused-variable)
>   W:357,14: Unused variable 'err' (unused-variable)
>   W:604,13: Unused variable 'err' (unused-variable)
>   --
>   ************* Module cinder.brick.remotefs.remotefs
>   W: 70,14: Unused variable 'err' (unused-variable)
>   --
>   ************* Module cinder.common.config
>   W: 51,15: Unused variable 'port' (unused-variable)
>   --
>   ************* Module cinder.common.sqlalchemyutils
>   W: 76,34: Unused variable '_sort_key' (unused-variable)
>   --
>   ************* Module cinder.db.sqlalchemy.api
>   W:201,14: Unused variable 'gigs' (unused-variable)
>   W:211,16: Unused variable 'gigs' (unused-variable)
>   W:221, 5: Unused variable '_junk' (unused-variable)
>   W:1635,57: Unused variable 'e' (unused-variable)
>   W:1930,61: Unused variable 'e' (unused-variable)
>   W:2204,52: Unused variable 'e' (unused-variable)
>   W:2657,12: Unused variable 'volume_status' (unused-variable)
>   --
>   ************* Module
> cinder.db.sqlalchemy.migrate_repo.versions.003_glance_metadata
>   W: 30, 4: Unused variable 'volumes' (unused-variable)
>   W: 35, 4: Unused variable 'snapshots' (unused-variable)
>   --
>   ************* Module
> cinder.db.sqlalchemy.migrate_repo.versions.009_add_snapshot_metadata_table
>   W: 25, 4: Unused variable 'snapshots' (unused-variable)
>   --
>   ************* Module
> cinder.db.sqlalchemy.migrate_repo.versions.010_add_transfers_table
>   W: 25, 4: Unused variable 'volumes' (unused-variable)
>   --
>   ************* Module
> cinder.db.sqlalchemy.migrate_repo.versions.020_add_volume_admin_metadata_table
>   W: 25, 4: Unused variable '_volumes' (unused-variable)
>   --
>   ************* Module cinder.image.glance
>   W:440, 4: Unused variable 'exc_type' (unused-variable)
>   W:447, 4: Unused variable 'exc_type' (unused-variable)
>   --
>   ************* Module cinder.image.image_utils
>   W: 58, 9: Unused variable 'err' (unused-variable)
>   W:298, 9: Unused variable 'err' (unused-variable)
>   --
>   ************* Module cinder.openstack.common.db.sqlalchemy.utils
>   W: 82,34: Unused variable '_sort_key' (unused-variable)
>   --
>   ************* Module cinder.openstack.common.importutils
>   W: 28,13: Unused variable '_sep' (unused-variable)
>   --
>   ************* Module logging
>   W:512,13: Unused variable '_sep' (unused-variable)
>   --
>   ************* Module cinder.openstack.common.rootwrap.filters
>   W:107, 8: Unused variable 'command' (unused-variable)
>   --
>   ************* Module cinder.openstack.common.rpc.matchmaker
>   W:160,32: Unused variable 'bit' (unused-variable)
>   --
>   ************* Module cinder.openstack.common.timeutils
>   W:135,12: Unused variable 'dt' (unused-variable)
>   --
>   ************* Module cinder.scheduler.simple
>   W: 48, 8: Unused variable 'image_id' (unused-variable)
>   W: 47, 8: Unused variable 'snapshot_id' (unused-variable)
>   W: 46, 8: Unused variable 'volume_id' (unused-variable)
>   W: 56,18: Unused variable '_x' (unused-variable)
>   --
>   ************* Module cinder.tests.api.contrib.test_admin_actions
>   W:691, 8: Unused variable 'volume' (unused-variable)
>   W:707, 8: Unused variable 'volume' (unused-variable)
>   --
>   ************* Module
> cinder.tests.api.contrib.test_extended_snapshot_attributes
>   W: 95,12: Unused variable 'i' (unused-variable)
>   --
>   ************* Module cinder.tests.api.contrib.test_used_limits
>   W: 51,12: Unused variable 'display_name' (unused-variable)
>   --
>   ************* Module cinder.tests.api.contrib.test_volume_actions
>   W:322,12: Unused variable 'name' (unused-variable)
>   --
>   ************* Module cinder.tests.api.fakes
>   W: 87, 4: Unused variable 'fake_rate_init' (unused-variable)
>   W:103, 4: Unused variable 'one_key_pair' (unused-variable)
>   W:100, 4: Unused variable 'key_pair' (unused-variable)
>   W:109, 4: Unused variable 'no_key_pair' (unused-variable)
>   --
>   ************* Module cinder.tests.api.middleware.test_sizelimit
>   W: 54,12: Unused variable 'bytes_read' (unused-variable)
>   W: 63,12: Unused variable 'bytes_read' (unused-variable)
>   --
>   ************* Module cinder.tests.api.openstack.test_wsgi
>   W:277,16: Unused variable 'extensions' (unused-variable)
>   W:300,16: Unused variable 'extensions' (unused-variable)
>   W:313,16: Unused variable 'extensions' (unused-variable)
>   W:348,16: Unused variable 'extensions' (unused-variable)
>   W:644,12: Unused variable 'resp_obj' (unused-variable)
>   W:649,12: Unused variable 'resp_obj' (unused-variable)
>   W:749,12: Unused variable 'resp_obj' (unused-variable)
>   W:753,12: Unused variable 'resp_obj' (unused-variable)
>   W:778,12: Unused variable 'resp_obj' (unused-variable)
>   W:782,12: Unused variable 'resp_obj' (unused-variable)
>   W:852,12: Unused variable '_mtype' (unused-variable)
>   W:861,12: Unused variable '_mtype' (unused-variable)
>   W:907, 8: Unused variable 'resource' (unused-variable)
>   W:911, 8: Unused variable 'resource' (unused-variable)
>   W:915, 8: Unused variable 'resource' (unused-variable)
>   W:920, 8: Unused variable 'resource' (unused-variable)
>   --
>   ************* Module cinder.tests.api.v1.test_limits
>   W:405,12: Unused variable 'x' (unused-variable)
>   W:600, 8: Unused variable 'requests' (unused-variable)
>   --
>   ************* Module cinder.tests.api.v1.test_volumes
>   W:121, 8: Unused variable 'volume_id' (unused-variable)
>   --
>   ************* Module cinder.tests.api.v2.test_limits
>   W:410,12: Unused variable 'x' (unused-variable)
>   --
>   ************* Module cinder.tests.brick.test_brick_connector
>   W:518, 8: Unused variable 'aoe_device' (unused-variable)
>   W:525,12: Unused variable 'i' (unused-variable)
>   --
>   ************* Module cinder.tests.brick.test_brick_linuxscsi
>   W:104, 8: Unused variable 'fake_execute2' (unused-variable)
>   --
>   ************* Module cinder.tests.compute.test_nova
>   W: 45, 8: Unused variable 'volume_id' (unused-variable)
>   --
>   ************* Module cinder.tests.image.fake
>   W:232, 4: Unused variable 'fake_get_remote_image_service'
> (unused-variable)
>   --
>   ************* Module cinder.tests.image.test_glance
>   W:526, 9: Unused variable 'service' (unused-variable)
>   --
>   ************* Module cinder.tests.scheduler.test_scheduler_options
>   W: 74, 8: Unused variable 'data' (unused-variable)
>   --
>   ************* Module cinder.tests.test_backup
>   W:368, 8: Unused variable 'b1' (unused-variable)
>   --
>   ************* Module cinder.tests.test_backup_ceph
>   W:111,12: Unused variable 'i' (unused-variable)
>   W:242,16: Unused variable 'c' (unused-variable)
>   W:310,16: Unused variable 'c' (unused-variable)
>   W:443,16: Unused variable 'c' (unused-variable)
>   W:572, 8: Unused variable 'del_base_image' (unused-variable)
>   W:583, 8: Unused variable 'del_base_image' (unused-variable)
>   --
>   ************* Module cinder.tests.test_backup_swift
>   W: 74,12: Unused variable 'i' (unused-variable)
>   --
>   ************* Module cinder.tests.test_backup_tsm
>   W:112,21: Unused variable 'backup' (unused-variable)
>   --
>   ************* Module cinder.tests.test_conf
>   W: 50, 8: Unused variable 'cinder' (unused-variable)
>   --
>   ************* Module cinder.tests.test_db_api
>   W: 40, 4: Unused variable 'get_sync' (unused-variable)
>   W:153, 8: Unused variable 'service2' (unused-variable)
>   W:163, 8: Unused variable 'service2' (unused-variable)
>   W:301,16: Unused variable 'j' (unused-variable)
>   W:378,32: Unused variable 'j' (unused-variable)
>   W:392,32: Unused variable 'j' (unused-variable)
>   W:406,46: Unused variable 'j' (unused-variable)
>   W:414, 8: Unused variable 'target' (unused-variable)
>   W:477, 8: Unused variable 'snapshot' (unused-variable)
>   W:725, 8: Unused variable 'reservations' (unused-variable)
>   W:771, 8: Unused variable 'sample1' (unused-variable)
>   W:772, 8: Unused variable 'sample2' (unused-variable)
>   W:784, 8: Unused variable 'sample1' (unused-variable)
>   W:785, 8: Unused variable 'sample2' (unused-variable)
>   W:878, 8: Unused variable 'reservations' (unused-variable)
>   W:886, 8: Unused variable 'reservations' (unused-variable)
>   --
>   ************* Module cinder.tests.test_emc
>   W:689, 8: Unused variable 'connection_info' (unused-variable)
>   --
>   ************* Module cinder.tests.test_glusterfs
>   W:727, 8: Unused variable 'snap_filename' (unused-variable)
>   W:742, 8: Unused variable 'qemu_img_info_output' (unused-variable)
>   W:790, 8: Unused variable 'snap_path' (unused-variable)
>   W:826, 8: Unused variable 'snap_path_2_chain' (unused-variable)
>   W:830, 8: Unused variable 'snap_path_chain' (unused-variable)
>   W:885, 8: Unused variable 'qemu_img_info_output_snap_2' (unused-variable)
>   W:901, 8: Unused variable 'qemu_img_info_output' (unused-variable)
>   W:1302, 8: Unused variable 'snap_path_2' (unused-variable)
>   --
>   ************* Module cinder.tests.test_gpfs
>   W: 52,12: Unused variable 'b' (unused-variable)
>   --
>   ************* Module cinder.tests.test_hds
>   W:149,48: Unused variable 'target_index' (unused-variable)
>   W:149,31: Unused variable 'init_index' (unused-variable)
>   --
>   ************* Module cinder.tests.test_hp3par
>   W:462, 8: Unused variable 'old_size' (unused-variable)
>   --
>   ************* Module cinder.tests.test_migrations
>   W:238,12: Unused variable 'key' (unused-variable)
>   W:474,13: Unused variable 'key' (unused-variable)
>   W:490,13: Unused variable 'key' (unused-variable)
>   W:541,13: Unused variable 'key' (unused-variable)
>   W:603,13: Unused variable 'key' (unused-variable)
>   W:645,13: Unused variable 'key' (unused-variable)
>   W:688,13: Unused variable 'key' (unused-variable)
>   W:732,13: Unused variable 'key' (unused-variable)
>   W:758,13: Unused variable 'key' (unused-variable)
>   W:784,13: Unused variable 'key' (unused-variable)
>   W:810,13: Unused variable 'key' (unused-variable)
>   W:826,13: Unused variable 'key' (unused-variable)
>   W:854,13: Unused variable 'key' (unused-variable)
>   W:907,13: Unused variable 'key' (unused-variable)
>   W:945,13: Unused variable 'key' (unused-variable)
>   W:971,13: Unused variable 'key' (unused-variable)
>   W:1011,13: Unused variable 'key' (unused-variable)
>   W:1042,13: Unused variable 'key' (unused-variable)
>   --
>   ************* Module cinder.tests.test_netapp
>   W:650,12: Unused variable 'driver' (unused-variable)
>   W:660,12: Unused variable 'driver' (unused-variable)
>   W:672,12: Unused variable 'driver' (unused-variable)
>   --
>   ************* Module cinder.tests.test_qos_specs
>   W:379, 8: Unused variable 'id' (unused-variable)
>   --
>   ************* Module cinder.tests.test_quota
>   W: 96,12: Unused variable 'i' (unused-variable)
>   --
>   ************* Module cinder.tests.test_solidfire
>   W:224, 8: Unused variable 'model_update' (unused-variable)
>   --
>   ************* Module cinder.tests.test_storwize_svc
>   W:175,12: Unused variable 'k' (unused-variable)
>   W:487,20: Unused variable 'mk' (unused-variable)
>   W:485,12: Unused variable 'hk' (unused-variable)
>   W:599,16: Unused variable 'k' (unused-variable)
>   W:634,12: Unused variable 'k' (unused-variable)
>   W:651,12: Unused variable 'k' (unused-variable)
>   W:763,12: Unused variable 'k' (unused-variable)
>   W:836,12: Unused variable 'k' (unused-variable)
>   W:850,16: Unused variable 'k' (unused-variable)
>   W:901,12: Unused variable 'k' (unused-variable)
>   W:937,12: Unused variable 'k' (unused-variable)
>   W:961,12: Unused variable 'k' (unused-variable)
>   W:979, 8: Unused variable 'index' (unused-variable)
>   W:981, 8: Unused variable 'delimeter' (unused-variable)
>   W:980, 8: Unused variable 'no_hdr' (unused-variable)
>   W:991,12: Unused variable 'k' (unused-variable)
>   W:1012,12: Unused variable 'k' (unused-variable)
>   W:1136,12: Unused variable 'k' (unused-variable)
>   W:1278,12: Unused variable 'k' (unused-variable)
>   W:1340,15: Unused variable 'v' (unused-variable)
>   W:2209, 8: Unused variable 'stats' (unused-variable)
>   --
>   ************* Module cinder.tests.test_vmware_vmdk
>   W:349, 8: Unused variable 'task' (unused-variable)
>   W:584, 8: Unused variable 'dc' (unused-variable)
>   W:1448, 8: Unused variable 'size_kb' (unused-variable)
>   W:1646, 8: Unused variable 'dc' (unused-variable)
>   --
>   ************* Module cinder.tests.test_volume
>   W:592, 8: Unused variable 'admin_ctxt' (unused-variable)
>   W:642, 8: Unused variable 'admin_ctxt' (unused-variable)
>   W:1199, 8: Unused variable '_check' (unused-variable)
>   W:1209,12: Unused variable '_index' (unused-variable)
>   W:2318, 8: Unused variable 'vol' (unused-variable)
>   --
>   ************* Module cinder.tests.test_volume_glance_metadata
>   W: 44, 8: Unused variable 'vol_metadata' (unused-variable)
>   W:113, 8: Unused variable 'vol_metadata' (unused-variable)
>   W:123, 8: Unused variable 'vol_meta' (unused-variable)
>   W:139, 8: Unused variable 'vol_meta' (unused-variable)
>   --
>   ************* Module cinder.tests.test_volume_types
>   W: 87, 8: Unused variable 'type_ref' (unused-variable)
>   W: 98, 8: Unused variable 'session' (unused-variable)
>   --
>   ************* Module cinder.tests.test_wsgi
>   W:256, 8: Unused variable 'msg' (unused-variable)
>   --
>   ************* Module cinder.tests.test_xenapi_sm
>   W:124, 8: Unused variable 'result' (unused-variable)
>   --
>   ************* Module cinder.tests.test_zadara
>   W:246,13: Unused variable 'vol_name' (unused-variable)
>   W:261,13: Unused variable 'vol_name' (unused-variable)
>   W:434,13: Unused variable 'vol_name' (unused-variable)
>   W:574, 8: Unused variable 'props1' (unused-variable)
>   W:575, 8: Unused variable 'props2' (unused-variable)
>   W:576, 8: Unused variable 'props3' (unused-variable)
>   W:590, 8: Unused variable 'connector3' (unused-variable)
>   W:589, 8: Unused variable 'connector2' (unused-variable)
>   W:587, 8: Unused variable 'volume3' (unused-variable)
>   W:586, 8: Unused variable 'volume2' (unused-variable)
>   W:608, 8: Unused variable 'props1' (unused-variable)
>   W:609, 8: Unused variable 'props2' (unused-variable)
>   W:669, 8: Unused variable 'props1' (unused-variable)
>   W:670, 8: Unused variable 'props2' (unused-variable)
>   W:671, 8: Unused variable 'props3' (unused-variable)
>   --
>   ************* Module cinder.utils
>   W:389,43: Unused variable '_i' (unused-variable)
>   W:530,36: Unused variable 'se' (unused-variable)
>   W:726,13: Unused variable '_err' (unused-variable)
>   --
>   ************* Module cinder.volume.driver
>   W:537,18: Unused variable '_err' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.block_device
>   W:363,13: Unused variable 'err' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.emc.emc_smis_common
>   W:654,16: Unused variable 'controller' (unused-variable)
>   W:699,12: Unused variable 'controller' (unused-variable)
>   W:860,14: Unused variable 'storagesystem' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.emc.emc_smis_iscsi
>   W:115,14: Unused variable '_err' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.gpfs
>   W:300,14: Unused variable 'err' (unused-variable)
>   W:346,14: Unused variable 'err' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.hds.hds
>   W:100,31: Unused variable 'e' (unused-variable)
>   W:213,28: Unused variable '_ign' (unused-variable)
>   W:316,20: Unused variable '_ctl' (unused-variable)
>   W:316, 9: Unused variable '_ip' (unused-variable)
>   W:316,14: Unused variable '_ipp' (unused-variable)
>   W:316,26: Unused variable '_port' (unused-variable)
>   W:339,20: Unused variable '_ctl' (unused-variable)
>   W:339,26: Unused variable '_port' (unused-variable)
>   W:339, 9: Unused variable '_ip' (unused-variable)
>   W:339,14: Unused variable '_ipp' (unused-variable)
>   W:364, 8: Unused variable 'out' (unused-variable)
>   W:385,27: Unused variable 'loc' (unused-variable)
>   W:385,13: Unused variable '_portal' (unused-variable)
>   W:386,12: Unused variable '_out' (unused-variable)
>   W:414,29: Unused variable '_hdp' (unused-variable)
>   W:449, 9: Unused variable '_portal' (unused-variable)
>   W:451, 8: Unused variable '_out' (unused-variable)
>   W:468,20: Unused variable '_ctl' (unused-variable)
>   W:468, 9: Unused variable '_ip' (unused-variable)
>   W:468,14: Unused variable '_ipp' (unused-variable)
>   W:468,26: Unused variable '_port' (unused-variable)
>   W:515, 8: Unused variable '_out' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.huawei.huawei_utils
>   W: 74, 4: Unused variable 'value' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.huawei.ssh_common
>   W:412, 8: Unused variable 'maxpool_id' (unused-variable)
>   W:413, 8: Unused variable 'maxpool_size' (unused-variable)
>   --
>   ************* Module cinder.volume.driver
>   W:561,18: Unused variable 'err' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.netapp.iscsi
>   W:378,19: Unused variable 'splitter' (unused-variable)
>   W:378,13: Unused variable 'rest' (unused-variable)
>   W:416,13: Unused variable 'igroup' (unused-variable)
>   W:424,22: Unused variable 'lun_id' (unused-variable)
>   W:1319,17: Unused variable 'splitter' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.netapp.nfs
>   W: 96,36: Unused variable 'e' (unused-variable)
>   W:289,43: Unused variable 'total_alc' (unused-variable)
>   W:324,13: Unused variable '__' (unused-variable)
>   W:438,13: Unused variable '__' (unused-variable)
>   W:438,17: Unused variable '___' (unused-variable)
>   W:773,27: Unused variable 'alloc' (unused-variable)
>   W:775,27: Unused variable 'b' (unused-variable)
>   W:1101, 9: Unused variable 'host_ip' (unused-variable)
>   W:1189,32: Unused variable 'e' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.netapp.ssc_utils
>   W:303,26: Unused variable '__' (unused-variable)
>   W:303,21: Unused variable '___' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.nfs
>   W:340,28: Unused variable 'used' (unused-variable)
>   W:479,12: Unused variable 'total_size' (unused-variable)
>   W:479,24: Unused variable 'total_available' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.rbd
>   W:366,26: Unused variable 'snap' (unused-variable)
>   W:366,12: Unused variable 'pool' (unused-variable)
>   W:420,20: Unused variable 'pool' (unused-variable)
>   W:564,12: Unused variable '_pool' (unused-variable)
>   W:618,16: Unused variable 'pool' (unused-variable)
>   W:756, 8: Unused variable 'prefix' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.san.hp.hp_3par_common
>   W:203,44: Unused variable 'ex' (unused-variable)
>   W:202,12: Unused variable 'cpg' (unused-variable)
>   W:298,17: Unused variable 'stderr' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.san.hp.hp_3par_fc
>   W:263,44: Unused variable 'ex' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.san.hp_lefthand
>   W: 91,14: Unused variable '_err' (unused-variable)
>   W:302,12: Unused variable 'volume_info' (unused-variable)
>   W:314,12: Unused variable 'volume_info' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.san.san
>   W:121,12: Unused variable 'total_attempts' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.san.solaris
>   W: 71,14: Unused variable '_err' (unused-variable)
>   W: 84,14: Unused variable '_err' (unused-variable)
>   W: 93,14: Unused variable '_err' (unused-variable)
>   W:104,14: Unused variable '_err' (unused-variable)
>   W:150,14: Unused variable '_err' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.sheepdog
>   W: 57,18: Unused variable 'err' (unused-variable)
>   W:171,20: Unused variable '_err' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.solidfire
>   W:535,15: Unused variable 'sfaccount' (unused-variable)
>   W:535, 9: Unused variable 'data' (unused-variable)
>   W:606, 9: Unused variable 'data' (unused-variable)
>   W:606,26: Unused variable 'model' (unused-variable)
>   W:606,15: Unused variable 'sfaccount' (unused-variable)
>   W:613,15: Unused variable 'sfaccount' (unused-variable)
>   W:613, 9: Unused variable 'data' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.storwize_svc
>   W:228,22: Unused variable 'foo' (unused-variable)
>   W:532,27: Unused variable 'foo' (unused-variable)
>   W:632,13: Unused variable 'err' (unused-variable)
>   W:648,13: Unused variable 'err' (unused-variable)
>   W:742,31: Unused variable 'e' (unused-variable)
>   W:822,16: Unused variable 'k' (unused-variable)
>   W:974,13: Unused variable 'err' (unused-variable)
>   W:1035, 8: Unused variable 'model_update' (unused-variable)
>   W:1114,17: Unused variable 'err' (unused-variable)
>   W:1114,12: Unused variable 'out' (unused-variable)
>   W:1132,12: Unused variable 'try_number' (unused-variable)
>   W:1172,17: Unused variable 'err' (unused-variable)
>   W:1172,12: Unused variable 'out' (unused-variable)
>   W:1317,25: Unused variable 'err' (unused-variable)
>   W:1317,20: Unused variable 'out' (unused-variable)
>   W:1749,25: Unused variable 'foo' (unused-variable)
>   W:1851,20: Unused variable 'stderr' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.vmware.read_write_util
>   W:149,45: Unused variable 'fragment' (unused-variable)
>   W:149,30: Unused variable 'params' (unused-variable)
>   W:211,45: Unused variable 'fragment' (unused-variable)
>   W:211,30: Unused variable 'params' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.vmware.vmdk
>   W:744,13: Unused variable 'host' (unused-variable)
>   W:955,25: Unused variable 'resource_pool' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.xenapi.lib
>   W:516,12: Unused variable 'result' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.xenapi.sm
>   W:133, 8: Unused variable 'volume_id' (unused-variable)
>   --
>   ************* Module cinder.volume.drivers.zadara
>   W:331,19: Unused variable 'size' (unused-variable)
>   --
>   ************* Module ext.cinder_todo
>   W: 40,12: Unused variable 'filename' (unused-variable)
>   W: 45,12: Unused variable 'line_info' (unused-variable)
>   --
>   ************* Module extract_opts
>   W:111,15: Unused variable 'port' (unused-variable)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/cinder/+bug/1268062/+subscriptions
>

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-10-14: Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/128279

Changed in cinder:
status:	Triaged → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-10-15:

Fix proposed to branch: master
Review: https://review.openstack.org/128635

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-10-16: Change abandoned on cinder (master)

Change abandoned by Mike Mason (<email address hidden>) on branch: master
Review: https://review.openstack.org/128635
Reason: Will abandon both changes to close this bug and include it all in one review

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-10-16:

Change abandoned by Mike Mason (<email address hidden>) on branch: master
Review: https://review.openstack.org/128279
Reason: Will abandon both changes to close this bug and include it all in one review

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-10-17: Fix proposed to cinder (master)

#10

Fix proposed to branch: master
Review: https://review.openstack.org/129202

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-11-19: Fix merged to cinder (master)

#11

Reviewed: https://review.openstack.org/129202
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=d499f57d25cdb0c835746ed88cbdcfbf3c1757e3
Submitter: Jenkins
Branch: master

commit d499f57d25cdb0c835746ed88cbdcfbf3c1757e3
Author: Mike Mason <email address hidden>
Date: Fri Oct 17 10:46:26 2014 +0000

Amend unused variables to assist pylint testing

    Amedning unused variables with a prefix of an underscore to prevent them
    being picked up in pylint testing, consistency, and for general housekeeping.
    Change to pylintrc also required to enforce the rule.

Closes-bug #1268062

Change-Id: I80c2cbdc52d6f37823fae90d0096836166412643

Changed in cinder:
status:	In Progress → Fix Committed

Thierry Carrez (ttx) on 2014-12-18

Changed in cinder:
milestone:	none → kilo-1
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2015-04-30

Changed in cinder:
milestone:	kilo-1 → 2015.1.0

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.