[HDP] HDP plugin does not work with Heat engine

[Yaroslav Lobankov]

Reproduction steps:
Create cluster. For cluster creation use Heat as infrastructure engine.

EXPECTED RESULT: cluster is created.

ACTUAL RESULT: cluster is not created and remains in "Configuring" state.

2014-01-10 15:22:01.363 31033 ERROR savanna.context [-] Thread 'hdp-provision-instance-c-hdp-master-node-jt-nn-1' fails with exception: 'RemoteCommandException: Error during command execution: "curl -f -s -o /etc/yum.repos.d/ambari.repo http://s3.amazonaws.com/public-repo-1.hortonworks.com/ambari/centos6/1.x/updates/1.2.5.17/ambari.repo"
Return code: 23'
2014-01-10 15:22:01.363 31033 TRACE savanna.context Traceback (most recent call last):
2014-01-10 15:22:01.363 31033 TRACE savanna.context File "/home/ylobankov/Savanna/master/savanna/savanna/context.py", line 120, in _wrapper
2014-01-10 15:22:01.363 31033 TRACE savanna.context func(*args, **kwargs)
2014-01-10 15:22:01.363 31033 TRACE savanna.context File "/home/ylobankov/Savanna/master/savanna/savanna/plugins/hdp/hadoopserver.py", line 41, in provision_ambari
2014-01-10 15:22:01.363 31033 TRACE savanna.context self.install_rpms()
2014-01-10 15:22:01.363 31033 TRACE savanna.context File "/home/ylobankov/Savanna/master/savanna/savanna/plugins/hdp/savannautils.py", line 30, in call
2014-01-10 15:22:01.363 31033 TRACE savanna.context return func(self, *args, **newkwargs)
2014-01-10 15:22:01.363 31033 TRACE savanna.context File "/home/ylobankov/Savanna/master/savanna/savanna/plugins/hdp/hadoopserver.py", line 58, in install_rpms
2014-01-10 15:22:01.363 31033 TRACE savanna.context r.execute_command(rpm_cmd)
2014-01-10 15:22:01.363 31033 TRACE savanna.context File "/home/ylobankov/Savanna/master/savanna/savanna/utils/remote.py", line 346, in execute_command
2014-01-10 15:22:01.363 31033 TRACE savanna.context raise_when_error)
2014-01-10 15:22:01.363 31033 TRACE savanna.context File "/home/ylobankov/Savanna/master/savanna/savanna/utils/remote.py", line 418, in _run_s
2014-01-10 15:22:01.363 31033 TRACE savanna.context return self._run_with_log(func, timeout, *args, **kwargs)
2014-01-10 15:22:01.363 31033 TRACE savanna.context File "/home/ylobankov/Savanna/master/savanna/savanna/utils/remote.py", line 311, in _run_with_log
2014-01-10 15:22:01.363 31033 TRACE savanna.context return self._run(func, *args, **kwargs)
2014-01-10 15:22:01.363 31033 TRACE savanna.context File "/home/ylobankov/Savanna/master/savanna/savanna/utils/remote.py", line 415, in _run
2014-01-10 15:22:01.363 31033 TRACE savanna.context return procutils.run_in_subprocess(self.proc, func, args, kwargs)
2014-01-10 15:22:01.363 31033 TRACE savanna.context File "/home/ylobankov/Savanna/master/savanna/savanna/utils/procutils.py", line 52, in run_in_subprocess
2014-01-10 15:22:01.363 31033 TRACE savanna.context raise SubprocessException(result['exception'])
2014-01-10 15:22:01.363 31033 TRACE savanna.context SubprocessException: RemoteCommandException: Error during command execution: "curl -f -s -o /etc/yum.repos.d/ambari.repo http://s3.amazonaws.com/public-repo-1.hortonworks.com/ambari/centos6/1.x/updates/1.2.5.17/ambari.repo"
2014-01-10 15:22:01.363 31033 TRACE savanna.context Return code: 23
2014-01-10 15:22:01.363 31033 TRACE savanna.context

===
The reason of this failure is that Heat engine uses 'ec2-user' as user to connect to VMs and then Savanna runs SSH commands via
'ec2-user'. But now HDP plugin requiers 'root' as management user.

====
Solution is to replace all ssh calls in HDP plugin with 'sudo' word at the beginning of each command.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/65981
Committed: https://git.openstack.org/cgit/openstack/savanna/commit/?id=aa5bee809b417faeea4bda163ce8070a19036d90
Submitter: Jenkins
Branch: master

commit aa5bee809b417faeea4bda163ce8070a19036d90
Author: Yaroslav Lobankov <email address hidden>
Date: Fri Jan 10 18:59:15 2014 +0400

    Fixed HDP plugin to support Heat engine

    * Flag 'run_as_root' to methods 'execute_command', 'write_file_to', 'write_files_to', 'read_file_from' were added.

    Change-Id: I46e55570aaeb305f002e6e18daa0adf3d757577e
    Fixes: bug #1267817