installworker fails to set LAVA_DB_SERVER variable

[Alan Bennett]

Install new worker
  - LAVA_DB_PASSWORD=lava123 LAVA_MASTER=lavaservername ./lava-deployment-tool installworker productionssss -n

Check for the Server name in the instance.conf
  - grep LAVA_DB_SERVER /srv/lava/instances/productionssss/instance.conf
     LAVA_DB_SERVER=""

[Neil Williams (codehelp)]

In the example from the description, was the postgres database intended to be accessible from the remote worker at the location "lavaservername" ?

If support is needed for postgres installations separate from the main server running Apache, then a new default value would be needed.

[Alan Bennett (akbennett)]

I agree. Currently l-d-t remoteworker installations assume the DB resides on the LAVA_MASTER.

We should use (and document) a variable, such as LAVA_DB_MASTER to allow a installer to identify a specific DB Server address.

If that environment variable is not set, we then use the LAVA_MASTER (as we do today, maintaining backwards-compatibility)

[Neil Williams (codehelp)]

Change available for review: https://review.linaro.org/#/c/872/